kotovalexarian-likes-github/fog--fog
1
0
Fork 0
mirror of https://github.com/fog/fog.git synced 2022-11-09 13:51:43 -05:00
Code Releases Activity

[aws|compute] raise an ArgumentError if image_id is nil, otherwise an ugly InternalError is returned from AWS.

Browse source
This commit is contained in:
Dylan Egan 2011-09-14 11:35:22 +01:00
parent a842b3699e
commit 48b2f590aa
2 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/fog/aws/requests/compute/modify_image_attribute.rb
View file

@ -20,6 +20,8 @@ module Fog
# {Amazon API Reference}[http://docs.amazonwebservices.com/AWSEC2/latest/APIReference/ApiReference-query-ModifyImageAttribute.html]
#
def modify_image_attribute(image_id, attributes)
raise ArgumentError.new("image_id is required") unless image_id
params = {}
params.merge!(Fog::AWS.indexed_param('LaunchPermission.Add.%d.Group', attributes['Add.Group'] || []))
params.merge!(Fog::AWS.indexed_param('LaunchPermission.Add.%d.UserId', attributes['Add.UserId'] || []))

8
tests/aws/requests/compute/image_tests.rb
View file

@ -65,4 +65,12 @@ Shindo.tests('Fog::Compute[:aws] | image requests', ['aws']) do
end
end
end
tests('failure') do
pending if Fog.mocking?
tests("#modify_image_attribute(nil, { 'Add.Group' => ['all'] })").raises(ArgumentError) do
Fog::Compute[:aws].modify_image_attribute(nil, { 'Add.Group' => ['all'] }).body
end
end
end