Release 1.22.0

CHANGELOG.md

@@ -1,3 +1,157 @@
+## 1.22.0 04/17/2014
+*Hash* 6d2c2d0575f9f7337bd01d17428dc12b7105329a
+
+Statistic     | Value
+------------- | --------:
+Collaborators | 30
+Downloads     | 5038529
+Forks         | 1145
+Open Issues   | 157
+Watchers      | 2992
+
+**MVP!** Benson Kalahar
+
+#### [Brightbox]
+*   Update testing to MiniTest::Spec. thanks Paul Thornthwaite
+*   Test error when required args missing. thanks Paul Thornthwaite
+
+#### [GH-1390]
+*   Remove redundant calls to Fog.credentials. thanks Paul Thornthwaite
+
+#### [GH-2793]
+*   Exclude examples from documented methods. thanks Paul Thornthwaite
+
+#### [OpenStack]
+*   Use JSON instead of XML. thanks Evan Light
+
+#### [Rackspace]
+*   Remove circular requires from Storage. thanks Paul Thornthwaite
+
+#### [Rackspace|Monitoring]
+*   Add disabled flag to alarm.  Fixes issue #2731. thanks rebelagentm
+
+#### [Vsphere]
+*   Isolate helper from core. thanks Paul Thornthwaite
+
+#### [core]
+*   Remove providers/ directory from core fog gem. thanks Dominic Cleal
+*   converted changelog to markdown format. thanks Kyle Rames
+*   updated rake releases to generate markdown; added github_release task to publish to release feed. thanks Kyle Rames
+*   tweaking per @icco; fixing broken build. thanks Kyle Rames
+*   fixing gemspec for 1.8.7. thanks Kyle Rames
+*   locking rbovirt down to version 0.0.24 as the newly released 0.0.25 had broken some of our tests. thanks Kyle Rames
+
+#### [ecloud]
+*   adding :base_path as recognized parameter. thanks Kyle Rames
+
+#### [fog-brightbox]
+*   Prepare for v0.0.2 release. thanks Paul Thornthwaite
+*   Correct CHANGELOG categories. thanks Paul Thornthwaite
+
+#### [google]
+*   fixes set_tags. thanks Eric Johnson
+*   fix service_account scopes. thanks Eric Johnson
+
+#### [google|compute]
+*   allow user to set disk description. thanks Eric Johnson
+*   adding automaticRestart and onHostMaintenance. thanks Eric Johnson
+*   fix instance tags and remove zone lookup call. thanks Eric Johnson
+*   Add Projects support. thanks Ferran Rodenas
+*   Modify Flavors. thanks Ferran Rodenas
+*   Complete Operations support. thanks Ferran Rodenas
+*   Modify Snapshots. thanks Ferran Rodenas
+*   Add Firewalls support. thanks Ferran Rodenas
+*   Add Addresses support. thanks Ferran Rodenas
+*   Add Networks support. thanks Ferran Rodenas
+*   Add Routes support. thanks Ferran Rodenas
+*   Add Regions support. thanks Ferran Rodenas
+*   Make destroy methods consistent. thanks Nat Welch
+*   Update default zone and image. thanks Nat Welch
+*   Also tweak default disk in tests. thanks Nat Welch
+
+#### [joyent|compute]
+*   Added attributes to cloudapi responses recently to servers, Closes #2800. thanks Kevin Chan
+
+#### [misc]
+*   Allow auth URLs without a trailing slash. thanks Abhishek Chanda
+*   Spelling, trailing whitespace. thanks Ash Wilson
+*   Include the port in temp_url if necessary. thanks Ash Wilson
+*   Use URI::Generic.build to build the URI, instead. thanks Ash Wilson
+*   Test the relevant bits of the temp_urls explicitly. thanks Ash Wilson
+*   Refactor out common bits from temp_url tests. thanks Ash Wilson
+*   Fix get_object_http_url, too. thanks Ash Wilson
+*   One less extraneous whitespace change. thanks Ash Wilson
+*   Apply the pending modifier before Storage.new. thanks Ash Wilson
+*   adding #all! to Fog::DNS::Rackspace::Records to load in all records for a zone (max 500 with Rackspace). thanks Ben Hundley
+*   replacing #all! in Fog::DNS::Rackspace::Records with pagination in #each. thanks Ben Hundley
+*   Adds first cut of GCE http health checks. thanks Benson Kalahar
+*   @icco still can't spell. thanks Benson Kalahar
+*   Adds target pools. thanks Benson Kalahar
+*   Adds forwarding rules. It is possible to set up a load balancer. thanks Benson Kalahar
+*   Removed questionably trustworthy mocking code. thanks Benson Kalahar
+*   Also removed untrustworthy region operation mock. thanks Benson Kalahar
+*   Adds load balancer example, and fixes http_health_check bug. thanks Benson Kalahar
+*   Makes sleep before deleting disks longer to be safe. thanks Benson Kalahar
+*   Cleans up load balancer example. thanks Benson Kalahar
+*   Adds support for changing forwarding rule targets. thanks Benson Kalahar
+*   It might work. thanks Benson Kalahar
+*   Removes modification, instead relying on reload. thanks Benson Kalahar
+*   Makes disk delete optionally async. thanks Benson Kalahar
+*   Cloudstack servers get function will now find VM in projects for normal     users. thanks Carl Loa Odin
+*   fixed misspelling. thanks Christian Berendt
+*   few minor fixes. thanks Eric Johnson
+*   another quick fix. thanks Eric Johnson
+*   fix destroy and add ready?, other little cleanups. thanks Eric Johnson
+*   Replaces Fog::XML::Connection with Fog::Core::Connection so as to use     JSON again instead of wrongly using XML. thanks Evan Light
+*   Improve checking for Cloud Queue message IDs. thanks  Ollie
+*   don't use named capture groups for ruby 1.8.7 compatibility. thanks  Ollie
+*   Adding support for IAM roles and STS in the AWS::IAM service. thanks Joshua Garnett
+*   Adding refresh_credentials_if_expired to IAM#request. thanks Joshua Garnett
+*   Adding support for AWS IAM ListMFADevices API. thanks Joshua Garnett
+*   Adding a unit test for list_mfa_devices.  Also, fixed parsing of EnableData to use Time.parse. thanks Joshua Garnett
+*   Adding support for udplimit paramater in rage4 api. thanks Joshua Gross
+*   making tests ruby 1.8.7 friendly. thanks Joshua Gross
+*   Fix issue #2796 (AWS describe_dhcp_options request parsing). thanks Konstantinos Natsakis
+*   Correctly index SecurityGroupId parameter when it is inside a NetworkInterfaces hash. thanks Kunal Thakar
+*   rebasing with master. thanks Kyle Rames
+*   adding github_release dependency to edge gemfile. thanks Kyle Rames
+*   Fix syntax errors in an OpenStack example script. thanks Larry Gilbert
+*   The server password (adminPass) should can be set during server creation. thanks Max Lincoln
+*   The password attribute doesn't like the use of @password. thanks Max Lincoln
+*   info is now called json. thanks Michael Sprauer
+*   fixed examples for HPC access. thanks Mike Hagedorn
+*   Fix build broken by 96a56b954eec6c2e93e0b9f696bed08c8414d1d7. thanks Nat Welch
+*   Fix Disk tests. thanks Nat Welch
+*   Lists disks isn't a valid test since response varies greatly by disk. thanks Nat Welch
+*   Removed unicode NFC normalization of S3 object keys. thanks Nathan Sutton
+*   Lock rake to 10.1 for Ruby 1.8.7. thanks Paul Thornthwaite
+*   Move 1.8.7's Gemfile for subdirectory. thanks Paul Thornthwaite
+*   Fix reference to fog's gemspec. thanks Paul Thornthwaite
+*   Test the latest edge version of fog and parts. thanks Paul Thornthwaite
+*   Switch testing to MiniTest::Spec. thanks Paul Thornthwaite
+*   Remove deprecated `host` Excon option from dynamodb. thanks Pedro Belo
+*   . fix ruby-libvirt library require name (libvirt). thanks Reda NOUSHI
+*   Add the ability to pass an options Hash to DataPipeline#describe_objects. thanks Tom Hulihan
+*   fix documentation of unmounting volumes. thanks Toni Stjepanovic
+*   Allow v2 authentication url with trailing slash. thanks nis Simo
+*   ISSUE-2824 Adding user_data to rackspace provider. thanks Yann Hamon
+
+#### [openstack|network]
+*   updated create_router and update_router use symbol based keys instead of string; removed dead code; this should address #2799. thanks Kyle Rames
+*   fixing broken tests. thanks Kyle Rames
+*   fixing broken tests; added deprecation warning about removing support for passing model objects into the request layer. thanks Kyle Rames
+*   taking another shot at repairing a broken test. thanks Kyle Rames
+
+#### [openstack|networking]
+*   fixing tests. thanks Kyle Rames
+
+#### [vcloud_director]
+*   fix progress reporting of tasks without progress. thanks Dan Abel
+
+#### [vsphere]
+*   check for string true/false instead of boolean. thanks geemus
+
+
 ## 1.21.0 03/18/2014
 *Hash* c9dfbd5b4d3687b5c809f6617ba9a5454a2a9c49
 

CONTRIBUTORS.md

@@ -1,5 +1,6 @@
 * Aaron Bell <aarontbell@gmail.com>
 * Aaron Suggs <aaron@ktheory.com>
+* Abhishek Chanda <abhishek.becs@gmail.com>
 * Adam Bozanich <adam.boz@gmail.com>
 * Adam Greene <adam@sweetspotdiabetes.com>
 * Adam Heinz <amh@metricwise.net>
@@ -63,6 +64,7 @@
 * Arthur Gunawan <acgun3@gmail.com>
 * Arvid Andersson <arvid@winstondesign.se>
 * Ash Wilson <ash.wilson@rackspace.com>
+* Ash Wilson <smashwilson@gmail.com>
 * Athir Nuaimi <anuaimi@devfoundry.com>
 * Avrohom Katz <iambpentameter@gmail.com>
 * BK Box <bk@theboxes.org>
@@ -74,6 +76,7 @@
 * Ben Hundley <ben.hundley@gmail.com>
 * Ben Turley <ben@scan.me>
 * Benjamin Manns <benmanns@gmail.com>
+* Benson Kalahar <bensonk42@gmail.com>
 * Benton Roberts <benton@bentonroberts.com>
 * Benton Roberts <broberts@mdsol.com>
 * Blake Gentry <blakesgentry@gmail.com>
@@ -88,6 +91,7 @@
 * Bradley Schaefer <bradley.schaefer@gmail.com>
 * Brandon Dunne <bdunne@redhat.com>
 * Brendan Fosberry <brendan.fosberry@rackspace.com>
+* Brett Porter <brett@apache.org>
 * Brian D. Burns <iosctr@gmail.com>
 * Brian Dorry <bdorry@Brian-Dorrys-MacBook-Pro.local>
 * Brian Hartsock <brian.hartsock@gmail.com>
@@ -102,6 +106,7 @@
 * Carl Allen <callen@book.com>
 * Carl Caum <carl@carlcaum.com>
 * Carl Hicks <carl.hicks@gmail.com>
+* Carl Loa Odin <carl.loa.odin@klarna.com>
 * Carl Woodward <carl@88cartell.com>
 * Carl Woodward <carl@Carls-MacBook-Pro.local>
 * Carlos Sanchez <csanchez@maestrodev.com>
@@ -117,10 +122,12 @@
 * Chris Frederick <chris@maginatics.com>
 * Chris Hasenpflug <github@chris.hasenpflug.us>
 * Chris Howe <howech@infochimps.com>
+* Chris Kershaw <ckershaw@6fusion.com>
 * Chris Mague <github@mague.com>
 * Chris Roberts <chrisroberts.code@gmail.com>
 * Chris Wuest <chris.wuest@rackspace.com>
 * Chris Wuest <chris@chriswuest.com>
+* Christian Berendt <berendt@b1-systems.de>
 * Christian Paredes <cp@redbluemagenta.com>
 * Christoph Schiessl <chs@proactive.cc>
 * Christoph Witzany <christoph@web.crofting.com>
@@ -128,6 +135,7 @@
 * Christopher Meiklejohn <christopher.meiklejohn@gmail.com>
 * Christopher Oliver <coliver@coliverlaptop.(none)>
 * Christopher Oliver <coliver@datapipe.com>
+* Christopher Snell <chris.snell@gmail.com>
 * Claudio Poli <masterkain@gmail.com>
 * Coby Randquist <randquistcp@gmail.com>
 * Cody Herriges <c.a.herriges@gmail.com>
@@ -186,11 +194,13 @@
 * Eric Hankins <ehankins@rednovalabs.com>
 * Eric Herot <eric.github@herot.com>
 * Eric Hodel <drbrain@segment7.net>
+* Eric Johnson <erjohnso@google.com>
 * Eric Lindvall <eric@5stops.com>
 * Eric Stonfer <ericstonfer@yahoo.com>
 * Eric Stonfer <estonfer@gmail.com>
 * Eric Stonfer <estonfer_ldap@ccppup-ae-a001-p.ae.ccp.cable.comcast.com>
 * Eric Wong <ericsyw@gmail.com>
+* Erik Mackdanz <erik@infochimps.com>
 * Erik Michaels-Ober <sferik@gmail.com>
 * Erik Terpstra <erterpstra@gmail.com>
 * Eugene Howe & Josh Lane <ehowe@engineyard.com>
@@ -221,6 +231,7 @@
 * Glenn Tweedie <glenn.tweedie@agworld.com.au>
 * Greg Blomquist <gblomqui@redhat.com>
 * Greg Sutcliffe <greg.Sutcliffe@gmail.com>
+* Greg Sutcliffe <gsutclif@redhat.com>
 * Grégory Karékinian <greg@karekinian.com>
 * Grzesiek Kolodziejczyk <gkolodziejczyk@gmail.com>
 * Gustavo Villalta <gvillalta99@gmail.com>
@@ -254,6 +265,7 @@
 * James Stremick <james.stremick@gmail.com>
 * James W. Brinkerhoff <jwb@paravolve.net>
 * Jamie H <jamie@limetree.org>
+* Jamie Paton <jamiep@activestate.com>
 * Jason Faulkner <jay@jvf.cc>
 * Jason Hansen & Josh Lane <jhansen@engineyard.com>
 * Jason Montleon <jmontleo@redhat.com>
@@ -262,6 +274,7 @@
 * Jay Faulkner <jay.faulkner@rackspace.com>
 * Jay Perry <jperry@brightcove.com>
 * Jeff McCune <jeff@puppetlabs.com>
+* Jeffrey C. Ollie <jeff@ocjtech.us>
 * Jens Braeuer <jens@numberfour.eu>
 * Jeremy Deininger <jeremy@rightscale.com>
 * Jesse Davis <jdavis@vcharge-energy.com>
@@ -269,6 +282,7 @@
 * Jesse Proudman <jesse.proudman@blueboxgrp.com>
 * Jesse Proudman <jproudman@nova.(none)>
 * Jesse Scott <jesse.c.scott@gmail.com>
+* Jim Berlage <jberlage@mdsol.com>
 * Jim Salinas <jim.salinas@rackspace.com>
 * Joachim Nolten <joachim@viewbook.com>
 * Joe Kinsella <joe.kinsella@gmail.com>
@@ -304,11 +318,13 @@
 * Josh Kearney <josh@jk0.org>
 * Josh Lane & Ines Sombra <jlane@engineyard.com>
 * Josh Lane & Jason Hansen <jlane@engineyard.com>
+* Josh Lane & Thom Mahoney <jlane@engineyard.com>
 * Josh Lane <jlane@engineyard.com>
 * Josh Lane <lane.joshlane@gmail.com>
 * Josh Lane <me@joshualane.com>
 * Josh Pasqualetto <josh.pasqualetto@sonian.net>
 * Josh Yotty <jyotty@bluebox.net>
+* Joshua Garnett <josh@kixeye.com>
 * Joshua Gross <joshua@surfeasy.com>
 * Joshua Krall <joshuakrall@pobox.com>
 * Joshua Napoli <jnapoli@swipely-napoli.home>
@@ -336,14 +352,18 @@
 * Kevin McFadden <kmcfadden@gmail.com>
 * Kevin Menard <nirvdrum@gmail.com>
 * Kevin Moore <kevin@thinkpixellab.com>
+* Kevin Olbrich <kolbrich@6fusion.com>
 * Konstantin Haase <konstantin.mailinglists@googlemail.com>
+* Konstantinos Natsakis <k.natsakis@xe.gr>
 * Kunal Parikh <kunal@techthumb.in>
+* Kunal Thakar <kthakar@twilio.com>
 * Kyla Kolb <kkolb@mitre.org>
 * Kyle Drake <kyledrake@gmail.com>
 * Kyle Rames <kyle.rames@rackspace.com>
 * Kyle Rames <kyle@rames.org>
 * Lance Carlson <lancecarlson@gmail.com>
 * Lance Ivy <lance@cainlevy.net>
+* Larry Gilbert <larry@l2g.to>
 * Larry Wright <larrywright@gmail.com>
 * Lars Pind <lars@pinds.com>
 * Laurent Bigonville <bigon@bigon.be>
@@ -374,6 +394,7 @@
 * Mark Phillips <mark.phillips2@bskyb.com>
 * Mark Rushakoff <mark.rushakoff@gmail.com>
 * Mark Turner <mark@amerine.net>
+* Markus Schwed <maschwed@anynines.com>
 * Marshall Yount <marshall@yountlabs.com>
 * Martin Emde <martin.emde@gmail.com>
 * Martin Englund <martin@englund.nu>
@@ -408,6 +429,7 @@
 * Michael Keirnan <mgk@noteflight.com>
 * Michael Linderman <mlinderm@stanford.edu>
 * Michael Rykov <mrykov@gmail.com>
+* Michael Sprauer <Sprauer@Inline.de>
 * Michael Zeng <michaelzeng@swipely.com>
 * Michał Krzyżanowski <michal.krzyzanowski+github@gmail.com>
 * Michiel Sikkes <michiel.sikkes@gmail.com>
@@ -416,6 +438,7 @@
 * Mike Gehard <mgehard@pivotallabs.com>
 * Mike Hagedorn <mike@silverchairsolutions.com>
 * Mike Manewitz <mike.manewitz@gmail.com>
+* Mike Marion <mike.marion@gmail.com>
 * Mike Moore <mike@blowmage.com>
 * Mike Pountney <Mike.Pountney@gmail.com>
 * Ming Jin <skyairmj@gmail.com>
@@ -463,6 +486,7 @@
 * Paul Vudmaska <Paul.Vudmaska@Rackspace.com>
 * Paulo Henrique Lopes Ribeiro <plribeiro3000@gmail.com>
 * Pavel Repin <prepin@gmail.com>
+* Pedro Belo <pedro@heroku.com>
 * Pedro Nascimento <pnascimento@gmail.com>
 * Pedro Perez <pedro@bvox.net>
 * Peter Bonnell <peter@circuitllc.com>
@@ -488,6 +512,7 @@
 * Pratik Naik <pratiknaik@gmail.com>
 * Rad Gruchalski <radek@gruchalski.com>
 * Raphael Costa <raphael@raphaelcosta.net>
+* Reda NOUSHI <reda_noushi@yahoo.com>
 * Reinaldo Junior <juniorz@gmail.com>
 * Rich Lane <rlane@club.cc.cmu.edu>
 * Rick Bradley <rick@rickbradley.com>
@@ -502,6 +527,7 @@
 * Ruben Koster <ruben.koster@innovationfactory.eu>
 * Rupak Ganguly <rupakg@gmail.com>
 * Rusty Geldmacher <rgeldmacher@sermo.com>
+* Ryan Davies <ryan@ryandavies.co.nz>
 * Ryan Richard <ryanrichard07@gmail.com>
 * Ryan Stout <ryanstout@gmail.com>
 * Sairam <sairam@kunala.com>
@@ -514,6 +540,7 @@
 * Samuel Merritt <spam@andcheese.org>
 * Sarah Vessels <sarah.vessels@cirrusmio.com>
 * Sascha Korth <sascha.korth@zweitag.de>
+* Scott Carleton <scott@artsicle.com>
 * Scott Gonyea <me@aitrus.org>
 * Sean Caffery <sean.caffery@c3businesssolutions.com>
 * Sean Handley <sean.handley@gmail.com>
@@ -573,16 +600,19 @@
 * Toby Hede <tobyhede@info-architects.net>
 * Todd Willey <todd@rubidine.com>
 * Todd Willey <xtoddx@gmail.com>
+* Tom Hulihan <hulihan.tom159@gmail.com>
 * Tom Mornini <tmornini@engineyard.com>
 * Tom Stuart <tom@experthuman.com>
 * Tomasz Bak <tomasz.bak@nsn.com>
 * Tomokazu Hirai <tomokazu.hirai@kddi-web.com>
+* Toni Stjepanovic <toni.stjepanovic@gmail.com>
 * Topper Bowers <topper@toppingdesign.com>
 * Tor-Ake Fransson <torakef@gmail.com>
 * Trae Robrock <trobrock@gmail.com>
 * Trevor Bramble <inbox@trevorbramble.com>
 * Trevor Bramble <tbramble@bluebox.net>
 * Trotter Cashion <cashion@gmail.com>
+* Tõnis Simo <anton.estum@gmail.com>
 * Ulf Mansson <ulf.mansson@recordedfuture.com>
 * Vadim Spivak <vspivak@vmware.com>
 * Viktor Petersson <vpetersson@wireload.net>
@@ -603,6 +633,7 @@
 * William Lawson <lawson.bj@gmail.com>
 * Wyatt Walter <wyattwalter@gmail.com>
 * Xavier Fontrodona <xavier.fontrodona@safelayer.com>
+* Yann Hamon <Yann@trailburning.com>
 * Yauheni Kryudziuk <yauheni.kryudziuk@xing.com>
 * Your Name <seanhart@funzio.com>
 * Zachary Danger Campbell <zacharydangercampbell@gmail.com>
@@ -612,6 +643,7 @@
 * Zuhaib M Siddique <zuhaib@hipchat.com>
 * Zuhaib Siddique <zuhaib.siddique@leapfile.com>
 * aabes <a_abes@yahoo.com>
+* abenari <abenari@redhat.com>
 * alex <alex@alex-HP-ProBook-4510s.(none)>
 * althras <althras@gmail.com>
 * angus <ags@sdx.com.au>
@@ -627,6 +659,7 @@
 * bonkydog <bonkydog@bonkydog.com>
 * brookemckim <brooke.mckim@gmail.com>
 * bugagazavr <kirik910@gmail.com>
+* caryp <cary@rightscale.com>
 * ccloes <chad_cloes@intuit.com>
 * coliver <coliver@datapipe.com>
 * crazed <cr4z3d@gmail.com>
@@ -656,6 +689,7 @@
 * jc00ke <jesse@jc00ke.com>
 * jimworm <jimworm@gmail.com>
 * joe <jmorgan@rednovalabs.com>
+* joe morgan <jmorgan@rednovalabs.com>
 * joewilliams <joe@der-dieb.local>
 * jordangbull <jordangbull@gmail.com>
 * jschneiderhan <jon-erik.schneiderhan@meyouhealth.com>
@@ -663,6 +697,7 @@
 * kbockmanrs <kevin@rightscale.com>
 * kfafel <keith.fafel@gmail.com>
 * leehuffman <lhuffman@bluebox.net>
+* leonidlm <leonidlm@gmail.com>
 * lostboy <paul.crabtree@gmail.com>
 * marios <marios@marios.(none)>
 * marios <marios@redhat.com>
@@ -677,10 +712,12 @@
 * phillc <spyyderz@gmail.com>
 * questionnet <zacccp@mail.ru>
 * radekg <radek@gruchalski.com>
+* rebelagentm <rebelagentm@yahoo.com>
 * ronen barzel <ronen@barzel.org>
 * rsalm <rs@iki.fi>
 * ryanlower <rpjlower@gmail.com>
 * sashap <sasha@mythictechnologies.com>
+* sawanoboly <sawanoboriyu@higanworks.com>
 * seanhandley <seanhandley@hackmanchester.com>
 * seeingidog <ian@ruby-code.com>
 * thattommyhall <thattommyhall@gmail.com>

fog.gemspec

@@ -6,8 +6,8 @@ Gem::Specification.new do |s|
   ## If your rubyforge_project name is different, then edit it and comment out
   ## the sub! line in the Rakefile
   s.name              = 'fog'
-  s.version           = '1.21.0'
+  s.version           = '1.22.0'
-  s.date              = '2014-03-18'
+  s.date              = '2014-04-17'
   s.rubyforge_project = 'fog'
 
   ## Make sure your summary is short. The description may be as long

lib/fog/version.rb

@@ -1,3 +1,3 @@
 module Fog
-  VERSION = '1.21.0'
+  VERSION = '1.22.0'
 end

lib/tasks/changelog_task.rb

@@ -102,10 +102,11 @@ Watchers      | #{watchers}
         committer_pairs.collect {|pair| pair.first }
       end
 
-      def mvp_eligible?(committer)
+      def former_mvp?(committer)
          [
            'Aaron Suggs',
            'Ash Wilson',
+           'Benson Kalahar',
            'Brian Hartsock',
            'Chris Roberts',
            'Christopher Oliver',
@@ -139,7 +140,7 @@ Watchers      | #{watchers}
       def mvp
         return @mvp if @mvp
         committers_sorted_by_commits.each do |committer|
-          if mvp_eligible?(committer)
+          unless former_mvp?(committer)
             @mvp = committer
             return @mvp
           end