kotovalexarian-likes-github/fog--fog
1
0
Fork 0
mirror of https://github.com/fog/fog.git synced 2022-11-09 13:51:43 -05:00
Code Releases Activity

Make the delete_message mock consistent.

Browse source 
The real API currently silently fails `delete_message` requests if the
claim_id is incorrect. Make the mock API do the same thing, for consistency.
This commit is contained in:
Ash Wilson 2014-01-20 17:49:44 -05:00
parent 304cacd174
commit 8997b18fcc
2 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
lib/fog/rackspace/queues.rb
View file

@ -208,6 +208,7 @@ module Fog
# plus the claim's grace period.
def extend_life
return unless @claim
# FIXME: make sure this is an *increase*
@ttl = claim.message_end_of_life - @created
end

13
lib/fog/rackspace/requests/queues/delete_message.rb
View file

@ -38,17 +38,22 @@ module Fog
message = queue.messages.detect { |m| m.id == message_id }
perform_delete = true
if message && message.claimed?
unless message.claim.id == claim_id
# FIXME Exception
# Currently returns a 204 without deleting!
perform_delete = false
end
else
unless claim_id
# Currently succeeds.
if claim_id
# Currently returns a 204 without deleting!
perform_delete = false
end
end
queue.messages.reject! { |m| m.id == message_id }
if perform_delete
queue.messages.reject! { |m| m.id == message_id }
end
response = Excon::Response.new
response.status = 204