kotovalexarian-likes-github/fog--fog
1
0
Fork 0
mirror of https://github.com/fog/fog.git synced 2022-11-09 13:51:43 -05:00
Code Releases Activity

[openstack|network] Added missing Network model attributes

Browse source 
The following patch adds the following missing attributes:

+---------------------------+--------------------------------------+
| Field                     | Value                                |
+---------------------------+--------------------------------------+
| provider:network_type     | gre                                  |
| provider:physical_network |                                      |
| provider:segmentation_id  | 1                                    |
| router:external           | False                                |
+---------------------------+--------------------------------------+

Not sure if the code style I've used for the attributes is OK though,
I did it so I don't break the 80 col. barrier.

Added also a small test for the new and existing attributes.
This commit is contained in:
Sergio Rubio 2013-02-21 12:32:43 +01:00
parent fc3df16a4d
commit 8a47ca26c4
2 changed files with 29 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lib/fog/openstack/models/network/network.rb
View file

@ -12,6 +12,14 @@ module Fog
attribute :status
attribute :admin_state_up
attribute :tenant_id
attribute :provider_network_type,
:aliases => 'provider:network_type'
attribute :provider_physical_network,
:aliases => 'provider:physical_network'
attribute :provider_segmentation_id,
:aliases => 'provider:segmentation_id'
attribute :router_external,
:aliases => 'router:external'
def initialize(attributes)
# Old 'connection' is renamed as service and should be used instead

22
tests/openstack/models/network/network_tests.rb
View file

@ -1,7 +1,7 @@
Shindo.tests("Fog::Network[:openstack] | network", ['openstack']) do
tests('success') do
tests('#create').succeeds do
@instance = Fog::Network[:openstack].networks.create(:name => 'net_name',
:shared => false,
@ -9,6 +9,26 @@ Shindo.tests("Fog::Network[:openstack] | network", ['openstack']) do
:tenant_id => 'tenant_id')
!@instance.id.nil?
end
tests('have attributes') do
attributes = [
:name,
:subnets,
:shared,
:status,
:admin_state_up,
:tenant_id,
:provider_network_type,
:provider_physical_network,
:provider_segmentation_id,
:router_external
]
tests("The network model should respond to") do
attributes.each do |attribute|
test("#{attribute}") { @instance.respond_to? attribute }
end
end
end
tests('#update').succeeds do
@instance.name = 'new_net_name'