From 9f909e61dc42550a6248db5ccc38b220e7491668 Mon Sep 17 00:00:00 2001 From: Frederick Cheung <frederick.cheung@gmail.com> Date: Sun, 2 Sep 2012 13:43:29 +0100 Subject: [PATCH] [HP] delete_if returns the array, not what was deleted --- lib/fog/hp/requests/compute/delete_security_group_rule.rb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/fog/hp/requests/compute/delete_security_group_rule.rb b/lib/fog/hp/requests/compute/delete_security_group_rule.rb index af74d6f1d..ddd4e77c3 100644 --- a/lib/fog/hp/requests/compute/delete_security_group_rule.rb +++ b/lib/fog/hp/requests/compute/delete_security_group_rule.rb @@ -25,14 +25,14 @@ module Fog response = Excon::Response.new sg_rule = nil - self.data[:security_groups].each do |_, sgv| if sgv['rules'] - sg_rule = sgv['rules'].delete_if { |r| !r.nil? && r['id'] == security_group_rule_id } - break if sg_rule + sg_rule_index = sgv['rules'].find_index { |r| !r.nil? && r['id'] == security_group_rule_id } + if sg_rule_index + sg_rule = sgv['rules'].delete_at sg_rule_index + end end end - if sg_rule && !sg_rule.empty? response.status = 202 response.body = "202 Accepted\n\nThe request is accepted for processing.\n\n "