kotovalexarian-likes-github/fog--fog
1
0
Fork 0
mirror of https://github.com/fog/fog.git synced 2022-11-09 13:51:43 -05:00
Code Releases Activity

Hash#reject! returns nil if no changes were made; it is not correct behavior in assignment

Browse source
This commit is contained in:
Jaroslav Barton 2015-04-09 08:52:55 -07:00
parent defb13116c
commit ba90610c5a
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/fog/xenserver/requests/compute/create_server.rb
View file

@ -85,7 +85,7 @@ module Fog
def create_server( name_label, template = nil, networks = [], extra_args = {})
if name_label.is_a?(Hash)
config = name_label.reject! { |_k,v| v.nil? }
config = name_label.reject { |_k,v| v.nil? }
ref = @connection.request({:parser => Fog::Parsers::XenServer::Base.new, :method => 'VM.create' }, config)
else
Fog::Logger.deprecation(

2
lib/fog/xenserver/requests/compute/create_vbd.rb
View file

@ -4,7 +4,7 @@ module Fog
class Real
def create_vbd( vm_ref, vdi_ref = '', config = {} )
if vm_ref.is_a?(Hash)
default_config = vm_ref.reject! { |_k,v| v.nil? }
default_config = vm_ref.reject { |_k,v| v.nil? }
else
Fog::Logger.deprecation(
'This api is deprecated. The only expected param is a hash of attributes.'

2
lib/fog/xenserver/requests/compute/create_vif.rb
View file

@ -6,7 +6,7 @@ module Fog
raise ArgumentError.new('Invalid vm_ref') if vm_ref.nil?
raise ArgumentError.new('Invalid network_ref') if network_ref.nil?
if vm_ref.is_a?(Hash)
vif_config = vm_ref.reject! { |_k,v| v.nil? }
vif_config = vm_ref.reject { |_k,v| v.nil? }
else
vm_ref = vm_ref.reference if vm_ref.kind_of? Fog::Model
network_ref = network_ref.reference if network_ref.kind_of? Fog::Model