[openstack|image] Refactor Dynamic Methods on Image Model

-removed method missing, added location attr for image upload

lib/fog/openstack/models/image/image.rb

@@ -27,11 +27,11 @@ module Fog
         attribute :min_ram
         attribute :owner
         attribute :properties
+        attribute :location
 
 
         def initialize(attributes)
           @connection = attributes[:connection]
-          attributes[:size] ||= 0
           super
         end
 

lib/fog/openstack/models/image/images.rb

@@ -42,6 +42,18 @@ module Fog
           end
         end
 
+        def find_by_size_min(size)
+          find_attribute(__method__, size)
+        end
+
+        def find_by_size_max(size)
+          find_attribute(__method__, size)
+        end
+
+        def find_attribute(attribute,value)
+          attribute = attribute.to_s.gsub("find_by_", "")
+          load(connection.list_public_images_detailed(attribute , value).body['images'])
+        end
       end
     end
   end

lib/fog/openstack/requests/image/create_image.rb

@@ -7,6 +7,7 @@ module Fog
 
 
           data = {
+              "Content-Type"=>"application/octet-stream",
               "x-image-meta-name" => attributes[:name],
               "x-image-meta-disk-format" => attributes[:disk_format],
               "x-image-meta-container-format" => attributes[:container_format],
@@ -15,6 +16,12 @@ module Fog
               "x-image-meta-owner" => attributes[:owner]
           }
 
+          body = String.new
+          if attributes[:location]
+            file = File.open(attributes[:location], "rb")
+            body = file.read
+          end
+
           unless attributes[:properties].nil?
             attributes[:properties].each do |key,value|
               data["x-image-meta-property-#{key}"] = value
@@ -25,6 +32,7 @@ module Fog
 
           request(
             :headers     => data,
+            :body     => body,
             :expects  => 201,
             :method   => 'POST',
             :path     => "images"

lib/fog/openstack/requests/image/list_public_images_detailed.rb

@@ -5,7 +5,7 @@ module Fog
         def list_public_images_detailed(attribute=nil, query=nil)
 
           if attribute
-            path = "images/detail?#{attribute}=#{query}"
+            path = "images/detail?#{attribute}=#{URI::encode(query)}"
           else
             path = 'images/detail'
           end

tests/openstack/requests/image/image_tests.rb

@@ -3,7 +3,7 @@ Shindo.tests('Fog::Image[:openstack] | image requests', ['openstack']) do
   @image_format = {
     'id' => String,
     'name' => String,
-    'size' => Integer,
+    'size' => Fog::Nullable::Integer,
     'disk_format' => Fog::Nullable::String,
     'container_format' => Fog::Nullable::String,
     'checksum' => Fog::Nullable::String,