[opennebula] added groups.get and groups.get_by_name filters

lib/fog/opennebula/models/compute/groups.rb

@@ -14,10 +14,17 @@ module Fog
         end
 
         def get(id)
-          # the one api does not provide any filter method and this isn't really important
-          # get all and filter on your own :D
-          #self.all({:id => id}).first
-          raise Fog::Errors::Error.new('get a group is not yet implemented. Contributions welcome!')
+          group = self.all({:id => id})
+          
+          if group.length > 1
+            raise Fog::Errors::Error.new("groups.get should return only one group, not #{group.length}!")
+          end
+
+          group.first
+        end
+
+        def get_by_name(str)
+          self.all({:name => str})
         end
 
       end

lib/fog/opennebula/requests/compute/list_groups.rb

@@ -2,32 +2,40 @@ module Fog
   module Compute
     class OpenNebula
       class Real
-        def list_groups(filter = { })
+        def list_groups(filter = {})
 
           groups=[]
           grouppool = ::OpenNebula::GroupPool.new(client)
-	  grouppool.info
- 
-	  # {
-	  #   "GROUP"=>{
-	  #     "ID"=>"0", 
-	  #      "NAME"=>"oneadmin", 
-	  #      "USERS"=>{"ID"=>["0", "1"]}, 
-	  #      "DATASTORE_QUOTA"=>{}, 
-	  #      "NETWORK_QUOTA"=>{}, 
-	  #      "VM_QUOTA"=>{}, 
-	  #      "IMAGE_QUOTA"=>{}
+          grouppool.info
+
+          # {
+          #   "GROUP"=>{
+          #     "ID"=>"0", 
+          #      "NAME"=>"oneadmin", 
+          #      "USERS"=>{"ID"=>["0", "1"]}, 
+          #      "DATASTORE_QUOTA"=>{}, 
+          #      "NETWORK_QUOTA"=>{}, 
+          #      "VM_QUOTA"=>{}, 
+          #      "IMAGE_QUOTA"=>{}
           #    }
-	  #}
+          #}
+
           grouppool.each do |group| 
-	    puts "GROUP #{group.to_hash.display}"
-	    groups << {:id => group["ID"], :name => group["NAME"]}
-	  end
-	  puts "GROUPS #{groups.inspect}"
+            filter_missmatch = false
+
+            unless (filter.empty?)
+              filter.each do |k,v|
+                if group["#{k.to_s.upcase}"] && group["#{k.to_s.upcase}"] != v.to_s
+                  filter_missmatch = true
+                  break
+                end
+              end 
+              next if filter_missmatch
+            end 
+            groups << {:id => group["ID"], :name => group["NAME"]}
+          end
           groups
         end
-
-
       end
 
       class Mock