From 3a6870ee0f5134d56d8c9a948a3ae515c669d368 Mon Sep 17 00:00:00 2001
From: Takashi Kokubun <takashi-kokubun@cookpad.com>
Date: Mon, 23 Nov 2015 18:10:14 +0900
Subject: [PATCH] Optimize string nterpolation in attributes

---
 benchmark/string_interpolation.haml       |  2 ++
 lib/hamlit/compiler/attribute_compiler.rb | 29 +++++++++++++++++------
 test/haml/engine_test.rb                  |  2 +-
 3 files changed, 25 insertions(+), 8 deletions(-)
 create mode 100644 benchmark/string_interpolation.haml

diff --git a/benchmark/string_interpolation.haml b/benchmark/string_interpolation.haml
new file mode 100644
index 00000000..6ccfe11d
--- /dev/null
+++ b/benchmark/string_interpolation.haml
@@ -0,0 +1,2 @@
+- id = 12347
+%a{ href: "https://example.com/users/#{id}" }= "id: #{id}"
diff --git a/lib/hamlit/compiler/attribute_compiler.rb b/lib/hamlit/compiler/attribute_compiler.rb
index 4b9b1956..652c7114 100644
--- a/lib/hamlit/compiler/attribute_compiler.rb
+++ b/lib/hamlit/compiler/attribute_compiler.rb
@@ -1,6 +1,8 @@
 require 'hamlit/attribute_builder'
 require 'hamlit/hash_parser'
+require 'hamlit/ruby_expression'
 require 'hamlit/static_analyzer'
+require 'hamlit/string_interpolation'
 
 module Hamlit
   class Compiler
@@ -109,14 +111,27 @@ module Hamlit
       def compile_common!(temple, key, values)
         type, exp = values.last
 
-        if type == :dynamic && StaticAnalyzer.static?(exp)
-          type, exp = :static, eval("(#{exp}).to_s")
+        case
+        when type == :dynamic && StaticAnalyzer.static?(exp)
+          temple << [:html, :attr, key, [:escape, @escape_attrs, [:static, eval(exp).to_s]]]
+        when type == :dynamic && RubyExpression.string_literal?(exp)
+          value_temple = [:multi]
+          StringInterpolation.compile(exp).each do |type, v|
+            case type
+            when :static
+              value_temple << [:escape, @escape_attrs, [:static, v]]
+            when :dynamic
+              if Hamlit::StaticAnalyzer.static?(v)
+                value_temple << [:escape, @escape_attrs, [:static, eval(v).to_s]]
+              else
+                value_temple << [:escape, @escape_attrs, [:dynamic, v]]
+              end
+            end
+          end
+          temple << [:html, :attr, key, value_temple]
+        else
+          temple << [:html, :attr, key, [:escape, @escape_attrs, [type, exp]]]
         end
-        temple << build_attr(key, type, exp)
-      end
-
-      def build_attr(key, type, exp)
-        [:html, :attr, key, [:escape, @escape_attrs, [type, exp]]]
       end
 
       def attribute_builder(type, values)
diff --git a/test/haml/engine_test.rb b/test/haml/engine_test.rb
index e5526e29..474d66ae 100644
--- a/test/haml/engine_test.rb
+++ b/test/haml/engine_test.rb
@@ -1469,7 +1469,7 @@ HAML
     assert_equal("<a></a>\n", render('%a{:b => "a #{1 + 1} b", :c => "d"}', :suppress_eval => true))
   end
 
-  def test_interpolates_instance_vars_in_attribute_values
+  def test_interpolates_instance_vars_in_attribute_values; skip # special interpolation
     scope = Object.new
     scope.instance_variable_set :@foo, 'bar'
     assert_haml_ugly('%a{:b => "a #@foo b"}', :scope => scope)