kotovalexarian-likes-github/haml--haml
1
0
Fork 0
mirror of https://github.com/haml/haml.git synced 2022-11-09 12:33:31 -05:00
Code Releases Activity

Add test and comment for group_values_for_sort

Browse source
This commit is contained in:
Takashi Kokubun 2017-07-30 15:26:33 +09:00
parent ce522bdacd
commit 923a0d7887
2 changed files with 32 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
lib/haml/attribute_compiler.rb
View file

@ -64,6 +64,7 @@ module Haml
private
# Build array of grouped values whose sort order may go back and forth, which is also sorted with key name.
# This method needs to group values with the same start because it can be changed in `Haml::AttributeBuidler#build_data_keys`.
# @param values [Array<Haml::AttributeCompiler::AttributeValue>]
# @return [Array<Array<Haml::AttributeCompiler::AttributeValue>>]
def group_values_for_sort(values)

40
test/engine_test.rb
View file

@ -1757,23 +1757,45 @@ HAML
def test_attributes_sort_order
# "," < "-" < "0" < "=" < "a"
assert_equal(<<-HTML, render(<<-HAML))
<div a,='1' a-='1' a0='1' a='1' aa='1'></div>
<div a,='1' a-='1' a0='1' a='1' aa='1'></div>
<div a,='1' a-='2' a0='3' a='4' aa='5'></div>
<div a,='1' a-='2' a0='3' a='4' aa='5'></div>
HTML
- a = 1
%div{ a: a, 'a-' => 1, aa: 1, a0: 1, 'a,' => 1 }
- hash = { a: a, 'a-' => 1, aa: 1, a0: 1, 'a,' => 1 }
- a = 4
%div{ a: a, 'a-' => 2, aa: 5, a0: 3, 'a,' => 1 }
- hash = { a: a, 'a-' => 2, aa: 5, a0: 3, 'a,' => 1 }
%div{ hash }
HAML
# (no char) < "," < "-" < "0" < "a"
assert_equal(<<-HTML, render(<<-HAML))
<div a a,='1' a-='1' a0='1' aa='1'></div>
<div a a,='1' a-='1' a0='1' aa='1'></div>
<div a a,='1' a-='2' a0='3' aa='4'></div>
<div a a,='1' a-='2' a0='3' aa='4'></div>
HTML
- a = true
%div{ a: a, 'a-' => 1, aa: 1, a0: 1, 'a,' => 1 }
- hash = { a: a, 'a-' => 1, aa: 1, a0: 1, 'a,' => 1 }
%div{ a: a, 'a-' => 2, aa: 4, a0: 3, 'a,' => 1 }
- hash = { a: a, 'a-' => 2, aa: 4, a0: 3, 'a,' => 1 }
%div{ hash }
HAML
# "," < "-" < "0" (with hyphenation)
assert_equal(<<-HTML, render(<<-HAML))
<div a,='1' a-a='2' a0='3'></div>
<div a,='1' a-a='2' a0='3'></div>
HTML
- a = { a: 2 }
%div{ a: a, a0: 3, 'a,' => 1 }
- hash = { a: a, a0: 3, 'a,' => 1 }
%div{ hash }
HAML
# "A" < "_" < "a" (with underscoration)
assert_equal(<<-HTML, render(<<-HAML, hyphenate_data_attrs: false))
<div a-aA='1' a-a_a='2' a-aa='3'></div>
<div a-aA='1' a-a_a='2' a-aa='3'></div>
HTML
- a = { a: { a: 2 } }
%div{ a: a, 'a-aa' => 3, 'a-aA' => 1 }
- hash = { a: a, 'a-aa' => 3, 'a-aA' => 1 }
%div{ hash }
HAML
end