kotovalexarian-likes-github/haml--haml
1
0
Fork 0
mirror of https://github.com/haml/haml.git synced 2022-11-09 12:33:31 -05:00
Code Releases Activity

Significantly optimize regexp time of fix_textareas!

Browse source 
The leading whitespace match and back reference added significant overhead in
certain cases, sometimes leading to render times taking minutes. In some cases,
the render time dropped from 2+ minutes to 200 milliseconds.

Closes #849
This commit is contained in:
Stan Hu 2015-07-16 09:12:24 -07:00 • committed by Norman Clarke
parent c89da381a0
commit bc2b9f186f
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lib/haml/buffer.rb
View file

@ -273,16 +273,16 @@ module Haml
# @since Haml 4.0.1 # @since Haml 4.0.1
# @private # @private
def fix_textareas!(input) def fix_textareas!(input)
pattern = /([ ]*)<(textarea)([^>]*)>(\n|&#x000A;)(.*?)(<\/\2>)/im pattern = /<(textarea)([^>]*)>(\n|&#x000A;)(.*?)<\/textarea>/im
input.gsub!(pattern) do |s| input.gsub!(pattern) do |s|
match = pattern.match(s) match = pattern.match(s)
content = match[5] content = match[4]
if match[4] == '&#x000A;' if match[3] == '&#x000A;'
content.sub!(/\A /, '&#x0020;') content.sub!(/\A /, '&#x0020;')
else else
content.sub!(/\A[ ]*/, '') content.sub!(/\A[ ]*/, '')
end end
"#{match[1]}<#{match[2]}#{match[3]}>\n#{content}</#{match[2]}>" "<#{match[1]}#{match[2]}>\n#{content}</#{match[1]}>"
end end
end end