kotovalexarian-likes-github
/
heartcombo--devise
mirror of https://github.com/heartcombo/devise.git
1
0
Fork 0
Code Releases Activity

Improve passwords autocomplete 

Use `autocomplete="new-password"` or `autocomplete="current-password"` to better signal to browsers and password managers how to handle the password fields.

This feature is especially useful for “change your password” and “new user” forms
This commit is contained in:
Gustavo Bazan 2018-04-04 15:46:34 +01:00 committed by Leonardo Tegon
parent 45481df14a
commit 6260c29a86
5 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CHANGELOG.md
View File

@ -1,5 +1,9 @@
### Unreleased ### Unreleased
* enhancements
* Add `autocomplete="new-password"` to new password fields (by @gssbzn)
* Add `autocomplete="current-password"` to current password fields (by @gssbzn)
### 4.4.3 - 2018-03-17 ### 4.4.3 - 2018-03-17
* bug fixes * bug fixes

2
app/views/devise/passwords/edit.html.erb
View File

@ -9,7 +9,7 @@
<% if @minimum_password_length %> <% if @minimum_password_length %>
<em>(<%= @minimum_password_length %> characters minimum)</em><br /> <em>(<%= @minimum_password_length %> characters minimum)</em><br />
<% end %> <% end %>
<%= f.password_field :password, autofocus: true, autocomplete: "off" %> <%= f.password_field :password, autofocus: true, autocomplete: "new-password" %>
</div> </div>
<div class="field"> <div class="field">

6
app/views/devise/registrations/edit.html.erb
View File

@ -14,7 +14,7 @@
<div class="field"> <div class="field">
<%= f.label :password %> <i>(leave blank if you don't want to change it)</i><br /> <%= f.label :password %> <i>(leave blank if you don't want to change it)</i><br />
<%= f.password_field :password, autocomplete: "off" %> <%= f.password_field :password, autocomplete: "new-password" %>
<% if @minimum_password_length %> <% if @minimum_password_length %>
<br /> <br />
<em><%= @minimum_password_length %> characters minimum</em> <em><%= @minimum_password_length %> characters minimum</em>
@ -23,12 +23,12 @@
<div class="field"> <div class="field">
<%= f.label :password_confirmation %><br /> <%= f.label :password_confirmation %><br />
<%= f.password_field :password_confirmation, autocomplete: "off" %> <%= f.password_field :password_confirmation, autocomplete: "new-password" %>
</div> </div>
<div class="field"> <div class="field">
<%= f.label :current_password %> <i>(we need your current password to confirm your changes)</i><br /> <%= f.label :current_password %> <i>(we need your current password to confirm your changes)</i><br />
<%= f.password_field :current_password, autocomplete: "off" %> <%= f.password_field :current_password, autocomplete: "current-password" %>
</div> </div>
<div class="actions"> <div class="actions">

4
app/views/devise/registrations/new.html.erb
View File

@ -13,12 +13,12 @@
<% if @minimum_password_length %> <% if @minimum_password_length %>
<em>(<%= @minimum_password_length %> characters minimum)</em> <em>(<%= @minimum_password_length %> characters minimum)</em>
<% end %><br /> <% end %><br />
<%= f.password_field :password, autocomplete: "off" %> <%= f.password_field :password, autocomplete: "new-password" %>
</div> </div>
<div class="field"> <div class="field">
<%= f.label :password_confirmation %><br /> <%= f.label :password_confirmation %><br />
<%= f.password_field :password_confirmation, autocomplete: "off" %> <%= f.password_field :password_confirmation, autocomplete: "new-password" %>
</div> </div>
<div class="actions"> <div class="actions">

2
app/views/devise/sessions/new.html.erb
View File

@ -8,7 +8,7 @@
<div class="field"> <div class="field">
<%= f.label :password %><br /> <%= f.label :password %><br />
<%= f.password_field :password, autocomplete: "off" %> <%= f.password_field :password, autocomplete: "current-password" %>
</div> </div>
<% if devise_mapping.rememberable? -%> <% if devise_mapping.rememberable? -%>