mirror of
https://github.com/heartcombo/devise.git
synced 2022-11-09 12:18:31 -05:00
Use 'head :no_content' in sessions_controller#destroy
Code cleanup for returning headers instead of an empty string when destroying sessions. Lines 464 and 471 on test/integration/autenticatable_test.rb were adjusted to assert on :no_content
This commit is contained in:
parent
f6c06ac786
commit
6664acd27f
2 changed files with 3 additions and 5 deletions
|
@ -28,9 +28,7 @@ class Devise::SessionsController < DeviseController
|
||||||
respond_to do |format|
|
respond_to do |format|
|
||||||
format.any(*navigational_formats) { redirect_to redirect_path }
|
format.any(*navigational_formats) { redirect_to redirect_path }
|
||||||
format.all do
|
format.all do
|
||||||
method = "to_#{request_format}"
|
head :no_content
|
||||||
text = {}.respond_to?(method) ? {}.send(method) : ""
|
|
||||||
render :text => text, :status => :ok
|
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
|
@ -461,14 +461,14 @@ class AuthenticationOthersTest < ActionController::IntegrationTest
|
||||||
test 'sign out with xml format returns ok response' do
|
test 'sign out with xml format returns ok response' do
|
||||||
sign_in_as_user
|
sign_in_as_user
|
||||||
get destroy_user_session_path(:format => 'xml')
|
get destroy_user_session_path(:format => 'xml')
|
||||||
assert_response :ok
|
assert_response :no_content
|
||||||
assert_not warden.authenticated?(:user)
|
assert_not warden.authenticated?(:user)
|
||||||
end
|
end
|
||||||
|
|
||||||
test 'sign out with json format returns empty json response' do
|
test 'sign out with json format returns empty json response' do
|
||||||
sign_in_as_user
|
sign_in_as_user
|
||||||
get destroy_user_session_path(:format => 'json')
|
get destroy_user_session_path(:format => 'json')
|
||||||
assert_response :ok
|
assert_response :no_content
|
||||||
assert_not warden.authenticated?(:user)
|
assert_not warden.authenticated?(:user)
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
Loading…
Reference in a new issue