From 9bf718dd82c0ac4ac1fdfc8fdbd0fe589d9bd995 Mon Sep 17 00:00:00 2001 From: Rodrigo Flores Date: Sat, 3 Mar 2012 10:40:59 -0300 Subject: [PATCH] Revert "Move devise/shared/_links.erb to devise/_links.erb" This reverts commit aa2d15aa338cd1e83462d58ff4eec1ce5fa122fb. Conflicts: CHANGELOG.rdoc --- app/views/devise/_links.erb | 25 ----------------- app/views/devise/confirmations/new.html.erb | 2 +- app/views/devise/passwords/edit.html.erb | 2 +- app/views/devise/passwords/new.html.erb | 2 +- app/views/devise/registrations/new.html.erb | 2 +- app/views/devise/sessions/new.html.erb | 2 +- app/views/devise/shared/_links.erb | 28 +++++++++++++++++-- app/views/devise/unlocks/new.html.erb | 2 +- lib/generators/devise/views_generator.rb | 20 +++++++++---- .../confirmations/new.html.erb | 2 +- .../simple_form_for/passwords/edit.html.erb | 2 +- .../simple_form_for/passwords/new.html.erb | 2 +- .../registrations/new.html.erb | 2 +- .../simple_form_for/sessions/new.html.erb | 2 +- .../simple_form_for/unlocks/new.html.erb | 2 +- test/generators/views_generator_test.rb | 2 +- 16 files changed, 52 insertions(+), 47 deletions(-) delete mode 100644 app/views/devise/_links.erb diff --git a/app/views/devise/_links.erb b/app/views/devise/_links.erb deleted file mode 100644 index eab783a4..00000000 --- a/app/views/devise/_links.erb +++ /dev/null @@ -1,25 +0,0 @@ -<%- if controller_name != 'sessions' %> - <%= link_to "Sign in", new_session_path(resource_name) %>
-<% end -%> - -<%- if devise_mapping.registerable? && controller_name != 'registrations' %> - <%= link_to "Sign up", new_registration_path(resource_name) %>
-<% end -%> - -<%- if devise_mapping.recoverable? && controller_name != 'passwords' %> - <%= link_to "Forgot your password?", new_password_path(resource_name) %>
-<% end -%> - -<%- if devise_mapping.confirmable? && controller_name != 'confirmations' %> - <%= link_to "Didn't receive confirmation instructions?", new_confirmation_path(resource_name) %>
-<% end -%> - -<%- if devise_mapping.lockable? && resource_class.unlock_strategy_enabled?(:email) && controller_name != 'unlocks' %> - <%= link_to "Didn't receive unlock instructions?", new_unlock_path(resource_name) %>
-<% end -%> - -<%- if devise_mapping.omniauthable? %> - <%- resource_class.omniauth_providers.each do |provider| %> - <%= link_to "Sign in with #{provider.to_s.titleize}", omniauth_authorize_path(resource_name, provider) %>
- <% end -%> -<% end -%> \ No newline at end of file diff --git a/app/views/devise/confirmations/new.html.erb b/app/views/devise/confirmations/new.html.erb index 18d81b14..b7ae403c 100644 --- a/app/views/devise/confirmations/new.html.erb +++ b/app/views/devise/confirmations/new.html.erb @@ -9,4 +9,4 @@
<%= f.submit "Resend confirmation instructions" %>
<% end %> -<%= render "links" %> \ No newline at end of file +<%= render :partial => "devise/shared/links" %> \ No newline at end of file diff --git a/app/views/devise/passwords/edit.html.erb b/app/views/devise/passwords/edit.html.erb index 5f7bcf87..e75c9371 100644 --- a/app/views/devise/passwords/edit.html.erb +++ b/app/views/devise/passwords/edit.html.erb @@ -13,4 +13,4 @@
<%= f.submit "Change my password" %>
<% end %> -<%= render "links" %> \ No newline at end of file +<%= render :partial => "devise/shared/links" %> \ No newline at end of file diff --git a/app/views/devise/passwords/new.html.erb b/app/views/devise/passwords/new.html.erb index b0b5690f..6c21e9fd 100644 --- a/app/views/devise/passwords/new.html.erb +++ b/app/views/devise/passwords/new.html.erb @@ -9,4 +9,4 @@
<%= f.submit "Send me reset password instructions" %>
<% end %> -<%= render "links" %> \ No newline at end of file +<%= render :partial => "devise/shared/links" %> \ No newline at end of file diff --git a/app/views/devise/registrations/new.html.erb b/app/views/devise/registrations/new.html.erb index f5136f13..d15e275a 100644 --- a/app/views/devise/registrations/new.html.erb +++ b/app/views/devise/registrations/new.html.erb @@ -15,4 +15,4 @@
<%= f.submit "Sign up" %>
<% end %> -<%= render "links" %> +<%= render :partial => "devise/shared/links" %> diff --git a/app/views/devise/sessions/new.html.erb b/app/views/devise/sessions/new.html.erb index f12116bf..ff59f7cc 100644 --- a/app/views/devise/sessions/new.html.erb +++ b/app/views/devise/sessions/new.html.erb @@ -14,4 +14,4 @@
<%= f.submit "Sign in" %>
<% end %> -<%= render "links" %> \ No newline at end of file +<%= render :partial => "devise/shared/links" %> \ No newline at end of file diff --git a/app/views/devise/shared/_links.erb b/app/views/devise/shared/_links.erb index c4cbfe66..eab783a4 100644 --- a/app/views/devise/shared/_links.erb +++ b/app/views/devise/shared/_links.erb @@ -1,3 +1,25 @@ -<% ActiveSupport::Deprecation.warn "Rendering partials devise/shared/_links.erb is deprecated" \ - "please use devise/_links.erb instead." %> -<%= render "links" %> \ No newline at end of file +<%- if controller_name != 'sessions' %> + <%= link_to "Sign in", new_session_path(resource_name) %>
+<% end -%> + +<%- if devise_mapping.registerable? && controller_name != 'registrations' %> + <%= link_to "Sign up", new_registration_path(resource_name) %>
+<% end -%> + +<%- if devise_mapping.recoverable? && controller_name != 'passwords' %> + <%= link_to "Forgot your password?", new_password_path(resource_name) %>
+<% end -%> + +<%- if devise_mapping.confirmable? && controller_name != 'confirmations' %> + <%= link_to "Didn't receive confirmation instructions?", new_confirmation_path(resource_name) %>
+<% end -%> + +<%- if devise_mapping.lockable? && resource_class.unlock_strategy_enabled?(:email) && controller_name != 'unlocks' %> + <%= link_to "Didn't receive unlock instructions?", new_unlock_path(resource_name) %>
+<% end -%> + +<%- if devise_mapping.omniauthable? %> + <%- resource_class.omniauth_providers.each do |provider| %> + <%= link_to "Sign in with #{provider.to_s.titleize}", omniauth_authorize_path(resource_name, provider) %>
+ <% end -%> +<% end -%> \ No newline at end of file diff --git a/app/views/devise/unlocks/new.html.erb b/app/views/devise/unlocks/new.html.erb index 0dc79ac0..c6cdcfe5 100644 --- a/app/views/devise/unlocks/new.html.erb +++ b/app/views/devise/unlocks/new.html.erb @@ -9,4 +9,4 @@
<%= f.submit "Resend unlock instructions" %>
<% end %> -<%= render "links" %> \ No newline at end of file +<%= render :partial => "devise/shared/links" %> \ No newline at end of file diff --git a/lib/generators/devise/views_generator.rb b/lib/generators/devise/views_generator.rb index 328b345e..aa656bba 100644 --- a/lib/generators/devise/views_generator.rb +++ b/lib/generators/devise/views_generator.rb @@ -39,6 +39,17 @@ module Devise end end + class SharedViewsGenerator < Rails::Generators::Base #:nodoc: + include ViewPathTemplates + source_root File.expand_path("../../../../app/views/devise", __FILE__) + desc "Copies shared Devise views to your application." + + # Override copy_views to just copy mailer and shared. + def copy_views + view_directory :shared + end + end + class FormForGenerator < Rails::Generators::Base #:nodoc: include ViewPathTemplates source_root File.expand_path("../../../../app/views/devise", __FILE__) @@ -80,15 +91,12 @@ module Devise end class ViewsGenerator < Rails::Generators::Base - include ViewPathTemplates - - source_root File.expand_path("../../../../app/views/devise", __FILE__) desc "Copies Devise views to your application." - def copy_views - copy_file "_links.erb", "#{target_path}/_links.erb" - end + argument :scope, :required => false, :default => nil, + :desc => "The scope to copy views to" + invoke SharedViewsGenerator hook_for :form_builder, :aliases => "-b", :desc => "Form builder to be used", :default => defined?(SimpleForm) ? "simple_form_for" : "form_for" diff --git a/lib/generators/templates/simple_form_for/confirmations/new.html.erb b/lib/generators/templates/simple_form_for/confirmations/new.html.erb index 4c38fefd..9b0344e8 100644 --- a/lib/generators/templates/simple_form_for/confirmations/new.html.erb +++ b/lib/generators/templates/simple_form_for/confirmations/new.html.erb @@ -12,4 +12,4 @@ <% end %> -<%= render "links" %> \ No newline at end of file +<%= render :partial => "devise/shared/links" %> \ No newline at end of file diff --git a/lib/generators/templates/simple_form_for/passwords/edit.html.erb b/lib/generators/templates/simple_form_for/passwords/edit.html.erb index 80af5860..be56ee41 100644 --- a/lib/generators/templates/simple_form_for/passwords/edit.html.erb +++ b/lib/generators/templates/simple_form_for/passwords/edit.html.erb @@ -16,4 +16,4 @@ <% end %> -<%= render "links" %> \ No newline at end of file +<%= render :partial => "devise/shared/links" %> \ No newline at end of file diff --git a/lib/generators/templates/simple_form_for/passwords/new.html.erb b/lib/generators/templates/simple_form_for/passwords/new.html.erb index 01897508..56e2906f 100644 --- a/lib/generators/templates/simple_form_for/passwords/new.html.erb +++ b/lib/generators/templates/simple_form_for/passwords/new.html.erb @@ -12,4 +12,4 @@ <% end %> -<%= render "links" %> \ No newline at end of file +<%= render :partial => "devise/shared/links" %> \ No newline at end of file diff --git a/lib/generators/templates/simple_form_for/registrations/new.html.erb b/lib/generators/templates/simple_form_for/registrations/new.html.erb index aece3e5b..5f85c9ba 100644 --- a/lib/generators/templates/simple_form_for/registrations/new.html.erb +++ b/lib/generators/templates/simple_form_for/registrations/new.html.erb @@ -14,4 +14,4 @@ <% end %> -<%= render "links" %> +<%= render :partial => "devise/shared/links" %> diff --git a/lib/generators/templates/simple_form_for/sessions/new.html.erb b/lib/generators/templates/simple_form_for/sessions/new.html.erb index 3c1e0d75..e2eab4be 100644 --- a/lib/generators/templates/simple_form_for/sessions/new.html.erb +++ b/lib/generators/templates/simple_form_for/sessions/new.html.erb @@ -12,4 +12,4 @@ <% end %> -<%= render "links" %> \ No newline at end of file +<%= render :partial => "devise/shared/links" %> \ No newline at end of file diff --git a/lib/generators/templates/simple_form_for/unlocks/new.html.erb b/lib/generators/templates/simple_form_for/unlocks/new.html.erb index d717a763..89011af0 100644 --- a/lib/generators/templates/simple_form_for/unlocks/new.html.erb +++ b/lib/generators/templates/simple_form_for/unlocks/new.html.erb @@ -12,4 +12,4 @@ <% end %> -<%= render "links" %> \ No newline at end of file +<%= render :partial => "devise/shared/links" %> \ No newline at end of file diff --git a/test/generators/views_generator_test.rb b/test/generators/views_generator_test.rb index 8036a48a..958bae62 100644 --- a/test/generators/views_generator_test.rb +++ b/test/generators/views_generator_test.rb @@ -46,7 +46,7 @@ class ViewsGeneratorTest < Rails::Generators::TestCase assert_file "app/views/#{scope}/registrations/new.html.erb" assert_file "app/views/#{scope}/registrations/edit.html.erb" assert_file "app/views/#{scope}/sessions/new.html.erb" + assert_file "app/views/#{scope}/shared/_links.erb" assert_file "app/views/#{scope}/unlocks/new.html.erb" - assert_file "app/views/#{scope}/_links.erb" end end