Merge pull request #2631 from vipulnsward/cleanup_tests

Cleanup tests for unused variables

test/controllers/sessions_controller_test.rb

@@ -10,7 +10,7 @@ class SessionsControllerTest < ActionController::TestCase
     end
     request.env["devise.mapping"] = Devise.mappings[:user]
     request.session["user_return_to"] = 'foo.bar'
-    user = create_user
+    create_user
     post :create, :user => {
       :email => "wrong@email.com",
       :password => "wrongpassword"

test/integration/recoverable_test.rb

@@ -190,7 +190,7 @@ class PasswordTest < ActionDispatch::IntegrationTest
   end
 
   test 'sign in user automatically after changing its password' do
-    user = create_user
+    create_user
     request_forgot_password
     reset_password
 
@@ -260,7 +260,7 @@ class PasswordTest < ActionDispatch::IntegrationTest
   end
 
   test 'change password with valid parameters in XML format should return valid response' do
-    user = create_user
+    create_user
     request_forgot_password
     put user_password_path(:format => 'xml'), :user => {
       :reset_password_token => 'abcdef', :password => '987654321', :password_confirmation => '987654321'

test/integration/rememberable_test.rb

@@ -64,14 +64,14 @@ class RememberMeTest < ActionDispatch::IntegrationTest
     # since we changed the domain. This is the only difference with the
     # previous test.
     swap Devise, :rememberable_options => { :domain => "omg.somewhere.com" } do
-      user = sign_in_as_user :remember_me => true
+      sign_in_as_user :remember_me => true
       assert_nil request.cookies["remember_user_token"]
     end
   end
 
   test 'generate remember token with a custom key' do
     swap Devise, :rememberable_options => { :key => "v1lat_token" } do
-      user = sign_in_as_user :remember_me => true
+      sign_in_as_user :remember_me => true
       assert request.cookies["v1lat_token"]
     end
   end
@@ -79,7 +79,7 @@ class RememberMeTest < ActionDispatch::IntegrationTest
   test 'generate remember token after sign in setting session options' do
     begin
       Rails.configuration.session_options[:domain] = "omg.somewhere.com"
-      user = sign_in_as_user :remember_me => true
+      sign_in_as_user :remember_me => true
       assert_nil request.cookies["remember_user_token"]
     ensure
       Rails.configuration.session_options.delete(:domain)

test/models/database_authenticatable_test.rb

@@ -203,7 +203,7 @@ class DatabaseAuthenticatableTest < ActiveSupport::TestCase
   end
 
   test 'downcase_keys with validation' do
-    user = User.create(:email => "HEllO@example.com", :password => "123456")
+    User.create(:email => "HEllO@example.com", :password => "123456")
     user = User.create(:email => "HEllO@example.com", :password => "123456")
     assert !user.valid?
   end