Commit Graph

15 Commits

Author SHA1 Message Date
Pat Allan f39c6fd927 Add the frozen_string_literal pragma comment to all Ruby files. (#4725) 2017-12-21 15:36:29 -02:00
Ashley Foster 31801fc9a0 Fix missing validations on Signup (#4674)
* Fix missing validations on Signup

This commit fixes issue
https://github.com/plataformatec/devise/issues/4673

This removes `validate: false` from saving a record when `Trackable` is
in use.

* Add test case

* Add mongoid model
2017-11-28 12:58:41 -02:00
Nicolas Viennot 620478cc5f Revert "Better error message in case a trackable module can't be saved."
This reverts commit 43d0715238.

save() returns false only when validations failed. In this case, validations are
not performed. Therefore save() may never return a falsy value.
If save() fails, the appropriate exception is raised.

With certain ORMs, such as NoBrainer, save() never returns true/false, but
always raise an exception. This commit lift the incompatiblity.
2015-01-10 09:38:43 -05:00
Kush Kella 451be888cb added non-bang version of update_tracked_fields 2014-05-21 16:18:35 -07:00
Anshul Sharma dc1b399a8b Updated ruby 1.9 hash syntax 2014-02-25 22:12:55 +05:30
Ben Knowles a1411c885f Trackable should use the remote IP address, not the gateway's 2012-07-12 13:34:31 -05:00
Rodrigo Flores 18aef6ac33 Some refactor 2012-02-22 13:55:03 -02:00
Rodrigo Flores 890f6031c3 Required fields on trackable 2012-02-22 13:55:03 -02:00
José Valim 43d0715238 Better error message in case a trackable module can't be saved. 2012-02-15 17:07:46 +01:00
Vasiliy Ermolovich 7e9ba53d82 use Time.now.utc instead of Time.now, closes #1421 2011-11-09 23:26:48 +03:00
salidux 60822641cb fix to obtain user original IP in a proxyed environment 2011-10-19 22:23:04 -02:00
Oleg Shparber df3e711ee0 Typo 2011-09-09 12:46:35 +03:00
Matt Wright d2a4c503f7 Typo in doc comment 2011-07-23 15:03:10 -07:00
José Valim 0e64bc74b7 Move trackabe logic to the model. 2010-03-03 12:03:43 +01:00
José Valim f9c5dd6a79 Added trackable for sign_in_count, sign_in_at and sign_in_ip. 2009-11-24 15:18:42 -02:00