Do not use required='required' when browser validations are turned off

This commit is contained in:
Vinicius Baggio 2011-05-26 14:40:17 -03:00
parent 29c5376d79
commit 795691aced
2 changed files with 9 additions and 1 deletions

View File

@ -74,7 +74,7 @@ module SimpleForm
# Whether this input is valid for HTML 5 required attribute.
def has_required?
attribute_required? && SimpleForm.html5
attribute_required? && SimpleForm.html5 && SimpleForm.browser_validations
end
def has_autofocus?

View File

@ -780,6 +780,14 @@ class InputTest < ActionView::TestCase
end
end
test 'when not using browser validations, input should not generate required html attribute' do
swap SimpleForm, :browser_validations => false do
with_input_for @user, :name, :string
assert_select 'input[type=text].required'
assert_no_select 'input[type=text][required]'
end
end
test 'collection input with select type should not generate invalid required html attribute' do
with_input_for @user, :name, :select, :collection => ['Jose' , 'Carlos']
assert_select 'select.required'