kotovalexarian-likes-github/httparty
1
0
Fork 0
mirror of https://github.com/jnunemaker/httparty synced 2023-03-27 23:23:07 -04:00
Code Releases Activity

Support SameSite attribute in cookies per https://tools.ietf.org/html/draft-ietf-httpbis-rfc6265bis-02#section-5.3.7

Browse source
This commit is contained in:
Jon Eisenstein 2020-02-05 13:31:15 -05:00
parent 689e64bb2d
commit 35ba4ba1aa
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/httparty/cookie_hash.rb
View file

@ -1,5 +1,5 @@
class HTTParty::CookieHash < Hash #:nodoc:
CLIENT_COOKIES = %w(path expires domain path secure httponly)
CLIENT_COOKIES = %w(path expires domain path secure httponly samesite)
def add_cookies(value)
case value

6
spec/httparty/cookie_hash_spec.rb
View file

@ -74,6 +74,12 @@ RSpec.describe HTTParty::CookieHash do
expect(@s).not_to match(/path=\//)
end
it "should not include SameSite attribute" do
@cookie_hash.add_cookies(samesite: "Strict")
@s = @cookie_hash.to_cookie_string
expect(@s).not_to match(/samesite=Strict/)
end
it "should not include client side only cookies even when attributes use camal case" do
@cookie_hash.add_cookies(Path: "/")
@s = @cookie_hash.to_cookie_string