kotovalexarian-likes-github/httparty
1
0
Fork 0
mirror of https://github.com/jnunemaker/httparty synced 2023-03-27 23:23:07 -04:00
Code Releases Activity

Verify ssl certificates if we're supplying a pem file.

Browse source
This commit is contained in:
Daniel Morrison 2009-11-26 14:57:28 +00:00 • committed by Sandro Turriate
parent d6af65b083
commit b322850e8a
2 changed files with 44 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lib/httparty/request.rb
View file

@ -51,7 +51,6 @@ module HTTParty
def http
http = Net::HTTP.new(uri.host, uri.port, options[:http_proxyaddr], options[:http_proxyport])
http.use_ssl = ssl_implied?
http.verify_mode = OpenSSL::SSL::VERIFY_NONE
if options[:timeout] && options[:timeout].is_a?(Integer)
http.open_timeout = options[:timeout]
@ -61,6 +60,9 @@ module HTTParty
if options[:pem] && http.use_ssl?
http.cert = OpenSSL::X509::Certificate.new(options[:pem])
http.key = OpenSSL::PKey::RSA.new(options[:pem])
http.verify_mode = OpenSSL::SSL::VERIFY_PEER
else
http.verify_mode = OpenSSL::SSL::VERIFY_NONE
end
http

60
spec/httparty/request_spec.rb
View file

@ -52,29 +52,51 @@ describe HTTParty::Request do
OpenSSL::PKey::RSA.stub(:new)
end
it "should use a PEM certificate when provided" do
@request.stub!(:uri).and_return(URI.parse("https://google.com"))
pem = :pem_contents
cert = mock("OpenSSL::X509::Certificate")
key = mock("OpenSSL::PKey::RSA")
OpenSSL::X509::Certificate.should_receive(:new).with(pem).and_return(cert)
OpenSSL::PKey::RSA.should_receive(:new).with(pem).and_return(key)
context "when scheme is https" do
before do
@request.stub!(:uri).and_return(URI.parse("https://google.com"))
pem = :pem_contents
@cert = mock("OpenSSL::X509::Certificate")
@key = mock("OpenSSL::PKey::RSA")
OpenSSL::X509::Certificate.should_receive(:new).with(pem).and_return(@cert)
OpenSSL::PKey::RSA.should_receive(:new).with(pem).and_return(@key)
@request.options[:pem] = pem
pem_http = @request.send(:http)
pem_http.cert.should == cert
pem_http.key.should == key
@request.options[:pem] = pem
@pem_http = @request.send(:http)
end
it "should use a PEM certificate when provided" do
@pem_http.cert.should == @cert
@pem_http.key.should == @key
end
it "should verify the certificate when provided" do
@pem_http = @request.send(:http)
@pem_http.verify_mode.should == OpenSSL::SSL::VERIFY_PEER
end
end
it "does not assign a PEM if scheme is not https" do
http = Net::HTTP.new('google.com')
http.should_not_receive(:cert=)
http.should_not_receive(:key=)
Net::HTTP.stub(:new => http)
context "when scheme is not https" do
it "does not assign a PEM" do
http = Net::HTTP.new('google.com')
http.should_not_receive(:cert=)
http.should_not_receive(:key=)
Net::HTTP.stub(:new => http)
request = HTTParty::Request.new(Net::HTTP::Get, 'http://google.com')
request.options[:pem] = :pem_contents
request.send(:http)
request = HTTParty::Request.new(Net::HTTP::Get, 'http://google.com')
request.options[:pem] = :pem_contents
request.send(:http)
end
it "should not verify a certificate if scheme is not https" do
http = Net::HTTP.new('google.com')
Net::HTTP.stub(:new => http)
request = HTTParty::Request.new(Net::HTTP::Get, 'http://google.com')
request.options[:pem] = :pem_contents
http = request.send(:http)
http.verify_mode.should == OpenSSL::SSL::VERIFY_NONE
end
end
end