kotovalexarian-likes-github/httparty
1
0
Fork 0
mirror of https://github.com/jnunemaker/httparty synced 2023-03-27 23:23:07 -04:00
Code Releases Activity

Removed Hash#from_xml method from HTTParty and added regression spec to make sure HTTParty doesn't foobar ActiveSupport.

Browse source
This commit is contained in:
John Nunemaker 2008-12-08 21:14:49 -05:00
parent 8591270358
commit fc44b0b75a
3 changed files with 18 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/core_extensions.rb
View file

@ -286,10 +286,6 @@ class ToHashParser
end end
class Hash class Hash
def self.from_xml(xml)
ToHashParser.from_xml(xml)
end
# @return <String> This hash as a query string # @return <String> This hash as a query string
# #
# @example # @example

2
lib/httparty/request.rb
View file

@ -95,7 +95,7 @@ module HTTParty
return nil if body.nil? or body.empty? return nil if body.nil? or body.empty?
case format case format
when :xml when :xml
Hash.from_xml(body) ToHashParser.from_xml(body)
when :json when :json
JSON.parse(body) JSON.parse(body)
else else

16
spec/as_buggery_spec.rb Normal file
View file

@ -0,0 +1,16 @@
require File.join(File.dirname(__FILE__), 'spec_helper')
require 'activesupport'
describe Hash do
describe "#from_xml" do
it "should be able to convert xml with datetimes" do
xml =<<EOL
<?xml version="1.0" encoding="UTF-8"?>
<created-at type="datetime">2008-12-01T20:00:00-05:00</created-at>
EOL
hsh = Hash.from_xml(xml)
hsh["created_at"].should == Time.parse("December 01st, 2008 20:00:00")
end
end
end