mirror of
https://github.com/jnunemaker/httparty
synced 2023-03-27 23:23:07 -04:00
77d11c6ca3
This PR fixes the issue(s) described in #713. To fix the logger option issue, I simply delete `Request.options[:logger]` when dumping. To fix the proc parser issue, I delete `Request.options[:parser]` if and only if `Request.options[:logger]` is a proc. If `Request.options[:logger]` is a regular class, `Marshal.dump` should proceed as normal. This should not affect the `Marshal.dump` behavior described in issue #143 and fixed by PR #618. I have added a feature spec to make sure marshalling the request works as intended, as well as a unit test to ensure `Marshal.load(Marshal.dump(req))` works as it should. |
||
|---|---|---|
| .. | ||
| steps | ||
| basic_authentication.feature | ||
| command_line.feature | ||
| deals_with_http_error_codes.feature | ||
| digest_authentication.feature | ||
| handles_compressed_responses.feature | ||
| handles_multiple_formats.feature | ||
| supports_marshalling_with_logger_and_proc.feature | ||
| supports_read_timeout_option.feature | ||
| supports_redirection.feature | ||
| supports_timeout_option.feature | ||