Fixing Issue #916. Overoptimization leading to empty var;

lib/nodes.js

@@ -282,7 +282,7 @@
       post = this.compileNode(o);
       scope = o.scope;
       if (scope.expressions === this) {
-        if (!o.globals && o.scope.hasDeclarations) {
+        if (!o.globals && o.scope.hasDeclarations()) {
           code += "" + this.tab + "var " + (scope.declaredVariables().join(', ')) + ";\n";
         }
         if (scope.hasAssignments) {

lib/scope.js

@@ -34,7 +34,6 @@
         return true;
       }
       this.add(name, 'var');
-      this.hasDeclarations = true;
       return false;
     };
     Scope.prototype.parameter = function(name) {
@@ -76,7 +75,6 @@
         index++;
       }
       this.add(temp, 'var');
-      this.hasDeclarations = true;
       return temp;
     };
     Scope.prototype.assign = function(name, value) {
@@ -86,6 +84,9 @@
       });
       return this.hasAssignments = true;
     };
+    Scope.prototype.hasDeclarations = function() {
+      return !!this.declaredVariables().length;
+    };
     Scope.prototype.declaredVariables = function() {
       var realVars, tempVars, v, _i, _len, _ref;
       realVars = [];

src/nodes.coffee

@@ -245,7 +245,7 @@ exports.Expressions = class Expressions extends Base
     post = @compileNode o
     {scope} = o
     if scope.expressions is this
-      if not o.globals and o.scope.hasDeclarations
+      if not o.globals and o.scope.hasDeclarations()
         code += "#{@tab}var #{ scope.declaredVariables().join(', ') };\n"
       if scope.hasAssignments
         code += "#{@tab}var #{ multident scope.assignedVariables().join(', '), @tab };\n"

src/scope.coffee

@@ -34,7 +34,6 @@ exports.Scope = class Scope
   find: (name, options) ->
     return yes if @check name, options
     @add name, 'var'
-    @hasDeclarations = yes
     no
 
   # Reserve a variable name as originating from a function parameter for this
@@ -68,7 +67,6 @@ exports.Scope = class Scope
     index = 0
     index++ while @check((temp = @temporary type, index), true)
     @add temp, 'var'
-    @hasDeclarations = yes
     temp
 
   # Ensure that an assignment is made at the top of this scope
@@ -77,6 +75,10 @@ exports.Scope = class Scope
     @add name, value: value, assigned: true
     @hasAssignments = yes
 
+  # Does this scope have any declared variables?
+  hasDeclarations: ->
+    !!@declaredVariables().length
+
   # Return the list of variables first declared in this scope.
   declaredVariables: ->
     realVars = []