kotovalexarian-likes-github/jashkenas--coffeescript
1
0
Fork 0
mirror of https://github.com/jashkenas/coffeescript.git synced 2022-11-09 12:23:24 -05:00
Code Releases Activity

Issue #2054 "{arguments}"

Browse source 
Fixes error message: SyntaxError: variable name may not be "true"

Permits assigning to "arguments" and "eval" properties in
object literals.
This commit is contained in:
Gerald Lewis 2012-01-19 11:33:43 -05:00
parent 7c56da26f6
commit c3a8a4f81f
3 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
lib/coffee-script/nodes.js
View file

@ -1338,13 +1338,14 @@
Assign.name = 'Assign'; Assign.name = 'Assign';
function Assign(variable, value, context, options) { function Assign(variable, value, context, options) {
var name, _ref3; var forbidden, name, _ref3;
this.variable = variable; this.variable = variable;
this.value = value; this.value = value;
this.context = context; this.context = context;
this.param = options && options.param; this.param = options && options.param;
this.subpattern = options && options.subpattern; this.subpattern = options && options.subpattern;
if (name = (_ref3 = this.variable.unwrapAll().value, __indexOf.call(STRICT_PROSCRIBED, _ref3) >= 0)) { forbidden = (_ref3 = (name = this.variable.unwrapAll().value), __indexOf.call(STRICT_PROSCRIBED, _ref3) >= 0);
if (forbidden && this.context !== 'object') {
throw SyntaxError("variable name may not be \"" + name + "\""); throw SyntaxError("variable name may not be \"" + name + "\"");
} }
} }

3
src/nodes.coffee
View file

@ -993,7 +993,8 @@ exports.Assign = class Assign extends Base
constructor: (@variable, @value, @context, options) -> constructor: (@variable, @value, @context, options) ->
@param = options and options.param @param = options and options.param
@subpattern = options and options.subpattern @subpattern = options and options.subpattern
if name = @variable.unwrapAll().value in STRICT_PROSCRIBED forbidden = (name = @variable.unwrapAll().value) in STRICT_PROSCRIBED
if forbidden and @context isnt 'object'
throw SyntaxError "variable name may not be \"#{name}\"" throw SyntaxError "variable name may not be \"#{name}\""
children: ['variable', 'value'] children: ['variable', 'value']

5
test/strict.coffee
View file

@ -117,6 +117,9 @@ test "`Future Reserved Word`s, `eval` and `arguments` restrictions", ->
check "++{keyword}" check "++{keyword}"
check "{keyword}--" check "{keyword}--"
check "--{keyword}" check "--{keyword}"
destruct = (keyword, check = strict) ->
check "{#{keyword}}"
check "o = {#{keyword}}"
invoke = (keyword, check = strict) -> invoke = (keyword, check = strict) ->
check "#{keyword} yes" check "#{keyword} yes"
check "do #{keyword}" check "do #{keyword}"
@ -134,6 +137,7 @@ test "`Future Reserved Word`s, `eval` and `arguments` restrictions", ->
for keyword in future for keyword in future
access keyword access keyword
assign keyword assign keyword
destruct keyword
invoke keyword invoke keyword
fnDecl keyword fnDecl keyword
param keyword param keyword
@ -143,6 +147,7 @@ test "`Future Reserved Word`s, `eval` and `arguments` restrictions", ->
for keyword in ['eval', 'arguments'] for keyword in ['eval', 'arguments']
access keyword, strictOk access keyword, strictOk
assign keyword assign keyword
destruct keyword, strictOk
invoke keyword, strictOk invoke keyword, strictOk
fnDecl keyword fnDecl keyword
param keyword param keyword