fixing compound assignments to global variables. oof.
This commit is contained in:
parent
de511e0348
commit
f0e17fc20f
|
@ -1631,7 +1631,7 @@
|
|||
Assign.prototype.compileConditional = function(o) {
|
||||
var left, right, _ref2;
|
||||
_ref2 = this.variable.cacheReference(o), left = _ref2[0], right = _ref2[1];
|
||||
if (left.base instanceof Literal && left.base.value !== "this" && !o.scope.check(left.base.value)) {
|
||||
if (!left.properties.length && left.base instanceof Literal && left.base.value !== "this" && !o.scope.check(left.base.value)) {
|
||||
throw new Error("the variable \"" + left.base.value + "\" can't be assigned with " + this.context + " because it has not been defined.");
|
||||
}
|
||||
if (__indexOf.call(this.context, "?") >= 0) {
|
||||
|
|
|
@ -1119,7 +1119,8 @@ exports.Assign = class Assign extends Base
|
|||
compileConditional: (o) ->
|
||||
[left, right] = @variable.cacheReference o
|
||||
# Disallow conditional assignment of undefined variables.
|
||||
if left.base instanceof Literal and left.base.value != "this" and not o.scope.check left.base.value
|
||||
if not left.properties.length and left.base instanceof Literal and
|
||||
left.base.value != "this" and not o.scope.check left.base.value
|
||||
throw new Error "the variable \"#{left.base.value}\" can't be assigned with #{@context} because it has not been defined."
|
||||
if "?" in @context then o.isExistentialEquals = true
|
||||
new Op(@context[...-1], left, new Assign(right, @value, '=') ).compile o
|
||||
|
|
|
@ -297,6 +297,13 @@ test "#1627: prohibit conditional assignment of undefined variables", ->
|
|||
throws (-> CoffeeScript.compile "-> -> -> x ?= 10"), null, "prohibit (-> -> -> x ?= 10)"
|
||||
doesNotThrow (-> CoffeeScript.compile "x = null; -> -> -> x ?= 10"), "allow (x = null; -> -> -> x ?= 10)"
|
||||
|
||||
test "more existential assignment", ->
|
||||
global.temp ?= 0
|
||||
eq global.temp, 0
|
||||
global.temp or= 100
|
||||
eq global.temp, 100
|
||||
delete global.temp
|
||||
|
||||
test "#1348, #1216: existential assignment compilation", ->
|
||||
nonce = {}
|
||||
a = nonce
|
||||
|
|
Loading…
Reference in New Issue