From 55cda8c7ecdf80c8529cdc372cb5313396fc8866 Mon Sep 17 00:00:00 2001 From: Akira Matsuda Date: Tue, 13 Dec 2016 18:07:37 +0900 Subject: [PATCH] We're manually deleting test data in the tests --- .../test/support/database_cleaner.rb | 21 ------------------- kaminari.gemspec | 1 - test/test_helper.rb | 2 -- 3 files changed, 24 deletions(-) delete mode 100644 kaminari-core/test/support/database_cleaner.rb diff --git a/kaminari-core/test/support/database_cleaner.rb b/kaminari-core/test/support/database_cleaner.rb deleted file mode 100644 index ea6eaff..0000000 --- a/kaminari-core/test/support/database_cleaner.rb +++ /dev/null @@ -1,21 +0,0 @@ -# frozen_string_literal: true -# -# kaminari repo's tests successfully runs without DatabaseCleaner now. -# DatabaseCleaner[:active_record].strategy = :transaction if defined? ActiveRecord - -# class ActiveSupport::TestCase -# class << self -# def startup -# DatabaseCleaner.clean_with :truncation if defined? ActiveRecord -# super -# end -# end - -# setup do -# DatabaseCleaner.start -# end - -# teardown do -# DatabaseCleaner.clean -# end -# end diff --git a/kaminari.gemspec b/kaminari.gemspec index 7f0a62b..3069bf3 100644 --- a/kaminari.gemspec +++ b/kaminari.gemspec @@ -26,5 +26,4 @@ Gem::Specification.new do |s| s.add_development_dependency 'rake', '>= 0' s.add_development_dependency 'rr', '>= 0' s.add_development_dependency 'capybara', '>= 1.0' - s.add_development_dependency 'database_cleaner', '>= 1.4.1' end diff --git a/test/test_helper.rb b/test/test_helper.rb index 8b3d125..7ae50cc 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -9,8 +9,6 @@ require 'active_record' require 'bundler/setup' Bundler.require -require 'database_cleaner' - # Simulate a gem providing a subclass of ActiveRecord::Base before the Railtie is loaded. require 'fake_gem'