From 7f997c7f4252088c7eb9eb11d4ffd1c9c41f3407 Mon Sep 17 00:00:00 2001 From: Akira Matsuda Date: Sat, 3 Jun 2017 00:51:32 +0900 Subject: [PATCH] Give AR#group an Array instead of a comma separated String --- kaminari-core/test/fake_app/active_record/models.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kaminari-core/test/fake_app/active_record/models.rb b/kaminari-core/test/fake_app/active_record/models.rb index 22995b6..82748ed 100644 --- a/kaminari-core/test/fake_app/active_record/models.rb +++ b/kaminari-core/test/fake_app/active_record/models.rb @@ -14,11 +14,11 @@ class User < ActiveRecord::Base scope :by_name, -> { order(:name) } scope :by_read_count, -> { cols = if connection.adapter_name == "PostgreSQL" - column_names.map { |column| %{"users"."#{column}"} }.join(", ") + column_names.map { |column| %{"users"."#{column}"} } else - '"users"."id"' + ['"users"."id"'] end - group(cols).select("count(readerships.id) AS read_count, #{cols}").order('read_count DESC') + group(*cols).select("count(readerships.id) AS read_count, #{cols.join(', ')}").order('read_count DESC') } end class Authorship < ActiveRecord::Base