Akira Matsuda
|
21baf16c04
|
Don't accept negative value for padding
Because negative offset behavior is so unpredictable: https://github.com/amatsuda/kaminari/issues/839#issuecomment-268211318
closes #839
|
2017-01-05 15:43:50 +09:00 |
|
Akira Matsuda
|
c5aca2f5a2
|
total_count for a loaded Relation that has no @_per can also be calculable using `default_per_page`
Default per_page for a loaded Relation that has no @_per is `default_per_page`
|
2017-01-05 01:20:34 +09:00 |
|
Akira Matsuda
|
11d4aaf3ed
|
total_count has to be retrieved from DB if loaded AR::Relation is empty
fixes #845
|
2017-01-05 01:14:59 +09:00 |
|
Akira Matsuda
|
4c795ac601
|
Port some padding tests from AR to Array
|
2016-12-20 18:50:23 +09:00 |
|
Pablo Crivella
|
e75403f479
|
Coerce num param to int and assign to @_padding
This avoids code failing when calling "Model.padding(params[:padding] || 0)" since params[:padding] is a string.
|
2016-12-15 00:25:57 +01:00 |
|
Akira Matsuda
|
384eead564
|
Cleanup testing data between test runs
|
2016-12-08 00:49:14 +09:00 |
|
Yuki Nishijima
|
48ba1f01d4
|
Backfill test converage for #without_count
closes #681, fixes #545.
|
2016-12-05 02:25:31 +00:00 |
|
Akira Matsuda
|
3ab161e8c3
|
Deprecate max_pages_per in favor of max_pages for configuring max_pages
Because "per" in the method name doesn't make sence to me.
This configuration is not about per_page value.
|
2016-12-02 09:48:23 +09:00 |
|
Yuki Nishijima
|
57d98f8a2e
|
Add more test coverage around select and group
|
2016-12-01 02:39:31 +00:00 |
|
Akira Matsuda
|
721654ca75
|
#️⃣ 🚀 🔞
|
2016-11-22 22:16:57 +09:00 |
|
Akira Matsuda
|
f33e2566a6
|
RSpec => Test/Unit
|
2016-11-22 21:52:33 +09:00 |