Refix #2292

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 - Always write `deps.yml` if `--track-dependencies` is set and the file doesn't exist
 - Add `--dependency-file` flag to configure the file location.
+- Handle the removal of a file in dependencies. Fixes #2292
 
 # 5.0.0.rc.1
 

middleman-core/features/incremental_builds.feature

@@ -39,6 +39,43 @@ Feature: Incremental builds
       | build/standalone.html |
     And the file "build/standalone.html" should contain "Updated"
 
+
+    Scenario: Removing a file after an initial build should not crash
+     Given an empty app
+     When a file named "config.rb" with:
+       """
+       """
+     When a file named "source/layout.erb" with:
+       """
+       <%= yield %>
+       """
+     When a file named "source/standalone.html.erb" with:
+       """
+       Initial
+       """
+     When a file named "source/other.html.erb" with:
+       """
+       Some other file
+       """
+     Then build the app tracking dependencies
+     Then the output should contain "create  build/standalone.html"
+     Then the output should contain "create  build/other.html"
+     Then the following files should exist:
+       | build/standalone.html |
+       | build/other.html      |
+     When I remove the file "source/other.html.erb"
+     Then build app with only changed
+     Then there are "0" files which are created
+     Then there are "0" files which are updated
+     Then there are "1" files which are removed
+     Then the output should contain "skipped  build/standalone.html"
+     Then the output should contain "remove  build/other.html"
+     Then the following files should exist:
+       | build/standalone.html |
+     Then the following files should not exist:
+       | build/other.html |
+     And the file "deps.yml" should not contain "other.html.erb"
+
   Scenario: Changing a layout should only rebuild pages which use that layout
     Given an empty app
     When a file named "config.rb" with:

middleman-core/lib/middleman-core/dependencies/vertices/file_vertex.rb

@@ -33,7 +33,7 @@ module Middleman
 
       Contract Bool
       def valid?
-        @is_valid = (previous_hash.nil? || hash_file == previous_hash) if @is_valid.nil?
+        @is_valid = ((File.exist? @full_path) && (previous_hash.nil? || hash_file == previous_hash)) if @is_valid.nil?
         @is_valid
       end