mirror of
https://github.com/middleman/middleman.git
synced 2022-11-09 12:20:27 -05:00
use instance hooks provided by hooks instead of changing the gem’s source
Conflicts: middleman-core/lib/middleman-core/core_extensions/extensions.rb
This commit is contained in:
parent
732532b72e
commit
e5d95944c4
3 changed files with 9 additions and 7 deletions
|
@ -32,6 +32,7 @@ module Middleman
|
|||
|
||||
# Uses callbacks
|
||||
include Hooks
|
||||
include Hooks::InstanceHooks
|
||||
|
||||
# Before request hook
|
||||
define_hook :before
|
||||
|
@ -223,6 +224,12 @@ module Middleman
|
|||
end
|
||||
alias :inspect :to_s # Ruby 2.0 calls inspect for NoMethodError instead of to_s
|
||||
|
||||
# Hooks clones _hooks from the class to the instance.
|
||||
# https://github.com/apotonick/hooks/blob/master/lib/hooks/instance_hooks.rb#L10
|
||||
# Middleman expects the same list of hooks for class and instance hooks:
|
||||
def _hooks
|
||||
self.class._hooks
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
|
|
|
@ -49,7 +49,7 @@ class Middleman::CoreExtensions::Compass < ::Middleman::Extension
|
|||
end
|
||||
|
||||
# Call hook
|
||||
app.run_hook :compass_config, ::Compass.configuration
|
||||
app.run_hook_for :compass_config, app, ::Compass.configuration
|
||||
|
||||
# Tell Tilt to use it as well (for inline sass blocks)
|
||||
::Tilt.register 'sass', CompassSassTemplate
|
||||
|
@ -73,4 +73,4 @@ class Middleman::CoreExtensions::Compass < ::Middleman::Extension
|
|||
super.merge(::Compass.configuration.to_sass_engine_options)
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
|
|
|
@ -77,11 +77,6 @@ module Hooks
|
|||
end
|
||||
|
||||
def define_hook_writer(name)
|
||||
self.send(:define_method, name.to_sym) do |&block|
|
||||
if self.class.respond_to?(name)
|
||||
self.class.send(name.to_sym, &block)
|
||||
end
|
||||
end
|
||||
instance_eval *hook_writer_args(name)
|
||||
end
|
||||
|
||||
|
|
Loading…
Reference in a new issue