kotovalexarian-likes-github
/
mini_racer
mirror of https://github.com/rubyjs/mini_racer
1
0
Fork 0
Code Releases Activity

use CXXFLAGS for C++ compiler 

A common mistake, the "CPP" in "CPPFLAGS" is for "C pre-processor"
and most of these options are intended for the (C++) compiler,
not the preprocessor.
This commit is contained in:
Sam Saffron 2021-12-30 11:38:48 +11:00
parent 8550bb33dc
commit 1bd82a9884
No known key found for this signature in database
GPG Key ID: B9606168D2FFD9F5
3 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Rakefile
View File

@ -92,5 +92,5 @@ task :lint do
portability-*
readability-*).join(',')
sh RbConfig::expand("clang-tidy -checks='#{checks}' ext/mini_racer_extension/mini_racer_extension.cc -- #$INCFLAGS #$CPPFLAGS", conf)
sh RbConfig::expand("clang-tidy -checks='#{checks}' ext/mini_racer_extension/mini_racer_extension.cc -- #$INCFLAGS #$CXXFLAGS", conf)
end

22
ext/mini_racer_extension/extconf.rb
View File

@ -7,19 +7,19 @@ IS_DARWIN = RUBY_PLATFORM =~ /darwin/
have_library('pthread')
have_library('objc') if IS_DARWIN
$CPPFLAGS += " -Wall" unless $CPPFLAGS.split.include? "-Wall"
$CPPFLAGS += " -g" unless $CPPFLAGS.split.include? "-g"
$CPPFLAGS += " -rdynamic" unless $CPPFLAGS.split.include? "-rdynamic"
$CPPFLAGS += " -fPIC" unless $CPPFLAGS.split.include? "-rdynamic" or IS_DARWIN
$CPPFLAGS += " -std=c++14"
$CPPFLAGS += " -fpermissive"
#$CPPFLAGS += " -DV8_COMPRESS_POINTERS"
$CPPFLAGS += " -fvisibility=hidden "
$CXXFLAGS += " -Wall" unless $CXXFLAGS.split.include? "-Wall"
$CXXFLAGS += " -g" unless $CXXFLAGS.split.include? "-g"
$CXXFLAGS += " -rdynamic" unless $CXXFLAGS.split.include? "-rdynamic"
$CXXFLAGS += " -fPIC" unless $CXXFLAGS.split.include? "-rdynamic" or IS_DARWIN
$CXXFLAGS += " -std=c++14"
$CXXFLAGS += " -fpermissive"
#$CXXFLAGS += " -DV8_COMPRESS_POINTERS"
$CXXFLAGS += " -fvisibility=hidden "
# __declspec gets used by clang via ruby 3.x headers...
$CPPFLAGS += " -fms-extensions"
$CXXFLAGS += " -fms-extensions"
$CPPFLAGS += " -Wno-reserved-user-defined-literal" if IS_DARWIN
$CXXFLAGS += " -Wno-reserved-user-defined-literal" if IS_DARWIN
$LDFLAGS.insert(0, " -stdlib=libc++ ") if IS_DARWIN
@ -67,7 +67,7 @@ end
Libv8::Node.configure_makefile
if enable_config('asan')
$CPPFLAGS.insert(0, " -fsanitize=address ")
$CXXFLAGS.insert(0, " -fsanitize=address ")
$LDFLAGS.insert(0, " -fsanitize=address ")
end

2
ext/mini_racer_loader/extconf.rb
View File

@ -3,6 +3,6 @@ require 'mkmf'
extension_name = 'mini_racer_loader'
dir_config extension_name
$CPPFLAGS += " -fvisibility=hidden "
$CXXFLAGS += " -fvisibility=hidden "
create_makefile extension_name