use CXXFLAGS for C++ compiler
A common mistake, the "CPP" in "CPPFLAGS" is for "C pre-processor" and most of these options are intended for the (C++) compiler, not the preprocessor.
This commit is contained in:
parent
8550bb33dc
commit
1bd82a9884
2
Rakefile
2
Rakefile
|
@ -92,5 +92,5 @@ task :lint do
|
||||||
portability-*
|
portability-*
|
||||||
readability-*).join(',')
|
readability-*).join(',')
|
||||||
|
|
||||||
sh RbConfig::expand("clang-tidy -checks='#{checks}' ext/mini_racer_extension/mini_racer_extension.cc -- #$INCFLAGS #$CPPFLAGS", conf)
|
sh RbConfig::expand("clang-tidy -checks='#{checks}' ext/mini_racer_extension/mini_racer_extension.cc -- #$INCFLAGS #$CXXFLAGS", conf)
|
||||||
end
|
end
|
||||||
|
|
|
@ -7,19 +7,19 @@ IS_DARWIN = RUBY_PLATFORM =~ /darwin/
|
||||||
|
|
||||||
have_library('pthread')
|
have_library('pthread')
|
||||||
have_library('objc') if IS_DARWIN
|
have_library('objc') if IS_DARWIN
|
||||||
$CPPFLAGS += " -Wall" unless $CPPFLAGS.split.include? "-Wall"
|
$CXXFLAGS += " -Wall" unless $CXXFLAGS.split.include? "-Wall"
|
||||||
$CPPFLAGS += " -g" unless $CPPFLAGS.split.include? "-g"
|
$CXXFLAGS += " -g" unless $CXXFLAGS.split.include? "-g"
|
||||||
$CPPFLAGS += " -rdynamic" unless $CPPFLAGS.split.include? "-rdynamic"
|
$CXXFLAGS += " -rdynamic" unless $CXXFLAGS.split.include? "-rdynamic"
|
||||||
$CPPFLAGS += " -fPIC" unless $CPPFLAGS.split.include? "-rdynamic" or IS_DARWIN
|
$CXXFLAGS += " -fPIC" unless $CXXFLAGS.split.include? "-rdynamic" or IS_DARWIN
|
||||||
$CPPFLAGS += " -std=c++14"
|
$CXXFLAGS += " -std=c++14"
|
||||||
$CPPFLAGS += " -fpermissive"
|
$CXXFLAGS += " -fpermissive"
|
||||||
#$CPPFLAGS += " -DV8_COMPRESS_POINTERS"
|
#$CXXFLAGS += " -DV8_COMPRESS_POINTERS"
|
||||||
$CPPFLAGS += " -fvisibility=hidden "
|
$CXXFLAGS += " -fvisibility=hidden "
|
||||||
|
|
||||||
# __declspec gets used by clang via ruby 3.x headers...
|
# __declspec gets used by clang via ruby 3.x headers...
|
||||||
$CPPFLAGS += " -fms-extensions"
|
$CXXFLAGS += " -fms-extensions"
|
||||||
|
|
||||||
$CPPFLAGS += " -Wno-reserved-user-defined-literal" if IS_DARWIN
|
$CXXFLAGS += " -Wno-reserved-user-defined-literal" if IS_DARWIN
|
||||||
|
|
||||||
$LDFLAGS.insert(0, " -stdlib=libc++ ") if IS_DARWIN
|
$LDFLAGS.insert(0, " -stdlib=libc++ ") if IS_DARWIN
|
||||||
|
|
||||||
|
@ -67,7 +67,7 @@ end
|
||||||
Libv8::Node.configure_makefile
|
Libv8::Node.configure_makefile
|
||||||
|
|
||||||
if enable_config('asan')
|
if enable_config('asan')
|
||||||
$CPPFLAGS.insert(0, " -fsanitize=address ")
|
$CXXFLAGS.insert(0, " -fsanitize=address ")
|
||||||
$LDFLAGS.insert(0, " -fsanitize=address ")
|
$LDFLAGS.insert(0, " -fsanitize=address ")
|
||||||
end
|
end
|
||||||
|
|
||||||
|
|
|
@ -3,6 +3,6 @@ require 'mkmf'
|
||||||
extension_name = 'mini_racer_loader'
|
extension_name = 'mini_racer_loader'
|
||||||
dir_config extension_name
|
dir_config extension_name
|
||||||
|
|
||||||
$CPPFLAGS += " -fvisibility=hidden "
|
$CXXFLAGS += " -fvisibility=hidden "
|
||||||
|
|
||||||
create_makefile extension_name
|
create_makefile extension_name
|
||||||
|
|
Loading…
Reference in New Issue