kotovalexarian-likes-github/mini_racer
1
0
Fork 0
mirror of https://github.com/rubyjs/mini_racer synced 2023-03-27 23:21:28 -04:00
Code Releases Activity

Remove use of non-maybe version of Message functions (#117)

Browse source 
* Remove use of non-maybe version of Message functions

* Check if GetLineNumber and GetStartColumn return meaningful data
This commit is contained in:
Petko Bordjukov 2019-04-15 06:03:05 +03:00 • committed by Sam
parent 723958f4da
commit 8e1b25128f
1 changed files with 13 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

16
ext/mini_racer_extension/mini_racer_extension.cc
View file

@ -263,11 +263,21 @@ static void prepare_result(MaybeLocal<Value> v8res,
evalRes.message = new Persistent<Value>();
Local<Message> message = trycatch.Message();
char buf[1000];
int len;
int len, line, column;
if (!message->GetLineNumber(context).To(&line)) {
line = 0;
}
if (!message->GetStartColumn(context).To(&column)) {
column = 0;
}
len = snprintf(buf, sizeof(buf), "%s at %s:%i:%i", *String::Utf8Value(isolate, message->Get()),
*String::Utf8Value(isolate, message->GetScriptResourceName()->ToString()),
message->GetLineNumber(),
message->GetStartColumn());
line,
column);
if ((size_t) len >= sizeof(buf)) {
len = sizeof(buf) - 1;
buf[len] = '\0';