2017-02-13 19:01:54 +00:00
|
|
|
#!/usr/bin/env bash
|
2015-01-30 19:45:02 +00:00
|
|
|
|
2022-08-26 14:08:14 +00:00
|
|
|
SCRIPTDIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
|
2016-10-12 19:25:49 +00:00
|
|
|
source "${SCRIPTDIR}/.validate"
|
2015-01-30 19:45:02 +00:00
|
|
|
|
|
|
|
|
IFS=$'\n'
|
2020-03-03 03:27:49 +00:00
|
|
|
files=($(validate_diff --diff-filter=ACMR --name-only -- 'MAINTAINERS' || true))
|
2015-01-30 19:45:02 +00:00
|
|
|
unset IFS
|
|
|
|
|
|
|
|
|
|
badFiles=()
|
|
|
|
|
for f in "${files[@]}"; do
|
2019-10-11 11:31:18 +00:00
|
|
|
# we use "git show" here to validate that what's committed has valid TOML syntax
|
validate/toml: switch to github.com/pelletier/go-toml
The github.com/BurntSushi/toml project is no longer maintained,
and containerd is switching to this project instead, so start
moving our code as well.
This patch only changes the binary used during validation (tbh,
we could probably remove this validation step, but leaving that
for now).
I manually verified that the hack/verify/toml still works by adding a commit
that makes the MAINTAINERS file invalid;
diff --git a/MAINTAINERS b/MAINTAINERS
index b739e7e20c..81ababd8de 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -23,7 +23,7 @@
# a subsystem, they are responsible for doing so and holding the
# subsystem maintainers accountable. If ownership is unclear, they are the de facto owners.
- people = [
+ people =
"akihirosuda",
"anusha",
"coolljt0725",
Running `hack/verify/toml` was able to detect the broken format;
hack/validate/toml
(27, 4): keys cannot contain , characterThese files are not valid TOML:
- MAINTAINERS
Please reformat the above files as valid TOML
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2021-04-02 14:02:34 +00:00
|
|
|
if ! git show "$VALIDATE_HEAD:$f" | tomll /proc/self/fd/0; then
|
2020-03-03 03:27:49 +00:00
|
|
|
badFiles+=("$f")
|
2015-01-30 19:45:02 +00:00
|
|
|
fi
|
|
|
|
|
done
|
|
|
|
|
|
2019-01-10 01:23:38 +00:00
|
|
|
if [ ${#badFiles[@]} -eq 0 ]; then
|
2019-10-11 11:31:18 +00:00
|
|
|
echo 'Congratulations! All TOML source files changed here have valid syntax.'
|
2015-01-30 19:45:02 +00:00
|
|
|
else
|
|
|
|
|
{
|
2019-10-11 11:31:18 +00:00
|
|
|
echo "These files are not valid TOML:"
|
2015-01-30 19:45:02 +00:00
|
|
|
for f in "${badFiles[@]}"; do
|
|
|
|
|
echo " - $f"
|
|
|
|
|
done
|
|
|
|
|
echo
|
2019-10-11 11:31:18 +00:00
|
|
|
echo 'Please reformat the above files as valid TOML'
|
2015-01-30 19:45:02 +00:00
|
|
|
echo
|
|
|
|
|
} >&2
|
|
|
|
|
false
|
|
|
|
|
fi
|