2017-02-13 14:01:54 -05:00
|
|
|
#!/usr/bin/env bash
|
2015-06-12 15:19:56 -04:00
|
|
|
set -e
|
|
|
|
|
2020-03-02 22:27:49 -05:00
|
|
|
export SCRIPTDIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
|
2016-10-12 15:25:49 -04:00
|
|
|
source "${SCRIPTDIR}/.validate"
|
2015-06-12 15:19:56 -04:00
|
|
|
|
|
|
|
IFS=$'\n'
|
2020-03-02 22:27:49 -05:00
|
|
|
files=($(validate_diff --diff-filter=ACMR --name-only -- 'pkg/*.go' || true))
|
2015-06-12 15:19:56 -04:00
|
|
|
unset IFS
|
|
|
|
|
|
|
|
badFiles=()
|
|
|
|
for f in "${files[@]}"; do
|
pkg/urlutil: deprecate, and move to builder/remotecontext/urlutil
pkg/urlutil (despite its poorly chosen name) is not really intended as a generic
utility to handle URLs, and should only be used by the builder to handle (remote)
build contexts.
- IsURL() only does a very rudimentary check for http(s):// prefixes, without any
other validation, but due to its name may give incorrect expectations.
- IsGitURL() is written specifically with docker build remote git contexts in
mind, and has handling for backward-compatibility, where strings that are
not URLs, but start with "github.com/" are accepted.
Because of the above, this patch:
- moves the package inside builder/remotecontext, close to where it's intended
to be used (ideally this would be part of build/remotecontext itself, but this
package imports many other dependencies, which would introduce those as extra
dependencies in the CLI).
- deprecates pkg/urlutil, but adds aliases as there are some external consumers.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-04-10 10:57:45 -04:00
|
|
|
if [ "$f" = "pkg/urlutil/deprecated.go" ]; then
|
|
|
|
# pkg/urlutil is deprecated, but has a temporary alias to help migration,
|
|
|
|
# see https://github.com/moby/moby/pull/43477
|
|
|
|
# TODO(thaJeztah) remove this exception once pkg/urlutil aliases are removed
|
|
|
|
continue
|
|
|
|
fi
|
2015-06-12 15:19:56 -04:00
|
|
|
IFS=$'\n'
|
2020-03-02 22:27:49 -05:00
|
|
|
badImports=($(go list -e -f '{{ join .Deps "\n" }}' "$f" | sort -u | grep -vE '^github.com/docker/docker/pkg/' | grep -vE '^github.com/docker/docker/vendor' | grep -E '^github.com/docker/docker' || true))
|
2015-06-12 15:19:56 -04:00
|
|
|
unset IFS
|
|
|
|
|
|
|
|
for import in "${badImports[@]}"; do
|
2020-03-02 22:27:49 -05:00
|
|
|
badFiles+=("$f imports $import")
|
2015-06-12 15:19:56 -04:00
|
|
|
done
|
|
|
|
done
|
|
|
|
|
2019-01-09 20:23:38 -05:00
|
|
|
if [ ${#badFiles[@]} -eq 0 ]; then
|
2019-10-11 07:31:18 -04:00
|
|
|
echo 'Congratulations! Packages in "./pkg/..." are safely isolated from internal code.'
|
2015-06-12 15:19:56 -04:00
|
|
|
else
|
|
|
|
{
|
|
|
|
echo 'These files import internal code: (either directly or indirectly)'
|
|
|
|
for f in "${badFiles[@]}"; do
|
|
|
|
echo " - $f"
|
|
|
|
done
|
|
|
|
echo
|
|
|
|
} >&2
|
|
|
|
false
|
|
|
|
fi
|