2015-08-29 22:43:33 -04:00
|
|
|
package main
|
|
|
|
|
|
|
|
import (
|
2017-04-10 21:58:31 -04:00
|
|
|
"fmt"
|
2015-08-29 22:43:33 -04:00
|
|
|
"net/http"
|
2017-01-17 02:55:45 -05:00
|
|
|
"time"
|
2015-08-29 22:43:33 -04:00
|
|
|
|
2017-04-10 21:58:31 -04:00
|
|
|
"github.com/docker/docker/api/types/container"
|
2016-12-30 12:23:00 -05:00
|
|
|
"github.com/docker/docker/integration-cli/checker"
|
2016-12-30 04:49:36 -05:00
|
|
|
"github.com/docker/docker/integration-cli/request"
|
2015-08-29 22:43:33 -04:00
|
|
|
"github.com/go-check/check"
|
|
|
|
)
|
|
|
|
|
[nit] integration-cli: obey Go's naming convention
No substantial code change.
- Api --> API
- Cli --> CLI
- Http, Https --> HTTP, HTTPS
- Id --> ID
- Uid,Gid,Pid --> UID,PID,PID
- Ipam --> IPAM
- Tls --> TLS (TestDaemonNoTlsCliTlsVerifyWithEnv --> TestDaemonTLSVerifyIssue13964)
Didn't touch in this commit:
- Git: because it is officially "Git": https://git-scm.com/
- Tar: because it is officially "Tar": https://www.gnu.org/software/tar/
- Cpu, Nat, Mac, Ipc, Shm: for keeping a consistency with existing production code (not changable, for compatibility)
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
2016-09-27 21:50:12 -04:00
|
|
|
func (s *DockerSuite) TestAPICreateWithNotExistImage(c *check.C) {
|
2015-08-29 22:43:33 -04:00
|
|
|
name := "test"
|
|
|
|
config := map[string]interface{}{
|
|
|
|
"Image": "test456:v1",
|
|
|
|
"Volumes": map[string]struct{}{"/tmp": {}},
|
|
|
|
}
|
|
|
|
|
2016-12-30 04:49:36 -05:00
|
|
|
status, body, err := request.SockRequest("POST", "/containers/create?name="+name, config, daemonHost())
|
2015-08-29 22:43:33 -04:00
|
|
|
c.Assert(err, check.IsNil)
|
|
|
|
c.Assert(status, check.Equals, http.StatusNotFound)
|
|
|
|
expected := "No such image: test456:v1"
|
2016-05-21 07:56:04 -04:00
|
|
|
c.Assert(getErrorMessage(c, body), checker.Contains, expected)
|
2015-08-29 22:43:33 -04:00
|
|
|
|
|
|
|
config2 := map[string]interface{}{
|
|
|
|
"Image": "test456",
|
|
|
|
"Volumes": map[string]struct{}{"/tmp": {}},
|
|
|
|
}
|
|
|
|
|
2016-12-30 04:49:36 -05:00
|
|
|
status, body, err = request.SockRequest("POST", "/containers/create?name="+name, config2, daemonHost())
|
2015-08-29 22:43:33 -04:00
|
|
|
c.Assert(err, check.IsNil)
|
|
|
|
c.Assert(status, check.Equals, http.StatusNotFound)
|
|
|
|
expected = "No such image: test456:latest"
|
2016-05-21 07:56:04 -04:00
|
|
|
c.Assert(getErrorMessage(c, body), checker.Equals, expected)
|
2015-08-29 22:43:33 -04:00
|
|
|
|
2016-01-25 14:45:20 -05:00
|
|
|
config3 := map[string]interface{}{
|
|
|
|
"Image": "sha256:0cb40641836c461bc97c793971d84d758371ed682042457523e4ae701efeaaaa",
|
|
|
|
}
|
|
|
|
|
2016-12-30 04:49:36 -05:00
|
|
|
status, body, err = request.SockRequest("POST", "/containers/create?name="+name, config3, daemonHost())
|
2016-01-25 14:45:20 -05:00
|
|
|
c.Assert(err, check.IsNil)
|
|
|
|
c.Assert(status, check.Equals, http.StatusNotFound)
|
|
|
|
expected = "No such image: sha256:0cb40641836c461bc97c793971d84d758371ed682042457523e4ae701efeaaaa"
|
2016-05-21 07:56:04 -04:00
|
|
|
c.Assert(getErrorMessage(c, body), checker.Equals, expected)
|
2016-01-25 14:45:20 -05:00
|
|
|
|
2015-08-29 22:43:33 -04:00
|
|
|
}
|
2016-11-05 14:53:54 -04:00
|
|
|
|
|
|
|
// Test for #25099
|
|
|
|
func (s *DockerSuite) TestAPICreateEmptyEnv(c *check.C) {
|
|
|
|
name := "test1"
|
|
|
|
config := map[string]interface{}{
|
|
|
|
"Image": "busybox",
|
|
|
|
"Env": []string{"", "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"},
|
|
|
|
"Cmd": []string{"true"},
|
|
|
|
}
|
|
|
|
|
2016-12-30 04:49:36 -05:00
|
|
|
status, body, err := request.SockRequest("POST", "/containers/create?name="+name, config, daemonHost())
|
2016-11-05 14:53:54 -04:00
|
|
|
c.Assert(err, check.IsNil)
|
|
|
|
c.Assert(status, check.Equals, http.StatusInternalServerError)
|
|
|
|
expected := "invalid environment variable:"
|
|
|
|
c.Assert(getErrorMessage(c, body), checker.Contains, expected)
|
|
|
|
|
|
|
|
name = "test2"
|
|
|
|
config = map[string]interface{}{
|
|
|
|
"Image": "busybox",
|
|
|
|
"Env": []string{"=", "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"},
|
|
|
|
"Cmd": []string{"true"},
|
|
|
|
}
|
2016-12-30 04:49:36 -05:00
|
|
|
status, body, err = request.SockRequest("POST", "/containers/create?name="+name, config, daemonHost())
|
2016-11-05 14:53:54 -04:00
|
|
|
c.Assert(err, check.IsNil)
|
|
|
|
c.Assert(status, check.Equals, http.StatusInternalServerError)
|
|
|
|
expected = "invalid environment variable: ="
|
|
|
|
c.Assert(getErrorMessage(c, body), checker.Contains, expected)
|
|
|
|
|
|
|
|
name = "test3"
|
|
|
|
config = map[string]interface{}{
|
|
|
|
"Image": "busybox",
|
|
|
|
"Env": []string{"=foo", "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"},
|
|
|
|
"Cmd": []string{"true"},
|
|
|
|
}
|
2016-12-30 04:49:36 -05:00
|
|
|
status, body, err = request.SockRequest("POST", "/containers/create?name="+name, config, daemonHost())
|
2016-11-05 14:53:54 -04:00
|
|
|
c.Assert(err, check.IsNil)
|
|
|
|
c.Assert(status, check.Equals, http.StatusInternalServerError)
|
|
|
|
expected = "invalid environment variable: =foo"
|
|
|
|
c.Assert(getErrorMessage(c, body), checker.Contains, expected)
|
|
|
|
}
|
2017-01-17 02:55:45 -05:00
|
|
|
|
|
|
|
func (s *DockerSuite) TestAPICreateWithInvalidHealthcheckParams(c *check.C) {
|
|
|
|
// test invalid Interval in Healthcheck: less than 0s
|
|
|
|
name := "test1"
|
|
|
|
config := map[string]interface{}{
|
|
|
|
"Image": "busybox",
|
|
|
|
"Healthcheck": map[string]interface{}{
|
2017-04-10 21:58:31 -04:00
|
|
|
"Interval": -10 * time.Millisecond,
|
|
|
|
"Timeout": time.Second,
|
2017-01-17 02:55:45 -05:00
|
|
|
"Retries": int(1000),
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
status, body, err := request.SockRequest("POST", "/containers/create?name="+name, config, daemonHost())
|
|
|
|
c.Assert(err, check.IsNil)
|
|
|
|
c.Assert(status, check.Equals, http.StatusInternalServerError)
|
2017-04-10 21:58:31 -04:00
|
|
|
expected := fmt.Sprintf("Interval in Healthcheck cannot be less than %s", container.MinimumDuration)
|
2017-01-17 02:55:45 -05:00
|
|
|
c.Assert(getErrorMessage(c, body), checker.Contains, expected)
|
|
|
|
|
2017-04-10 21:58:31 -04:00
|
|
|
// test invalid Interval in Healthcheck: larger than 0s but less than 1ms
|
2017-01-17 02:55:45 -05:00
|
|
|
name = "test2"
|
|
|
|
config = map[string]interface{}{
|
|
|
|
"Image": "busybox",
|
|
|
|
"Healthcheck": map[string]interface{}{
|
2017-04-10 21:58:31 -04:00
|
|
|
"Interval": 500 * time.Microsecond,
|
|
|
|
"Timeout": time.Second,
|
2017-01-17 02:55:45 -05:00
|
|
|
"Retries": int(1000),
|
|
|
|
},
|
|
|
|
}
|
|
|
|
status, body, err = request.SockRequest("POST", "/containers/create?name="+name, config, daemonHost())
|
|
|
|
c.Assert(err, check.IsNil)
|
|
|
|
c.Assert(status, check.Equals, http.StatusInternalServerError)
|
|
|
|
c.Assert(getErrorMessage(c, body), checker.Contains, expected)
|
|
|
|
|
2017-04-10 21:58:31 -04:00
|
|
|
// test invalid Timeout in Healthcheck: less than 1ms
|
2017-01-17 02:55:45 -05:00
|
|
|
name = "test3"
|
|
|
|
config = map[string]interface{}{
|
|
|
|
"Image": "busybox",
|
|
|
|
"Healthcheck": map[string]interface{}{
|
2017-04-10 21:58:31 -04:00
|
|
|
"Interval": time.Second,
|
|
|
|
"Timeout": -100 * time.Millisecond,
|
2017-01-17 02:55:45 -05:00
|
|
|
"Retries": int(1000),
|
|
|
|
},
|
|
|
|
}
|
|
|
|
status, body, err = request.SockRequest("POST", "/containers/create?name="+name, config, daemonHost())
|
|
|
|
c.Assert(err, check.IsNil)
|
|
|
|
c.Assert(status, check.Equals, http.StatusInternalServerError)
|
2017-04-10 21:58:31 -04:00
|
|
|
expected = fmt.Sprintf("Timeout in Healthcheck cannot be less than %s", container.MinimumDuration)
|
2017-01-17 02:55:45 -05:00
|
|
|
c.Assert(getErrorMessage(c, body), checker.Contains, expected)
|
|
|
|
|
|
|
|
// test invalid Retries in Healthcheck: less than 0
|
|
|
|
name = "test4"
|
|
|
|
config = map[string]interface{}{
|
|
|
|
"Image": "busybox",
|
|
|
|
"Healthcheck": map[string]interface{}{
|
2017-04-10 21:58:31 -04:00
|
|
|
"Interval": time.Second,
|
|
|
|
"Timeout": time.Second,
|
2017-01-17 02:55:45 -05:00
|
|
|
"Retries": int(-10),
|
|
|
|
},
|
|
|
|
}
|
|
|
|
status, body, err = request.SockRequest("POST", "/containers/create?name="+name, config, daemonHost())
|
|
|
|
c.Assert(err, check.IsNil)
|
|
|
|
c.Assert(status, check.Equals, http.StatusInternalServerError)
|
|
|
|
expected = "Retries in Healthcheck cannot be negative"
|
|
|
|
c.Assert(getErrorMessage(c, body), checker.Contains, expected)
|
2017-04-10 21:58:31 -04:00
|
|
|
|
|
|
|
// test invalid StartPeriod in Healthcheck: not 0 and less than 1ms
|
|
|
|
name = "test3"
|
|
|
|
config = map[string]interface{}{
|
|
|
|
"Image": "busybox",
|
|
|
|
"Healthcheck": map[string]interface{}{
|
|
|
|
"Interval": time.Second,
|
|
|
|
"Timeout": time.Second,
|
|
|
|
"Retries": int(1000),
|
|
|
|
"StartPeriod": 100 * time.Microsecond,
|
|
|
|
},
|
|
|
|
}
|
|
|
|
status, body, err = request.SockRequest("POST", "/containers/create?name="+name, config, daemonHost())
|
|
|
|
c.Assert(err, check.IsNil)
|
|
|
|
c.Assert(status, check.Equals, http.StatusInternalServerError)
|
|
|
|
expected = fmt.Sprintf("StartPeriod in Healthcheck cannot be less than %s", container.MinimumDuration)
|
|
|
|
c.Assert(getErrorMessage(c, body), checker.Contains, expected)
|
2017-01-17 02:55:45 -05:00
|
|
|
}
|