2021-08-23 09:14:53 -04:00
|
|
|
//go:build windows
|
2015-02-17 15:27:07 -05:00
|
|
|
// +build windows
|
|
|
|
|
2018-02-05 16:05:59 -05:00
|
|
|
package archive // import "github.com/docker/docker/pkg/archive"
|
2015-02-17 15:27:07 -05:00
|
|
|
|
|
|
|
import (
|
2015-03-03 21:40:16 -05:00
|
|
|
"os"
|
2015-10-14 19:25:03 -04:00
|
|
|
"path/filepath"
|
2015-02-17 15:27:07 -05:00
|
|
|
"testing"
|
|
|
|
)
|
|
|
|
|
2015-10-14 19:25:03 -04:00
|
|
|
func TestCopyFileWithInvalidDest(t *testing.T) {
|
2016-02-12 16:58:57 -05:00
|
|
|
// TODO Windows: This is currently failing. Not sure what has
|
|
|
|
// recently changed in CopyWithTar as used to pass. Further investigation
|
|
|
|
// is required.
|
|
|
|
t.Skip("Currently fails")
|
2021-08-24 06:10:50 -04:00
|
|
|
folder, err := os.MkdirTemp("", "docker-archive-test")
|
2015-10-14 19:25:03 -04:00
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
defer os.RemoveAll(folder)
|
|
|
|
dest := "c:dest"
|
|
|
|
srcFolder := filepath.Join(folder, "src")
|
|
|
|
src := filepath.Join(folder, "src", "src")
|
|
|
|
err = os.MkdirAll(srcFolder, 0740)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
2021-08-24 06:10:50 -04:00
|
|
|
os.WriteFile(src, []byte("content"), 0777)
|
2017-05-24 11:53:41 -04:00
|
|
|
err = defaultCopyWithTar(src, dest)
|
2015-10-14 19:25:03 -04:00
|
|
|
if err == nil {
|
|
|
|
t.Fatalf("archiver.CopyWithTar should throw an error on invalid dest.")
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-02-17 15:27:07 -05:00
|
|
|
func TestCanonicalTarName(t *testing.T) {
|
|
|
|
cases := []struct {
|
|
|
|
in string
|
|
|
|
isDir bool
|
|
|
|
expected string
|
|
|
|
}{
|
|
|
|
{"foo", false, "foo"},
|
|
|
|
{"foo", true, "foo/"},
|
|
|
|
{`foo\bar`, false, "foo/bar"},
|
|
|
|
{`foo\bar`, true, "foo/bar/"},
|
|
|
|
}
|
|
|
|
for _, v := range cases {
|
2018-06-27 15:07:17 -04:00
|
|
|
if canonicalTarName(v.in, v.isDir) != v.expected {
|
|
|
|
t.Fatalf("wrong canonical tar name. expected:%s got:%s", v.expected, canonicalTarName(v.in, v.isDir))
|
2015-02-17 15:27:07 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2015-03-03 21:40:16 -05:00
|
|
|
|
|
|
|
func TestChmodTarEntry(t *testing.T) {
|
|
|
|
cases := []struct {
|
|
|
|
in, expected os.FileMode
|
|
|
|
}{
|
2015-03-15 13:19:15 -04:00
|
|
|
{0000, 0111},
|
pkg/archive: strip "write" bits again on Windows
1. Commit 1a22418f9f1573ca8521831d52c8e0562cb3ef8f changed permissions to `0700`
on Windows, or more factually, it removed `rw` (`chmod g-rw,o-rw`) and added
executable bits (`chmod u+x`).
2. This was too restrictive, and b7dc9040f04fe8dacd2f14c6b93d1b0bb6bde333 changed
permissions to only remove the group- and world-writable bits to give read and
execute access to everyone, but setting execute permissions for everyone.
3. However, this also removed the non-permission bits, so 41eb61d5c2a44c745b11ada948034fd3bcc42db5
updated the code to preserve those, and keep parity with Linux.
This changes it back to `2.`. I wonder (_think_) _permission_ bits (read, write)
can be portable, except for the _executable_ bit (which is not present on Windows).
The alternative could be to keep the permission bits, and only set the executable
bit (`perm | 0111`) for everyone (equivalent of `chmod +x`), but that likely would
be a breaking change.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-09-05 04:50:10 -04:00
|
|
|
{0777, 0755},
|
2015-03-15 13:19:15 -04:00
|
|
|
{0644, 0755},
|
|
|
|
{0755, 0755},
|
|
|
|
{0444, 0555},
|
2015-03-03 21:40:16 -05:00
|
|
|
}
|
|
|
|
for _, v := range cases {
|
|
|
|
if out := chmodTarEntry(v.in); out != v.expected {
|
|
|
|
t.Fatalf("wrong chmod. expected:%v got:%v", v.expected, out)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|