2015-11-18 17:18:44 -05:00
|
|
|
package distribution
|
|
|
|
|
|
|
|
import (
|
|
|
|
"encoding/json"
|
|
|
|
"errors"
|
|
|
|
"fmt"
|
|
|
|
"io"
|
|
|
|
"io/ioutil"
|
|
|
|
"os"
|
|
|
|
"runtime"
|
|
|
|
|
|
|
|
"github.com/Sirupsen/logrus"
|
|
|
|
"github.com/docker/distribution"
|
|
|
|
"github.com/docker/distribution/digest"
|
|
|
|
"github.com/docker/distribution/manifest/schema1"
|
2015-12-21 18:42:04 -05:00
|
|
|
"github.com/docker/distribution/registry/api/errcode"
|
2015-11-18 17:18:44 -05:00
|
|
|
"github.com/docker/docker/distribution/metadata"
|
2015-11-13 19:59:01 -05:00
|
|
|
"github.com/docker/docker/distribution/xfer"
|
2015-11-18 17:18:44 -05:00
|
|
|
"github.com/docker/docker/image"
|
|
|
|
"github.com/docker/docker/image/v1"
|
|
|
|
"github.com/docker/docker/layer"
|
2015-11-13 19:59:01 -05:00
|
|
|
"github.com/docker/docker/pkg/ioutils"
|
|
|
|
"github.com/docker/docker/pkg/progress"
|
2015-11-18 17:18:44 -05:00
|
|
|
"github.com/docker/docker/pkg/stringid"
|
2015-12-04 16:55:15 -05:00
|
|
|
"github.com/docker/docker/reference"
|
2015-11-18 17:18:44 -05:00
|
|
|
"github.com/docker/docker/registry"
|
|
|
|
"golang.org/x/net/context"
|
|
|
|
)
|
|
|
|
|
|
|
|
type v2Puller struct {
|
|
|
|
blobSumService *metadata.BlobSumService
|
|
|
|
endpoint registry.APIEndpoint
|
|
|
|
config *ImagePullConfig
|
|
|
|
repoInfo *registry.RepositoryInfo
|
|
|
|
repo distribution.Repository
|
2015-12-04 16:42:33 -05:00
|
|
|
// confirmedV2 is set to true if we confirm we're talking to a v2
|
|
|
|
// registry. This is used to limit fallbacks to the v1 protocol.
|
|
|
|
confirmedV2 bool
|
2015-11-18 17:18:44 -05:00
|
|
|
}
|
|
|
|
|
2015-12-04 16:42:33 -05:00
|
|
|
func (p *v2Puller) Pull(ctx context.Context, ref reference.Named) (err error) {
|
2015-11-18 17:18:44 -05:00
|
|
|
// TODO(tiborvass): was ReceiveTimeout
|
2015-12-04 16:42:33 -05:00
|
|
|
p.repo, p.confirmedV2, err = NewV2Repository(ctx, p.repoInfo, p.endpoint, p.config.MetaHeaders, p.config.AuthConfig, "pull")
|
2015-11-18 17:18:44 -05:00
|
|
|
if err != nil {
|
2015-11-13 19:59:01 -05:00
|
|
|
logrus.Warnf("Error getting v2 registry: %v", err)
|
2015-12-04 16:42:33 -05:00
|
|
|
return fallbackError{err: err, confirmedV2: p.confirmedV2}
|
2015-11-18 17:18:44 -05:00
|
|
|
}
|
|
|
|
|
2015-12-04 16:42:33 -05:00
|
|
|
if err = p.pullV2Repository(ctx, ref); err != nil {
|
2015-11-18 17:18:44 -05:00
|
|
|
if registry.ContinueOnError(err) {
|
|
|
|
logrus.Debugf("Error trying v2 registry: %v", err)
|
2015-12-04 16:42:33 -05:00
|
|
|
return fallbackError{err: err, confirmedV2: p.confirmedV2}
|
2015-11-18 17:18:44 -05:00
|
|
|
}
|
|
|
|
}
|
2015-12-04 16:42:33 -05:00
|
|
|
return err
|
2015-11-18 17:18:44 -05:00
|
|
|
}
|
|
|
|
|
2015-11-13 19:59:01 -05:00
|
|
|
func (p *v2Puller) pullV2Repository(ctx context.Context, ref reference.Named) (err error) {
|
2015-11-18 17:18:44 -05:00
|
|
|
var refs []reference.Named
|
2015-12-10 14:01:34 -05:00
|
|
|
if !reference.IsNameOnly(ref) {
|
2015-12-11 14:00:13 -05:00
|
|
|
refs = []reference.Named{ref}
|
2015-11-18 17:18:44 -05:00
|
|
|
} else {
|
2015-11-13 19:59:01 -05:00
|
|
|
manSvc, err := p.repo.Manifests(ctx)
|
2015-11-18 17:18:44 -05:00
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
tags, err := manSvc.Tags()
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
2015-12-04 16:42:33 -05:00
|
|
|
// If this call succeeded, we can be confident that the
|
|
|
|
// registry on the other side speaks the v2 protocol.
|
|
|
|
p.confirmedV2 = true
|
|
|
|
|
2015-11-18 17:18:44 -05:00
|
|
|
// This probably becomes a lot nicer after the manifest
|
|
|
|
// refactor...
|
|
|
|
for _, tag := range tags {
|
2015-12-11 14:00:13 -05:00
|
|
|
tagRef, err := reference.WithTag(ref, tag)
|
2015-11-18 17:18:44 -05:00
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
refs = append(refs, tagRef)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
var layersDownloaded bool
|
|
|
|
for _, pullRef := range refs {
|
|
|
|
// pulledNew is true if either new layers were downloaded OR if existing images were newly tagged
|
|
|
|
// TODO(tiborvass): should we change the name of `layersDownload`? What about message in WriteStatus?
|
2015-11-13 19:59:01 -05:00
|
|
|
pulledNew, err := p.pullV2Tag(ctx, pullRef)
|
2015-11-18 17:18:44 -05:00
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
layersDownloaded = layersDownloaded || pulledNew
|
|
|
|
}
|
|
|
|
|
2015-12-10 14:01:34 -05:00
|
|
|
writeStatus(ref.String(), p.config.ProgressOutput, layersDownloaded)
|
2015-11-18 17:18:44 -05:00
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2015-11-13 19:59:01 -05:00
|
|
|
type v2LayerDescriptor struct {
|
|
|
|
digest digest.Digest
|
|
|
|
repo distribution.Repository
|
|
|
|
blobSumService *metadata.BlobSumService
|
2015-11-18 17:18:44 -05:00
|
|
|
}
|
|
|
|
|
2015-11-13 19:59:01 -05:00
|
|
|
func (ld *v2LayerDescriptor) Key() string {
|
|
|
|
return "v2:" + ld.digest.String()
|
|
|
|
}
|
2015-11-18 17:18:44 -05:00
|
|
|
|
2015-11-13 19:59:01 -05:00
|
|
|
func (ld *v2LayerDescriptor) ID() string {
|
|
|
|
return stringid.TruncateID(ld.digest.String())
|
|
|
|
}
|
2015-11-18 17:18:44 -05:00
|
|
|
|
2015-11-13 19:59:01 -05:00
|
|
|
func (ld *v2LayerDescriptor) DiffID() (layer.DiffID, error) {
|
|
|
|
return ld.blobSumService.GetDiffID(ld.digest)
|
|
|
|
}
|
|
|
|
|
|
|
|
func (ld *v2LayerDescriptor) Download(ctx context.Context, progressOutput progress.Output) (io.ReadCloser, int64, error) {
|
|
|
|
logrus.Debugf("pulling blob %q", ld.digest)
|
2015-11-18 17:18:44 -05:00
|
|
|
|
2015-11-13 19:59:01 -05:00
|
|
|
blobs := ld.repo.Blobs(ctx)
|
2015-11-18 17:18:44 -05:00
|
|
|
|
2015-11-13 19:59:01 -05:00
|
|
|
layerDownload, err := blobs.Open(ctx, ld.digest)
|
2015-11-18 17:18:44 -05:00
|
|
|
if err != nil {
|
2015-11-13 19:59:01 -05:00
|
|
|
logrus.Debugf("Error statting layer: %v", err)
|
|
|
|
if err == distribution.ErrBlobUnknown {
|
|
|
|
return nil, 0, xfer.DoNotRetry{Err: err}
|
|
|
|
}
|
|
|
|
return nil, 0, retryOnError(err)
|
2015-11-18 17:18:44 -05:00
|
|
|
}
|
|
|
|
|
2015-11-13 19:59:01 -05:00
|
|
|
size, err := layerDownload.Seek(0, os.SEEK_END)
|
2015-12-03 21:23:21 -05:00
|
|
|
if err != nil {
|
|
|
|
// Seek failed, perhaps because there was no Content-Length
|
|
|
|
// header. This shouldn't fail the download, because we can
|
|
|
|
// still continue without a progress bar.
|
2015-11-13 19:59:01 -05:00
|
|
|
size = 0
|
2015-12-03 21:23:21 -05:00
|
|
|
} else {
|
|
|
|
// Restore the seek offset at the beginning of the stream.
|
|
|
|
_, err = layerDownload.Seek(0, os.SEEK_SET)
|
|
|
|
if err != nil {
|
2015-11-13 19:59:01 -05:00
|
|
|
return nil, 0, err
|
2015-12-03 21:23:21 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-11-13 19:59:01 -05:00
|
|
|
reader := progress.NewProgressReader(ioutils.NewCancelReadCloser(ctx, layerDownload), progressOutput, size, ld.ID(), "Downloading")
|
|
|
|
defer reader.Close()
|
|
|
|
|
|
|
|
verifier, err := digest.NewDigestVerifier(ld.digest)
|
2015-11-18 17:18:44 -05:00
|
|
|
if err != nil {
|
2015-11-13 19:59:01 -05:00
|
|
|
return nil, 0, xfer.DoNotRetry{Err: err}
|
2015-11-18 17:18:44 -05:00
|
|
|
}
|
|
|
|
|
2015-11-13 19:59:01 -05:00
|
|
|
tmpFile, err := ioutil.TempFile("", "GetImageBlob")
|
|
|
|
if err != nil {
|
|
|
|
return nil, 0, xfer.DoNotRetry{Err: err}
|
|
|
|
}
|
2015-11-18 17:18:44 -05:00
|
|
|
|
2015-11-13 19:59:01 -05:00
|
|
|
_, err = io.Copy(tmpFile, io.TeeReader(reader, verifier))
|
|
|
|
if err != nil {
|
|
|
|
return nil, 0, retryOnError(err)
|
|
|
|
}
|
2015-11-18 17:18:44 -05:00
|
|
|
|
2015-11-13 19:59:01 -05:00
|
|
|
progress.Update(progressOutput, ld.ID(), "Verifying Checksum")
|
2015-11-18 17:18:44 -05:00
|
|
|
|
|
|
|
if !verifier.Verified() {
|
2015-11-13 19:59:01 -05:00
|
|
|
err = fmt.Errorf("filesystem layer verification failed for digest %s", ld.digest)
|
2015-11-18 17:18:44 -05:00
|
|
|
logrus.Error(err)
|
2015-11-13 19:59:01 -05:00
|
|
|
tmpFile.Close()
|
|
|
|
if err := os.RemoveAll(tmpFile.Name()); err != nil {
|
|
|
|
logrus.Errorf("Failed to remove temp file: %s", tmpFile.Name())
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil, 0, xfer.DoNotRetry{Err: err}
|
2015-11-18 17:18:44 -05:00
|
|
|
}
|
|
|
|
|
2015-11-13 19:59:01 -05:00
|
|
|
progress.Update(progressOutput, ld.ID(), "Download complete")
|
2015-11-18 17:18:44 -05:00
|
|
|
|
2015-11-13 19:59:01 -05:00
|
|
|
logrus.Debugf("Downloaded %s to tempfile %s", ld.ID(), tmpFile.Name())
|
|
|
|
|
|
|
|
tmpFile.Seek(0, 0)
|
|
|
|
return ioutils.NewReadCloserWrapper(tmpFile, tmpFileCloser(tmpFile)), size, nil
|
|
|
|
}
|
2015-11-18 17:18:44 -05:00
|
|
|
|
2015-11-13 19:59:01 -05:00
|
|
|
func (ld *v2LayerDescriptor) Registered(diffID layer.DiffID) {
|
|
|
|
// Cache mapping from this layer's DiffID to the blobsum
|
|
|
|
ld.blobSumService.Add(diffID, ld.digest)
|
2015-11-18 17:18:44 -05:00
|
|
|
}
|
|
|
|
|
2015-11-13 19:59:01 -05:00
|
|
|
func (p *v2Puller) pullV2Tag(ctx context.Context, ref reference.Named) (tagUpdated bool, err error) {
|
2015-11-18 17:18:44 -05:00
|
|
|
tagOrDigest := ""
|
2015-12-04 16:55:15 -05:00
|
|
|
if tagged, isTagged := ref.(reference.NamedTagged); isTagged {
|
2015-11-18 17:18:44 -05:00
|
|
|
tagOrDigest = tagged.Tag()
|
2015-12-04 16:55:15 -05:00
|
|
|
} else if digested, isCanonical := ref.(reference.Canonical); isCanonical {
|
2015-11-18 17:18:44 -05:00
|
|
|
tagOrDigest = digested.Digest().String()
|
|
|
|
} else {
|
|
|
|
return false, fmt.Errorf("internal error: reference has neither a tag nor a digest: %s", ref.String())
|
|
|
|
}
|
|
|
|
|
|
|
|
logrus.Debugf("Pulling ref from V2 registry: %q", tagOrDigest)
|
|
|
|
|
2015-11-13 19:59:01 -05:00
|
|
|
manSvc, err := p.repo.Manifests(ctx)
|
2015-11-18 17:18:44 -05:00
|
|
|
if err != nil {
|
|
|
|
return false, err
|
|
|
|
}
|
|
|
|
|
|
|
|
unverifiedManifest, err := manSvc.GetByTag(tagOrDigest)
|
|
|
|
if err != nil {
|
2015-12-21 18:42:04 -05:00
|
|
|
// If this manifest did not exist, we should allow a possible
|
|
|
|
// fallback to the v1 protocol, because dual-version setups may
|
|
|
|
// not host all manifests with the v2 protocol. We may also get
|
|
|
|
// a "not authorized" error if the manifest doesn't exist.
|
|
|
|
switch v := err.(type) {
|
|
|
|
case errcode.Errors:
|
|
|
|
if len(v) != 0 {
|
|
|
|
if v0, ok := v[0].(errcode.Error); ok && registry.ShouldV2Fallback(v0) {
|
|
|
|
p.confirmedV2 = false
|
|
|
|
}
|
|
|
|
}
|
|
|
|
case errcode.Error:
|
|
|
|
if registry.ShouldV2Fallback(v) {
|
|
|
|
p.confirmedV2 = false
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-11-18 17:18:44 -05:00
|
|
|
return false, err
|
|
|
|
}
|
|
|
|
if unverifiedManifest == nil {
|
|
|
|
return false, fmt.Errorf("image manifest does not exist for tag or digest %q", tagOrDigest)
|
|
|
|
}
|
2015-12-04 16:42:33 -05:00
|
|
|
|
|
|
|
// If GetByTag succeeded, we can be confident that the registry on
|
|
|
|
// the other side speaks the v2 protocol.
|
|
|
|
p.confirmedV2 = true
|
|
|
|
|
2015-11-18 17:18:44 -05:00
|
|
|
var verifiedManifest *schema1.Manifest
|
|
|
|
verifiedManifest, err = verifyManifest(unverifiedManifest, ref)
|
|
|
|
if err != nil {
|
|
|
|
return false, err
|
|
|
|
}
|
|
|
|
|
|
|
|
rootFS := image.NewRootFS()
|
|
|
|
|
|
|
|
if err := detectBaseLayer(p.config.ImageStore, verifiedManifest, rootFS); err != nil {
|
|
|
|
return false, err
|
|
|
|
}
|
|
|
|
|
|
|
|
// remove duplicate layers and check parent chain validity
|
|
|
|
err = fixManifestLayers(verifiedManifest)
|
|
|
|
if err != nil {
|
|
|
|
return false, err
|
|
|
|
}
|
|
|
|
|
2015-11-13 19:59:01 -05:00
|
|
|
progress.Message(p.config.ProgressOutput, tagOrDigest, "Pulling from "+p.repo.Name())
|
2015-11-18 17:18:44 -05:00
|
|
|
|
2015-11-13 19:59:01 -05:00
|
|
|
var descriptors []xfer.DownloadDescriptor
|
2015-11-18 17:18:44 -05:00
|
|
|
|
|
|
|
// Image history converted to the new format
|
|
|
|
var history []image.History
|
|
|
|
|
|
|
|
// Note that the order of this loop is in the direction of bottom-most
|
|
|
|
// to top-most, so that the downloads slice gets ordered correctly.
|
|
|
|
for i := len(verifiedManifest.FSLayers) - 1; i >= 0; i-- {
|
|
|
|
blobSum := verifiedManifest.FSLayers[i].BlobSum
|
|
|
|
|
|
|
|
var throwAway struct {
|
|
|
|
ThrowAway bool `json:"throwaway,omitempty"`
|
|
|
|
}
|
|
|
|
if err := json.Unmarshal([]byte(verifiedManifest.History[i].V1Compatibility), &throwAway); err != nil {
|
|
|
|
return false, err
|
|
|
|
}
|
|
|
|
|
|
|
|
h, err := v1.HistoryFromConfig([]byte(verifiedManifest.History[i].V1Compatibility), throwAway.ThrowAway)
|
|
|
|
if err != nil {
|
|
|
|
return false, err
|
|
|
|
}
|
|
|
|
history = append(history, h)
|
|
|
|
|
|
|
|
if throwAway.ThrowAway {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
2015-11-13 19:59:01 -05:00
|
|
|
layerDescriptor := &v2LayerDescriptor{
|
|
|
|
digest: blobSum,
|
|
|
|
repo: p.repo,
|
|
|
|
blobSumService: p.blobSumService,
|
2015-11-18 17:18:44 -05:00
|
|
|
}
|
|
|
|
|
2015-11-13 19:59:01 -05:00
|
|
|
descriptors = append(descriptors, layerDescriptor)
|
2015-11-18 17:18:44 -05:00
|
|
|
}
|
|
|
|
|
2015-11-13 19:59:01 -05:00
|
|
|
resultRootFS, release, err := p.config.DownloadManager.Download(ctx, *rootFS, descriptors, p.config.ProgressOutput)
|
|
|
|
if err != nil {
|
|
|
|
return false, err
|
2015-11-18 17:18:44 -05:00
|
|
|
}
|
2015-11-13 19:59:01 -05:00
|
|
|
defer release()
|
2015-11-18 17:18:44 -05:00
|
|
|
|
2015-11-13 19:59:01 -05:00
|
|
|
config, err := v1.MakeConfigFromV1Config([]byte(verifiedManifest.History[0].V1Compatibility), &resultRootFS, history)
|
2015-11-18 17:18:44 -05:00
|
|
|
if err != nil {
|
|
|
|
return false, err
|
|
|
|
}
|
|
|
|
|
|
|
|
imageID, err := p.config.ImageStore.Create(config)
|
|
|
|
if err != nil {
|
|
|
|
return false, err
|
|
|
|
}
|
|
|
|
|
2015-12-11 14:00:13 -05:00
|
|
|
manifestDigest, _, err := digestFromManifest(unverifiedManifest, p.repoInfo)
|
2015-11-18 17:18:44 -05:00
|
|
|
if err != nil {
|
|
|
|
return false, err
|
|
|
|
}
|
|
|
|
|
2015-11-13 19:59:01 -05:00
|
|
|
if manifestDigest != "" {
|
|
|
|
progress.Message(p.config.ProgressOutput, "", "Digest: "+manifestDigest.String())
|
2015-11-18 17:18:44 -05:00
|
|
|
}
|
|
|
|
|
2015-12-04 16:55:15 -05:00
|
|
|
oldTagImageID, err := p.config.ReferenceStore.Get(ref)
|
2015-11-13 19:59:01 -05:00
|
|
|
if err == nil && oldTagImageID == imageID {
|
|
|
|
return false, nil
|
2015-11-18 17:18:44 -05:00
|
|
|
}
|
|
|
|
|
2015-11-13 19:59:01 -05:00
|
|
|
if canonical, ok := ref.(reference.Canonical); ok {
|
2015-12-04 16:55:15 -05:00
|
|
|
if err = p.config.ReferenceStore.AddDigest(canonical, imageID, true); err != nil {
|
2015-11-13 19:59:01 -05:00
|
|
|
return false, err
|
|
|
|
}
|
2015-12-04 16:55:15 -05:00
|
|
|
} else if err = p.config.ReferenceStore.AddTag(ref, imageID, true); err != nil {
|
2015-11-13 19:59:01 -05:00
|
|
|
return false, err
|
2015-11-18 17:18:44 -05:00
|
|
|
}
|
|
|
|
|
2015-11-13 19:59:01 -05:00
|
|
|
return true, nil
|
2015-11-18 17:18:44 -05:00
|
|
|
}
|
|
|
|
|
2015-12-04 16:55:15 -05:00
|
|
|
func verifyManifest(signedManifest *schema1.SignedManifest, ref reference.Named) (m *schema1.Manifest, err error) {
|
2015-11-18 17:18:44 -05:00
|
|
|
// If pull by digest, then verify the manifest digest. NOTE: It is
|
|
|
|
// important to do this first, before any other content validation. If the
|
|
|
|
// digest cannot be verified, don't even bother with those other things.
|
2015-12-04 16:55:15 -05:00
|
|
|
if digested, isCanonical := ref.(reference.Canonical); isCanonical {
|
2015-11-18 17:18:44 -05:00
|
|
|
verifier, err := digest.NewDigestVerifier(digested.Digest())
|
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
payload, err := signedManifest.Payload()
|
|
|
|
if err != nil {
|
|
|
|
// If this failed, the signatures section was corrupted
|
|
|
|
// or missing. Treat the entire manifest as the payload.
|
|
|
|
payload = signedManifest.Raw
|
|
|
|
}
|
|
|
|
if _, err := verifier.Write(payload); err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
if !verifier.Verified() {
|
|
|
|
err := fmt.Errorf("image verification failed for digest %s", digested.Digest())
|
|
|
|
logrus.Error(err)
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
|
|
|
|
var verifiedManifest schema1.Manifest
|
|
|
|
if err = json.Unmarshal(payload, &verifiedManifest); err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
m = &verifiedManifest
|
|
|
|
} else {
|
|
|
|
m = &signedManifest.Manifest
|
|
|
|
}
|
|
|
|
|
|
|
|
if m.SchemaVersion != 1 {
|
|
|
|
return nil, fmt.Errorf("unsupported schema version %d for %q", m.SchemaVersion, ref.String())
|
|
|
|
}
|
|
|
|
if len(m.FSLayers) != len(m.History) {
|
|
|
|
return nil, fmt.Errorf("length of history not equal to number of layers for %q", ref.String())
|
|
|
|
}
|
|
|
|
if len(m.FSLayers) == 0 {
|
|
|
|
return nil, fmt.Errorf("no FSLayers in manifest for %q", ref.String())
|
|
|
|
}
|
|
|
|
return m, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// fixManifestLayers removes repeated layers from the manifest and checks the
|
|
|
|
// correctness of the parent chain.
|
|
|
|
func fixManifestLayers(m *schema1.Manifest) error {
|
|
|
|
imgs := make([]*image.V1Image, len(m.FSLayers))
|
|
|
|
for i := range m.FSLayers {
|
|
|
|
img := &image.V1Image{}
|
|
|
|
|
|
|
|
if err := json.Unmarshal([]byte(m.History[i].V1Compatibility), img); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
imgs[i] = img
|
|
|
|
if err := v1.ValidateID(img.ID); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if imgs[len(imgs)-1].Parent != "" && runtime.GOOS != "windows" {
|
|
|
|
// Windows base layer can point to a base layer parent that is not in manifest.
|
|
|
|
return errors.New("Invalid parent ID in the base layer of the image.")
|
|
|
|
}
|
|
|
|
|
|
|
|
// check general duplicates to error instead of a deadlock
|
|
|
|
idmap := make(map[string]struct{})
|
|
|
|
|
|
|
|
var lastID string
|
|
|
|
for _, img := range imgs {
|
|
|
|
// skip IDs that appear after each other, we handle those later
|
|
|
|
if _, exists := idmap[img.ID]; img.ID != lastID && exists {
|
|
|
|
return fmt.Errorf("ID %+v appears multiple times in manifest", img.ID)
|
|
|
|
}
|
|
|
|
lastID = img.ID
|
|
|
|
idmap[lastID] = struct{}{}
|
|
|
|
}
|
|
|
|
|
|
|
|
// backwards loop so that we keep the remaining indexes after removing items
|
|
|
|
for i := len(imgs) - 2; i >= 0; i-- {
|
|
|
|
if imgs[i].ID == imgs[i+1].ID { // repeated ID. remove and continue
|
|
|
|
m.FSLayers = append(m.FSLayers[:i], m.FSLayers[i+1:]...)
|
|
|
|
m.History = append(m.History[:i], m.History[i+1:]...)
|
|
|
|
} else if imgs[i].Parent != imgs[i+1].ID {
|
|
|
|
return fmt.Errorf("Invalid parent ID. Expected %v, got %v.", imgs[i+1].ID, imgs[i].Parent)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|