kotovalexarian-likes-github
/
moby--moby
mirror of https://github.com/moby/moby.git
1
0
Fork 0
Code Releases Activity
moby--moby/daemon/top_windows.go

13 lines
366 B
Go
Raw Normal View History

Windows: Top (non-)implementation Signed-off-by: John Howard <jhoward@microsoft.com>
2015-07-30 21:25:15 +00:00
package daemon
import (
"github.com/docker/docker/api/types"
Add context.RequestID to event stream This PR adds a "request ID" to each event generated, the 'docker events' stream now looks like this: ``` 2015-09-10T15:02:50.000000000-07:00 [reqid: c01e3534ddca] de7c5d4ca927253cf4e978ee9c4545161e406e9b5a14617efb52c658b249174a: (from ubuntu) create ``` Note the `[reqID: c01e3534ddca]` part, that's new. Each HTTP request will generate its own unique ID. So, if you do a `docker build` you'll see a series of events all with the same reqID. This allow for log processing tools to determine which events are all related to the same http request. I didn't propigate the context to all possible funcs in the daemon, I decided to just do the ones that needed it in order to get the reqID into the events. I'd like to have people review this direction first, and if we're ok with it then I'll make sure we're consistent about when we pass around the context - IOW, make sure that all funcs at the same level have a context passed in even if they don't call the log funcs - this will ensure we're consistent w/o passing it around for all calls unnecessarily. ping @icecrime @calavera @crosbymichael Signed-off-by: Doug Davis <dug@us.ibm.com>
2015-09-10 22:01:18 +00:00
"github.com/docker/docker/context"
Move api/errors/ to errors/ Per @calavera's suggestion: https://github.com/docker/docker/pull/16355#issuecomment-141139220 Signed-off-by: Doug Davis <dug@us.ibm.com>
2015-09-17 18:54:14 +00:00
derr "github.com/docker/docker/errors"
Windows: Top (non-)implementation Signed-off-by: John Howard <jhoward@microsoft.com>
2015-07-30 21:25:15 +00:00
)
golint fixes for daemon/ package - some method names were changed to have a 'Locking' suffix, as the downcased versions already existed, and the existing functions simply had locks around the already downcased version. - deleting unused functions - package comment - magic numbers replaced by golang constants - comments all over Signed-off-by: Morgan Bauer <mbauer@us.ibm.com>
2015-07-30 21:01:53 +00:00
// ContainerTop is not supported on Windows and returns an error.
Add context.RequestID to event stream This PR adds a "request ID" to each event generated, the 'docker events' stream now looks like this: ``` 2015-09-10T15:02:50.000000000-07:00 [reqid: c01e3534ddca] de7c5d4ca927253cf4e978ee9c4545161e406e9b5a14617efb52c658b249174a: (from ubuntu) create ``` Note the `[reqID: c01e3534ddca]` part, that's new. Each HTTP request will generate its own unique ID. So, if you do a `docker build` you'll see a series of events all with the same reqID. This allow for log processing tools to determine which events are all related to the same http request. I didn't propigate the context to all possible funcs in the daemon, I decided to just do the ones that needed it in order to get the reqID into the events. I'd like to have people review this direction first, and if we're ok with it then I'll make sure we're consistent about when we pass around the context - IOW, make sure that all funcs at the same level have a context passed in even if they don't call the log funcs - this will ensure we're consistent w/o passing it around for all calls unnecessarily. ping @icecrime @calavera @crosbymichael Signed-off-by: Doug Davis <dug@us.ibm.com>
2015-09-10 22:01:18 +00:00
func (daemon *Daemon) ContainerTop(ctx context.Context, name string, psArgs string) (*types.ContainerProcessList, error) {
Convert some "daemon" static error strings to the new errocode package format Signed-off-by: Doug Davis <dug@us.ibm.com>
2015-09-16 18:56:26 +00:00
return nil, derr.ErrorCodeNoTop
Windows: Top (non-)implementation Signed-off-by: John Howard <jhoward@microsoft.com>
2015-07-30 21:25:15 +00:00
}