moby--moby/daemon/cluster/executor/container/validate_unix_test.go

// +build !windows

package container // import "github.com/docker/docker/daemon/cluster/executor/container"

const (
	testAbsPath        = "/foo"
	testAbsNonExistent = "/some-non-existing-host-path/"
)
Validate mount paths on task create This is intended as a minor fix for 1.12.1 so that task creation doesn't do unexpected things when the user supplies erroneous paths. In particular, because we're currently using hostConfig.Binds to setup mounts, if a user uses an absolute path for a volume mount source, or a non-absolute path for a bind mount source, the engine will do the opposite of what the user requested since all absolute paths are treated as binds and all non-absolute paths are treated as named volumes. Fixes #25253 Signed-off-by: Brian Goff <cpuguy83@gmail.com> 2016-08-01 21:00:13 +00:00			`// +build !windows`

Add canonical import comment Signed-off-by: Daniel Nephin <dnephin@docker.com> 2018-02-05 21:05:59 +00:00			`package container // import "github.com/docker/docker/daemon/cluster/executor/container"`
Validate mount paths on task create This is intended as a minor fix for 1.12.1 so that task creation doesn't do unexpected things when the user supplies erroneous paths. In particular, because we're currently using hostConfig.Binds to setup mounts, if a user uses an absolute path for a volume mount source, or a non-absolute path for a bind mount source, the engine will do the opposite of what the user requested since all absolute paths are treated as binds and all non-absolute paths are treated as named volumes. Fixes #25253 Signed-off-by: Brian Goff <cpuguy83@gmail.com> 2016-08-01 21:00:13 +00:00
			`const (`
cluster/executor: check mounts at start While it is important to not create controllers for an invalid task, certain properties should only be checked immediately before use. Early host validation of mounts prevents resolution of the task Executor when the mounts are not relevant to execution flow. In this case, we have a check for the existence of a bind mount path in a creation function that prevents a task controller from being resolved. Such early validation prevents one from interacting directly with a controller and result in unnecessary error reporting. In accordance with the above, we move the validation of the existence of host bind mount paths to the `Controller.Start` phase. We also call these "checks", as they are valid mounts but reference non-existent paths. Signed-off-by: Stephen J Day <stephen.day@docker.com> 2017-02-04 02:05:20 +00:00			`testAbsPath = "/foo"`
			`testAbsNonExistent = "/some-non-existing-host-path/"`
Validate mount paths on task create This is intended as a minor fix for 1.12.1 so that task creation doesn't do unexpected things when the user supplies erroneous paths. In particular, because we're currently using hostConfig.Binds to setup mounts, if a user uses an absolute path for a volume mount source, or a non-absolute path for a bind mount source, the engine will do the opposite of what the user requested since all absolute paths are treated as binds and all non-absolute paths are treated as named volumes. Fixes #25253 Signed-off-by: Brian Goff <cpuguy83@gmail.com> 2016-08-01 21:00:13 +00:00			`)`