2022-05-19 15:19:00 -04:00
name : windows
2022-06-02 09:21:05 -04:00
concurrency :
group : ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress : true
2022-05-19 15:19:00 -04:00
on :
workflow_dispatch :
push :
branches :
- 'master'
- '[0-9]+.[0-9]{2}'
tags :
- 'v*'
pull_request :
env :
update golang to 1.18.4
go1.18.4 (released 2022-07-12) includes security fixes to the compress/gzip,
encoding/gob, encoding/xml, go/parser, io/fs, net/http, and path/filepath
packages, as well as bug fixes to the compiler, the go command, the linker,
the runtime, and the runtime/metrics package. See the Go 1.18.4 milestone on the
issue tracker for details:
https://github.com/golang/go/issues?q=milestone%3AGo1.18.4+label%3ACherryPickApproved
This update addresses:
CVE-2022-1705, CVE-2022-1962, CVE-2022-28131, CVE-2022-30630, CVE-2022-30631,
CVE-2022-30632, CVE-2022-30633, CVE-2022-30635, and CVE-2022-32148.
Full diff: https://github.com/golang/go/compare/go1.18.3...go1.18.4
From the security announcement;
https://groups.google.com/g/golang-announce/c/nqrv9fbR0zE
We have just released Go versions 1.18.4 and 1.17.12, minor point releases. These
minor releases include 9 security fixes following the security policy:
- net/http: improper sanitization of Transfer-Encoding header
The HTTP/1 client accepted some invalid Transfer-Encoding headers as indicating
a "chunked" encoding. This could potentially allow for request smuggling, but
only if combined with an intermediate server that also improperly failed to
reject the header as invalid.
This is CVE-2022-1705 and https://go.dev/issue/53188.
- When `httputil.ReverseProxy.ServeHTTP` was called with a `Request.Header` map
containing a nil value for the X-Forwarded-For header, ReverseProxy would set
the client IP as the value of the X-Forwarded-For header, contrary to its
documentation. In the more usual case where a Director function set the
X-Forwarded-For header value to nil, ReverseProxy would leave the header
unmodified as expected.
This is https://go.dev/issue/53423 and CVE-2022-32148.
Thanks to Christian Mehlmauer for reporting this issue.
- compress/gzip: stack exhaustion in Reader.Read
Calling Reader.Read on an archive containing a large number of concatenated
0-length compressed files can cause a panic due to stack exhaustion.
This is CVE-2022-30631 and Go issue https://go.dev/issue/53168.
- encoding/xml: stack exhaustion in Unmarshal
Calling Unmarshal on a XML document into a Go struct which has a nested field
that uses the any field tag can cause a panic due to stack exhaustion.
This is CVE-2022-30633 and Go issue https://go.dev/issue/53611.
- encoding/xml: stack exhaustion in Decoder.Skip
Calling Decoder.Skip when parsing a deeply nested XML document can cause a
panic due to stack exhaustion. The Go Security team discovered this issue, and
it was independently reported by Juho Nurminen of Mattermost.
This is CVE-2022-28131 and Go issue https://go.dev/issue/53614.
- encoding/gob: stack exhaustion in Decoder.Decode
Calling Decoder.Decode on a message which contains deeply nested structures
can cause a panic due to stack exhaustion.
This is CVE-2022-30635 and Go issue https://go.dev/issue/53615.
- path/filepath: stack exhaustion in Glob
Calling Glob on a path which contains a large number of path separators can
cause a panic due to stack exhaustion.
Thanks to Juho Nurminen of Mattermost for reporting this issue.
This is CVE-2022-30632 and Go issue https://go.dev/issue/53416.
- io/fs: stack exhaustion in Glob
Calling Glob on a path which contains a large number of path separators can
cause a panic due to stack exhaustion.
This is CVE-2022-30630 and Go issue https://go.dev/issue/53415.
- go/parser: stack exhaustion in all Parse* functions
Calling any of the Parse functions on Go source code which contains deeply
nested types or declarations can cause a panic due to stack exhaustion.
Thanks to Juho Nurminen of Mattermost for reporting this issue.
This is CVE-2022-1962 and Go issue https://go.dev/issue/53616.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-07-13 04:42:27 -04:00
GO_VERSION : 1.18 .4
2022-06-16 16:47:36 -04:00
GOTESTLIST_VERSION : v0.2.0
2022-06-06 10:11:47 -04:00
TESTSTAT_VERSION : v0.1.3
2022-05-19 15:19:00 -04:00
WINDOWS_BASE_IMAGE : mcr.microsoft.com/windows/servercore
WINDOWS_BASE_TAG_2019 : ltsc2019
WINDOWS_BASE_TAG_2022 : ltsc2022
TEST_IMAGE_NAME : moby:test
TEST_CTN_NAME : moby
DOCKER_BUILDKIT : 0
jobs :
build :
runs-on : ${{ matrix.os }}
strategy :
fail-fast : false
matrix :
os :
- windows-2019
- windows-2022
env :
GOPATH : ${{ github.workspace }}\go
GOBIN : ${{ github.workspace }}\go\bin
BIN_OUT : ${{ github.workspace }}\out
defaults :
run :
working-directory : ${{ env.GOPATH }}/src/github.com/docker/docker
steps :
-
name : Checkout
uses : actions/checkout@v3
with :
path : ${{ env.GOPATH }}/src/github.com/docker/docker
-
name : Env
run : |
Get-ChildItem Env : | Out-String
-
name : Init
run : |
New-Item -ItemType "directory" -Path "${{ github.workspace }}\go-build"
New-Item -ItemType "directory" -Path "${{ github.workspace }}\go\pkg\mod"
If ("${{ matrix.os }}" -eq "windows-2019") {
echo "WINDOWS_BASE_IMAGE_TAG=${{ env.WINDOWS_BASE_TAG_2019 }}" | Out-File -FilePath $Env:GITHUB_ENV -Encoding utf-8 -Append
} ElseIf ("${{ matrix.os }}" -eq "windows-2022") {
echo "WINDOWS_BASE_IMAGE_TAG=${{ env.WINDOWS_BASE_TAG_2022 }}" | Out-File -FilePath $Env:GITHUB_ENV -Encoding utf-8 -Append
}
-
name : Cache
uses : actions/cache@v3
with :
path : |
~\AppData\Local\go-build
~\go\pkg\mod
${{ github.workspace }}\go-build
${{ env.GOPATH }}\pkg\mod
key : ${{ matrix.os }}-${{ github.job }}-${{ hashFiles('**/vendor.sum') }}
restore-keys : |
${{ matrix.os }}-${{ github.job }}-
-
name : Docker info
run : |
docker info
-
name : Build base image
run : |
docker pull ${{ env.WINDOWS_BASE_IMAGE }}:${{ env.WINDOWS_BASE_IMAGE_TAG }}
docker tag ${{ env.WINDOWS_BASE_IMAGE }}:${{ env.WINDOWS_BASE_IMAGE_TAG }} microsoft/windowsservercore
docker build --build-arg GO_VERSION -t ${{ env.TEST_IMAGE_NAME }} -f Dockerfile.windows .
-
name : Build binaries
run : |
& docker run --name ${{ env.TEST_CTN_NAME }} -e "DOCKER_GITCOMMIT=${{ github.sha }}" `
-v "${{ github.workspace }}\go-build:C:\Users\ContainerAdministrator\AppData\Local\go-build" `
-v "${{ github.workspace }}\go\pkg\mod:C:\gopath\pkg\mod" `
${{ env.TEST_IMAGE_NAME }} hack\make.ps1 -Daemon -Client
-
name : Copy artifacts
run : |
New-Item -ItemType "directory" -Path "${{ env.BIN_OUT }}"
docker cp "${{ env.TEST_CTN_NAME }}`:c`:\gopath\src\github.com\docker\docker\bundles\docker.exe" ${{ env.BIN_OUT }}\
docker cp "${{ env.TEST_CTN_NAME }}`:c`:\gopath\src\github.com\docker\docker\bundles\dockerd.exe" ${{ env.BIN_OUT }}\
docker cp "${{ env.TEST_CTN_NAME }}`:c`:\gopath\bin\gotestsum.exe" ${{ env.BIN_OUT }}\
docker cp "${{ env.TEST_CTN_NAME }}`:c`:\containerd\bin\containerd.exe" ${{ env.BIN_OUT }}\
docker cp "${{ env.TEST_CTN_NAME }}`:c`:\containerd\bin\containerd-shim-runhcs-v1.exe" ${{ env.BIN_OUT }}\
-
name : Upload artifacts
uses : actions/upload-artifact@v3
with :
name : build-${{ matrix.os }}
path : ${{ env.BIN_OUT }}/*
if-no-files-found : error
retention-days : 2
2022-04-22 16:51:22 -04:00
unit-test :
runs-on : ${{ matrix.os }}
strategy :
fail-fast : false
matrix :
os :
- windows-2019
- windows-2022
env :
GOPATH : ${{ github.workspace }}\go
GOBIN : ${{ github.workspace }}\go\bin
defaults :
run :
working-directory : ${{ env.GOPATH }}/src/github.com/docker/docker
steps :
-
name : Checkout
uses : actions/checkout@v3
with :
path : ${{ env.GOPATH }}/src/github.com/docker/docker
-
name : Env
run : |
Get-ChildItem Env : | Out-String
-
name : Init
run : |
New-Item -ItemType "directory" -Path "${{ github.workspace }}\go-build"
New-Item -ItemType "directory" -Path "${{ github.workspace }}\go\pkg\mod"
2022-05-19 15:19:51 -04:00
New-Item -ItemType "directory" -Path "bundles"
2022-04-22 16:51:22 -04:00
If ("${{ matrix.os }}" -eq "windows-2019") {
echo "WINDOWS_BASE_IMAGE_TAG=${{ env.WINDOWS_BASE_TAG_2019 }}" | Out-File -FilePath $Env:GITHUB_ENV -Encoding utf-8 -Append
} ElseIf ("${{ matrix.os }}" -eq "windows-2022") {
echo "WINDOWS_BASE_IMAGE_TAG=${{ env.WINDOWS_BASE_TAG_2022 }}" | Out-File -FilePath $Env:GITHUB_ENV -Encoding utf-8 -Append
}
-
name : Cache
uses : actions/cache@v3
with :
path : |
~\AppData\Local\go-build
~\go\pkg\mod
${{ github.workspace }}\go-build
${{ env.GOPATH }}\pkg\mod
key : ${{ matrix.os }}-${{ github.job }}-${{ hashFiles('**/vendor.sum') }}
restore-keys : |
${{ matrix.os }}-${{ github.job }}-
-
name : Docker info
run : |
docker info
-
name : Build base image
run : |
docker pull ${{ env.WINDOWS_BASE_IMAGE }}:${{ env.WINDOWS_BASE_IMAGE_TAG }}
docker tag ${{ env.WINDOWS_BASE_IMAGE }}:${{ env.WINDOWS_BASE_IMAGE_TAG }} microsoft/windowsservercore
docker build --build-arg GO_VERSION -t ${{ env.TEST_IMAGE_NAME }} -f Dockerfile.windows .
-
name : Test
run : |
& docker run --name ${{ env.TEST_CTN_NAME }} -e "DOCKER_GITCOMMIT=${{ github.sha }}" `
2022-05-19 15:19:51 -04:00
-v "${{ github.workspace }}\go-build:C:\Users\ContainerAdministrator\AppData\Local\go-build" `
-v "${{ github.workspace }}\go\pkg\mod:C:\gopath\pkg\mod" `
-v "${{ env.GOPATH }}\src\github.com\docker\docker\bundles:C:\gopath\src\github.com\docker\docker\bundles" `
${{ env.TEST_IMAGE_NAME }} hack\make.ps1 -TestUnit
-
name : Send to Codecov
if : matrix.os == 'windows-2022'
uses : codecov/codecov-action@v3
with :
working-directory : ${{ env.GOPATH }}\src\github.com\docker\docker
directory : bundles
env_vars : RUNNER_OS
flags : unit
-
name : Upload reports
2022-05-31 13:40:15 -04:00
if : always()
2022-05-19 15:19:51 -04:00
uses : actions/upload-artifact@v3
with :
2022-05-31 13:40:15 -04:00
name : ${{ matrix.os }}-unit-reports
2022-05-19 15:19:51 -04:00
path : ${{ env.GOPATH }}\src\github.com\docker\docker\bundles\*
2022-05-12 07:21:48 -04:00
2022-06-06 10:11:47 -04:00
unit-test-report :
runs-on : ubuntu-latest
if : always()
needs :
- unit-test
strategy :
fail-fast : false
matrix :
os :
- windows-2019
- windows-2022
steps :
-
name : Set up Go
uses : actions/setup-go@v3
with :
go-version : ${{ env.GO_VERSION }}
-
name : Download artifacts
uses : actions/download-artifact@v3
with :
name : ${{ matrix.os }}-unit-reports
path : /tmp/artifacts
-
name : Install teststat
run : |
go install github.com/vearutop/teststat@${{ env.TESTSTAT_VERSION }}
-
name : Create summary
run : |
teststat -markdown $(find /tmp/artifacts -type f -name '*.json' -print0 | xargs -0) >> $GITHUB_STEP_SUMMARY
2022-06-16 16:47:36 -04:00
integration-test-prepare :
runs-on : ubuntu-latest
outputs :
matrix : ${{ steps.tests.outputs.matrix }}
steps :
-
name : Checkout
uses : actions/checkout@v3
-
name : Set up Go
uses : actions/setup-go@v3
with :
go-version : ${{ env.GO_VERSION }}
-
name : Install gotestlist
run :
go install github.com/crazy-max/gotestlist/cmd/gotestlist@${{ env.GOTESTLIST_VERSION }}
-
name : Create matrix
id : tests
working-directory : ./integration-cli
run : |
# Distribute integration-cli tests for the matrix in integration-test job.
# Also prepend ./... to the matrix. This is a special case to run "Test integration" step exclusively.
matrix="$(gotestlist -d 4 ./...)"
matrix="$(echo "$matrix" | jq -c '. |= ["./..."] + .')"
echo "::set-output name=matrix::$matrix"
-
name : Show matrix
run : |
echo ${{ steps.tests.outputs.matrix }}
2022-05-12 07:21:48 -04:00
integration-test :
runs-on : ${{ matrix.os }}
needs :
- build
2022-06-16 16:47:36 -04:00
- integration-test-prepare
2022-05-12 07:21:48 -04:00
strategy :
fail-fast : false
matrix :
os :
- windows-2019
- windows-2022
runtime :
- builtin
- containerd
2022-06-16 16:47:36 -04:00
test : ${{ fromJson(needs.integration-test-prepare.outputs.matrix) }}
2022-05-12 07:21:48 -04:00
env :
GOPATH : ${{ github.workspace }}\go
GOBIN : ${{ github.workspace }}\go\bin
BIN_OUT : ${{ github.workspace }}\out
defaults :
run :
working-directory : ${{ env.GOPATH }}/src/github.com/docker/docker
steps :
-
name : Checkout
uses : actions/checkout@v3
with :
path : ${{ env.GOPATH }}/src/github.com/docker/docker
-
name : Env
run : |
Get-ChildItem Env : | Out-String
-
name : Download artifacts
uses : actions/download-artifact@v3
with :
name : build-${{ matrix.os }}
path : ${{ env.BIN_OUT }}
-
name : Init
run : |
2022-05-31 13:40:15 -04:00
New-Item -ItemType "directory" -Path "bundles"
2022-05-12 07:21:48 -04:00
If ("${{ matrix.os }}" -eq "windows-2019") {
echo "WINDOWS_BASE_IMAGE_TAG=${{ env.WINDOWS_BASE_TAG_2019 }}" | Out-File -FilePath $Env:GITHUB_ENV -Encoding utf-8 -Append
} ElseIf ("${{ matrix.os }}" -eq "windows-2022") {
echo "WINDOWS_BASE_IMAGE_TAG=${{ env.WINDOWS_BASE_TAG_2022 }}" | Out-File -FilePath $Env:GITHUB_ENV -Encoding utf-8 -Append
}
Write-Output "${{ env.BIN_OUT }}" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
-
# removes docker service that is currently installed on the runner. we
# could use Uninstall-Package but not yet available on Windows runners.
# more info: https://github.com/actions/virtual-environments/blob/d3a5bad25f3b4326c5666bab0011ac7f1beec95e/images/win/scripts/Installers/Install-Docker.ps1#L11
name : Removing current daemon
run : |
if (Get-Service docker -ErrorAction SilentlyContinue) {
$dockerVersion = (docker version -f "{{.Server.Version}}")
Write-Host "Current installed Docker version: $dockerVersion"
# remove service
Stop-Service -Force -Name docker
Remove-Service -Name docker
# removes event log entry. we could use "Remove-EventLog -LogName -Source docker"
# but this cmd is only available since windows-2022
$ErrorActionPreference = "SilentlyContinue"
& reg delete "HKLM\SYSTEM\CurrentControlSet\Services\EventLog\Application\docker" /f 2>&1 | Out-Null
$ErrorActionPreference = "Stop"
Write-Host "Service removed"
}
-
name : Starting containerd
if : matrix.runtime == 'containerd'
run : |
Write-Host "Generating config"
& "${{ env.BIN_OUT }}\containerd.exe" config default | Out-File "$env:TEMP\ctn.toml" -Encoding ascii
Write-Host "Creating service"
New-Item -ItemType Directory "$env:TEMP\ctn-root" -ErrorAction SilentlyContinue | Out-Null
New-Item -ItemType Directory "$env:TEMP\ctn-state" -ErrorAction SilentlyContinue | Out-Null
Start-Process -Wait "${{ env.BIN_OUT }}\containerd.exe" `
-ArgumentList "--log-level=debug", `
"--config=$env:TEMP\ctn.toml" , `
"--address=\\.\pipe\containerd-containerd" , `
"--root=$env:TEMP\ctn-root" , `
"--state=$env:TEMP\ctn-state" , `
"--log-file=$env:TEMP\ctn.log" , `
"--register-service"
Write-Host "Starting service"
Start-Service -Name containerd
Start-Sleep -Seconds 5
Write-Host "Service started successfully!"
-
name : Starting test daemon
run : |
Write-Host "Creating service"
If ("${{ matrix.runtime }}" -eq "containerd") {
$runtimeArg="--containerd=\\.\pipe\containerd-containerd"
echo "DOCKER_WINDOWS_CONTAINERD_RUNTIME=1" | Out-File -FilePath $Env:GITHUB_ENV -Encoding utf-8 -Append
}
New-Item -ItemType Directory "$env:TEMP\moby-root" -ErrorAction SilentlyContinue | Out-Null
New-Item -ItemType Directory "$env:TEMP\moby-exec" -ErrorAction SilentlyContinue | Out-Null
Start-Process -Wait -NoNewWindow "${{ env.BIN_OUT }}\dockerd" `
-ArgumentList $runtimeArg, "--debug", `
"--host=npipe:////./pipe/docker_engine" , `
"--data-root=$env:TEMP\moby-root" , `
"--exec-root=$env:TEMP\moby-exec" , `
"--pidfile=$env:TEMP\docker.pid" , `
"--register-service"
Write-Host "Starting service"
Start-Service -Name docker
Write-Host "Service started successfully!"
-
name : Waiting for test daemon to start
run : |
$tries=20
Write-Host "Waiting for the test daemon to start..."
While ($true) {
$ErrorActionPreference = "SilentlyContinue"
& "${{ env.BIN_OUT }}\docker" version
$ErrorActionPreference = "Stop"
If ($LastExitCode -eq 0) {
break
}
$tries--
If ($tries -le 0) {
Throw "Failed to get a response from the daemon"
}
Write-Host -NoNewline "."
Start-Sleep -Seconds 1
}
Write-Host "Test daemon started and replied!"
env :
DOCKER_HOST : npipe:////./pipe/docker_engine
-
name : Docker info
run : |
& "${{ env.BIN_OUT }}\docker" info
env :
DOCKER_HOST : npipe:////./pipe/docker_engine
-
name : Building contrib/busybox
run : |
& "${{ env.BIN_OUT }}\docker" build -t busybox `
--build-arg WINDOWS_BASE_IMAGE `
--build-arg WINDOWS_BASE_IMAGE_TAG `
.\contrib\busybox\
env :
DOCKER_HOST : npipe:////./pipe/docker_engine
-
name : List images
run : |
& "${{ env.BIN_OUT }}\docker" images
env :
DOCKER_HOST : npipe:////./pipe/docker_engine
-
name : Set up Go
uses : actions/setup-go@v3
with :
go-version : ${{ env.GO_VERSION }}
-
2022-06-16 16:47:36 -04:00
name : Test integration
if : matrix.test == './...'
2022-05-12 07:21:48 -04:00
run : |
.\hack\make.ps1 -TestIntegration
env :
DOCKER_HOST : npipe:////./pipe/docker_engine
GO111MODULE : "off"
TEST_CLIENT_BINARY : ${{ env.BIN_OUT }}\docker
-
2022-06-16 16:47:36 -04:00
name : Test integration-cli
if : matrix.test != './...'
2022-05-12 07:21:48 -04:00
run : |
2022-06-06 09:36:12 -04:00
.\hack\make.ps1 -TestIntegrationCli
2022-05-12 07:21:48 -04:00
env :
DOCKER_HOST : npipe:////./pipe/docker_engine
GO111MODULE : "off"
TEST_CLIENT_BINARY : ${{ env.BIN_OUT }}\docker
2022-06-06 09:36:12 -04:00
INTEGRATION_TESTRUN : ${{ matrix.test }}
2022-05-19 15:19:51 -04:00
-
name : Send to Codecov
if : matrix.os == 'windows-2022'
uses : codecov/codecov-action@v3
with :
working-directory : ${{ env.GOPATH }}\src\github.com\docker\docker
directory : bundles
env_vars : RUNNER_OS
flags : integration,${{ matrix.runtime }}
2022-05-12 07:21:48 -04:00
-
name : Docker info
run : |
& "${{ env.BIN_OUT }}\docker" info
env :
DOCKER_HOST : npipe:////./pipe/docker_engine
-
name : Stop containerd
if : always() && matrix.runtime == 'containerd'
run : |
$ErrorActionPreference = "SilentlyContinue"
Stop-Service -Force -Name containerd
$ErrorActionPreference = "Stop"
-
name : Containerd logs
if : always() && matrix.runtime == 'containerd'
run : |
2022-05-31 13:40:15 -04:00
Copy-Item "$env:TEMP\ctn.log" -Destination ".\bundles\containerd.log"
2022-05-12 07:21:48 -04:00
Get-Content "$env:TEMP\ctn.log" | Out-Host
-
name : Stop daemon
if : always()
run : |
$ErrorActionPreference = "SilentlyContinue"
Stop-Service -Force -Name docker
$ErrorActionPreference = "Stop"
-
# as the daemon is registered as a service we have to check the event
# logs against the docker provider.
name : Daemon event logs
if : always()
run : |
Get-WinEvent -ea SilentlyContinue `
-FilterHashtable @{ProviderName= "docker"; LogName = "application"} |
Select-Object -Property TimeCreated, @{N='Detailed Message'; E={$_.Message}} |
Sort-Object @{Expression="TimeCreated";Descending=$false} |
2022-05-31 13:40:15 -04:00
Select-Object -ExpandProperty 'Detailed Message' | Tee-Object -file ".\bundles\daemon.log"
-
name : Upload reports
if : always()
uses : actions/upload-artifact@v3
with :
name : ${{ matrix.os }}-integration-reports-${{ matrix.runtime }}
path : ${{ env.GOPATH }}\src\github.com\docker\docker\bundles\*
2022-06-06 10:11:47 -04:00
integration-test-report :
runs-on : ubuntu-latest
if : always()
needs :
- integration-test
strategy :
fail-fast : false
matrix :
os :
- windows-2019
- windows-2022
runtime :
- builtin
- containerd
steps :
-
name : Set up Go
uses : actions/setup-go@v3
with :
go-version : ${{ env.GO_VERSION }}
-
name : Download artifacts
uses : actions/download-artifact@v3
with :
name : ${{ matrix.os }}-integration-reports-${{ matrix.runtime }}
path : /tmp/artifacts
-
name : Install teststat
run : |
go install github.com/vearutop/teststat@${{ env.TESTSTAT_VERSION }}
-
name : Create summary
run : |
teststat -markdown $(find /tmp/artifacts -type f -name '*.json' -print0 | xargs -0) >> $GITHUB_STEP_SUMMARY