abort on error and fix debug

Docker-DCO-1.1-Signed-off-by: Victor Vieux <vieux@docker.com> (github: vieux)
This commit is contained in:
Victor Vieux 2014-06-26 02:12:18 +00:00
parent 42ca8a064b
commit 0098360726
2 changed files with 5 additions and 4 deletions

View File

@ -167,8 +167,9 @@ func (cli *DockerCli) CmdBuild(args ...string) error {
options := &archive.TarOptions{
Compression: archive.Uncompressed,
}
ignoreFile := path.Join(root, ".dockerignore")
if ignore, err := ioutil.ReadFile(ignoreFile); err == nil {
if ignore, err := ioutil.ReadFile(path.Join(root, ".dockerignore")); err != nil && !os.IsNotExist(err) {
return fmt.Errorf("Error reading .dockerignore: '%s'", err)
} else if err == nil {
for _, pattern := range strings.Split(string(ignore), "\n") {
ok, err := filepath.Match(pattern, "Dockerfile")
if err != nil {

View File

@ -343,11 +343,11 @@ func TarWithOptions(srcPath string, options *TarOptions) (io.ReadCloser, error)
for _, exclude := range options.Excludes {
matched, err := filepath.Match(exclude, relFilePath)
if err != nil {
utils.Errorf("Error matching: %s (pattern: %s)\n", relFilePath, exclude)
utils.Errorf("Error matching: %s (pattern: %s)", relFilePath, exclude)
return err
}
if matched {
utils.Debugf("Skipping excluded path: %s\n", relFilePath)
utils.Debugf("Skipping excluded path: %s", relFilePath)
if f.IsDir() {
return filepath.SkipDir
}