Merge pull request #12214 from ahmetalpbalkan/namesgenerator/localrand

names-generator: use local random instance

pkg/namesgenerator/names-generator.go

@@ -308,19 +308,19 @@ var (
 		// Ada Yonath - an Israeli crystallographer, the first woman from the Middle East to win a Nobel prize in the sciences. https://en.wikipedia.org/wiki/Ada_Yonath
 		"yonath",
 	}
+
+	rnd = rand.New(rand.NewSource(time.Now().UnixNano()))
 )
 
 func GetRandomName(retry int) string {
-	rand.Seed(time.Now().UnixNano())
-
 begin:
-	name := fmt.Sprintf("%s_%s", left[rand.Intn(len(left))], right[rand.Intn(len(right))])
+	name := fmt.Sprintf("%s_%s", left[rnd.Intn(len(left))], right[rnd.Intn(len(right))])
 	if name == "boring_wozniak" /* Steve Wozniak is not boring */ {
 		goto begin
 	}
 
 	if retry > 0 {
-		name = fmt.Sprintf("%s%d", name, rand.Intn(10))
+		name = fmt.Sprintf("%s%d", name, rnd.Intn(10))
 	}
 	return name
 }