From 04129678a6415d3684a6e892a3b206b83519cc33 Mon Sep 17 00:00:00 2001 From: Kir Kolyshkin Date: Mon, 5 Aug 2019 20:05:40 -0700 Subject: [PATCH] jsonfilelog_test: check err from open before close Fix warnings like this one: > daemon/logger/jsonfilelog/jsonfilelog_test.go:191:3: SA5001: should check returned error before deferring file.Close() (staticcheck) > defer file.Close() > ^ Signed-off-by: Kir Kolyshkin --- daemon/logger/jsonfilelog/jsonfilelog_test.go | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/daemon/logger/jsonfilelog/jsonfilelog_test.go b/daemon/logger/jsonfilelog/jsonfilelog_test.go index 97265a7fc7..155086dec6 100644 --- a/daemon/logger/jsonfilelog/jsonfilelog_test.go +++ b/daemon/logger/jsonfilelog/jsonfilelog_test.go @@ -188,15 +188,15 @@ func TestJSONFileLoggerWithOpts(t *testing.T) { } file, err := os.Open(filename + ".1.gz") + if err != nil { + t.Fatal(err) + } defer file.Close() - if err != nil { - t.Fatal(err) - } zipReader, err := gzip.NewReader(file) - defer zipReader.Close() if err != nil { t.Fatal(err) } + defer zipReader.Close() penUlt, err = ioutil.ReadAll(zipReader) if err != nil { t.Fatal(err) @@ -204,15 +204,15 @@ func TestJSONFileLoggerWithOpts(t *testing.T) { } file, err := os.Open(filename + ".2.gz") + if err != nil { + t.Fatal(err) + } defer file.Close() - if err != nil { - t.Fatal(err) - } zipReader, err := gzip.NewReader(file) - defer zipReader.Close() if err != nil { t.Fatal(err) } + defer zipReader.Close() antepenult, err := ioutil.ReadAll(zipReader) if err != nil { t.Fatal(err)