diff --git a/distribution/config.go b/distribution/config.go index fa06e3c9c0..a00392199f 100644 --- a/distribution/config.go +++ b/distribution/config.go @@ -8,7 +8,7 @@ import ( "github.com/docker/distribution" "github.com/docker/distribution/manifest/schema2" - "github.com/docker/docker/api/types" + "github.com/docker/docker/api/types/registry" "github.com/docker/docker/distribution/metadata" "github.com/docker/docker/distribution/xfer" "github.com/docker/docker/image" @@ -16,7 +16,7 @@ import ( "github.com/docker/docker/pkg/progress" "github.com/docker/docker/pkg/system" refstore "github.com/docker/docker/reference" - "github.com/docker/docker/registry" + registrypkg "github.com/docker/docker/registry" "github.com/docker/libtrust" "github.com/opencontainers/go-digest" specs "github.com/opencontainers/image-spec/specs-go/v1" @@ -30,13 +30,13 @@ type Config struct { MetaHeaders map[string][]string // AuthConfig holds authentication credentials for authenticating with // the registry. - AuthConfig *types.AuthConfig + AuthConfig *registry.AuthConfig // ProgressOutput is the interface for showing the status of the pull // operation. ProgressOutput progress.Output // RegistryService is the registry service to use for TLS configuration // and endpoint lookup. - RegistryService registry.Service + RegistryService registrypkg.Service // ImageEventLogger notifies events for a given image ImageEventLogger func(id, name, action string) // MetadataStore is the storage backend for distribution-specific diff --git a/distribution/metadata/v2_metadata_service.go b/distribution/metadata/v2_metadata_service.go index fe33498554..e81c99e8dd 100644 --- a/distribution/metadata/v2_metadata_service.go +++ b/distribution/metadata/v2_metadata_service.go @@ -7,7 +7,7 @@ import ( "encoding/json" "errors" - "github.com/docker/docker/api/types" + "github.com/docker/docker/api/types/registry" "github.com/docker/docker/layer" "github.com/opencontainers/go-digest" ) @@ -69,7 +69,7 @@ func ComputeV2MetadataHMAC(key []byte, meta *V2Metadata) string { // ComputeV2MetadataHMACKey returns a key for the given "authConfig" that can be used to hash v2 metadata // entries. -func ComputeV2MetadataHMACKey(authConfig *types.AuthConfig) ([]byte, error) { +func ComputeV2MetadataHMACKey(authConfig *registry.AuthConfig) ([]byte, error) { if authConfig == nil { return nil, nil } diff --git a/distribution/pull_v2_test.go b/distribution/pull_v2_test.go index 76aeac2e40..381590c4ac 100644 --- a/distribution/pull_v2_test.go +++ b/distribution/pull_v2_test.go @@ -16,7 +16,6 @@ import ( "github.com/docker/distribution/manifest/schema1" "github.com/docker/distribution/reference" - "github.com/docker/docker/api/types" registrytypes "github.com/docker/docker/api/types/registry" "github.com/docker/docker/image" "github.com/docker/docker/registry" @@ -351,7 +350,7 @@ func testNewPuller(t *testing.T, rawurl string) *puller { imagePullConfig := &ImagePullConfig{ Config: Config{ MetaHeaders: http.Header{}, - AuthConfig: &types.AuthConfig{ + AuthConfig: ®istrytypes.AuthConfig{ RegistryToken: secretRegistryToken, }, }, diff --git a/distribution/push_v2_test.go b/distribution/push_v2_test.go index def4233786..3a683850a4 100644 --- a/distribution/push_v2_test.go +++ b/distribution/push_v2_test.go @@ -11,12 +11,12 @@ import ( "github.com/docker/distribution/manifest/schema2" "github.com/docker/distribution/reference" "github.com/docker/distribution/registry/api/errcode" - "github.com/docker/docker/api/types" + "github.com/docker/docker/api/types/registry" "github.com/docker/docker/distribution/metadata" "github.com/docker/docker/layer" "github.com/docker/docker/pkg/progress" refstore "github.com/docker/docker/reference" - "github.com/docker/docker/registry" + registrypkg "github.com/docker/docker/registry" "github.com/opencontainers/go-digest" ) @@ -515,7 +515,7 @@ func TestWhenEmptyAuthConfig(t *testing.T) { }, } { imagePushConfig := &ImagePushConfig{} - imagePushConfig.AuthConfig = &types.AuthConfig{ + imagePushConfig.AuthConfig = ®istry.AuthConfig{ Username: authInfo.username, Password: authInfo.password, RegistryToken: authInfo.registryToken, @@ -524,15 +524,15 @@ func TestWhenEmptyAuthConfig(t *testing.T) { repoInfo, _ := reference.ParseNormalizedNamed("xujihui1985/test.img") pusher := &pusher{ config: imagePushConfig, - repoInfo: ®istry.RepositoryInfo{ + repoInfo: ®istrypkg.RepositoryInfo{ Name: repoInfo, }, - endpoint: registry.APIEndpoint{ + endpoint: registrypkg.APIEndpoint{ URL: &url.URL{ Scheme: "https", Host: "index.docker.io", }, - Version: registry.APIVersion2, + Version: registrypkg.APIVersion2, TrimHostname: true, }, } diff --git a/distribution/registry.go b/distribution/registry.go index 7ff01b5d92..36d3a42ca0 100644 --- a/distribution/registry.go +++ b/distribution/registry.go @@ -13,7 +13,7 @@ import ( "github.com/docker/distribution/registry/client" "github.com/docker/distribution/registry/client/auth" "github.com/docker/distribution/registry/client/transport" - "github.com/docker/docker/api/types" + registrytypes "github.com/docker/docker/api/types/registry" "github.com/docker/docker/dockerversion" "github.com/docker/docker/registry" ocispec "github.com/opencontainers/image-spec/specs-go/v1" @@ -58,7 +58,7 @@ func init() { // remote API version. func newRepository( ctx context.Context, repoInfo *registry.RepositoryInfo, endpoint registry.APIEndpoint, - metaHeaders http.Header, authConfig *types.AuthConfig, actions ...string, + metaHeaders http.Header, authConfig *registrytypes.AuthConfig, actions ...string, ) (repo distribution.Repository, err error) { repoName := repoInfo.Name.Name() // If endpoint does not support CanonicalName, use the RemoteName instead diff --git a/distribution/registry_unit_test.go b/distribution/registry_unit_test.go index c803577173..035f062740 100644 --- a/distribution/registry_unit_test.go +++ b/distribution/registry_unit_test.go @@ -9,9 +9,8 @@ import ( "testing" "github.com/docker/distribution/reference" - "github.com/docker/docker/api/types" - registrytypes "github.com/docker/docker/api/types/registry" - "github.com/docker/docker/registry" + "github.com/docker/docker/api/types/registry" + registrypkg "github.com/docker/docker/registry" "github.com/sirupsen/logrus" ) @@ -41,7 +40,7 @@ func testTokenPassThru(t *testing.T, ts *httptest.Server) { t.Fatalf("could not parse url from test server: %v", err) } - endpoint := registry.APIEndpoint{ + endpoint := registrypkg.APIEndpoint{ Mirror: false, URL: uri, Version: 2, @@ -50,9 +49,9 @@ func testTokenPassThru(t *testing.T, ts *httptest.Server) { TLSConfig: nil, } n, _ := reference.ParseNormalizedNamed("testremotename") - repoInfo := ®istry.RepositoryInfo{ + repoInfo := ®istrypkg.RepositoryInfo{ Name: n, - Index: ®istrytypes.IndexInfo{ + Index: ®istry.IndexInfo{ Name: "testrepo", Mirrors: nil, Secure: false, @@ -63,7 +62,7 @@ func testTokenPassThru(t *testing.T, ts *httptest.Server) { imagePullConfig := &ImagePullConfig{ Config: Config{ MetaHeaders: http.Header{}, - AuthConfig: &types.AuthConfig{ + AuthConfig: ®istry.AuthConfig{ RegistryToken: secretRegistryToken, }, },