hack/validate/vendor: add more checks
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
This commit is contained in:
parent
d26cf30a60
commit
051b9a434f
|
@ -3,6 +3,7 @@
|
||||||
export SCRIPTDIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
|
export SCRIPTDIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
|
||||||
source "${SCRIPTDIR}/.validate"
|
source "${SCRIPTDIR}/.validate"
|
||||||
|
|
||||||
|
validate_vendor_diff(){
|
||||||
IFS=$'\n'
|
IFS=$'\n'
|
||||||
files=( $(validate_diff --diff-filter=ACMR --name-only -- 'vendor.conf' 'vendor/' || true) )
|
files=( $(validate_diff --diff-filter=ACMR --name-only -- 'vendor.conf' 'vendor/' || true) )
|
||||||
unset IFS
|
unset IFS
|
||||||
|
@ -28,3 +29,23 @@ if [ ${#files[@]} -gt 0 ]; then
|
||||||
else
|
else
|
||||||
echo 'No vendor changes in diff.'
|
echo 'No vendor changes in diff.'
|
||||||
fi
|
fi
|
||||||
|
}
|
||||||
|
|
||||||
|
# 1. make sure all the vendored packages are used
|
||||||
|
# 2. make sure all the packages contain license information (just warning, because it can cause false-positive)
|
||||||
|
validate_vendor_used() {
|
||||||
|
pkgs=$(mawk '/^[a-zA-Z0-9]/ { print $1 }' < vendor.conf)
|
||||||
|
for f in $pkgs; do
|
||||||
|
if ls -d vendor/$f > /dev/null 2>&1; then
|
||||||
|
found=$(find vendor/$f -iregex '.*LICENSE.*' -or -iregex '.*COPYRIGHT.*' -or -iregex '.*COPYING.*' | wc -l)
|
||||||
|
if [ $found -eq 0 ]; then
|
||||||
|
echo "WARNING: could not find copyright information for $f"
|
||||||
|
fi
|
||||||
|
else
|
||||||
|
echo "WARNING: $f is vendored but unused"
|
||||||
|
fi
|
||||||
|
done
|
||||||
|
}
|
||||||
|
|
||||||
|
validate_vendor_diff
|
||||||
|
validate_vendor_used
|
||||||
|
|
Loading…
Reference in New Issue