mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
remove deprecated feature of passing HostConfig at API container start
Signed-off-by: Shijiang Wei <mountkin@gmail.com>
This commit is contained in:
parent
74c7363965
commit
0a8386c8be
8 changed files with 287 additions and 243 deletions
30
integration-cli/docker_deprecated_api_v124_unix_test.go
Normal file
30
integration-cli/docker_deprecated_api_v124_unix_test.go
Normal file
|
@ -0,0 +1,30 @@
|
|||
// +build !windows
|
||||
|
||||
package main
|
||||
|
||||
import (
|
||||
"fmt"
|
||||
|
||||
"github.com/docker/docker/pkg/integration/checker"
|
||||
"github.com/go-check/check"
|
||||
)
|
||||
|
||||
// #19100 This is a deprecated feature test, it should be removed in Docker 1.12
|
||||
func (s *DockerNetworkSuite) TestDeprecatedDockerNetworkStartAPIWithHostconfig(c *check.C) {
|
||||
netName := "test"
|
||||
conName := "foo"
|
||||
dockerCmd(c, "network", "create", netName)
|
||||
dockerCmd(c, "create", "--name", conName, "busybox", "top")
|
||||
|
||||
config := map[string]interface{}{
|
||||
"HostConfig": map[string]interface{}{
|
||||
"NetworkMode": netName,
|
||||
},
|
||||
}
|
||||
_, _, err := sockRequest("POST", formatV123StartAPIURL("/containers/"+conName+"/start"), config)
|
||||
c.Assert(err, checker.IsNil)
|
||||
c.Assert(waitRun(conName), checker.IsNil)
|
||||
networks := inspectField(c, conName, "NetworkSettings.Networks")
|
||||
c.Assert(networks, checker.Contains, netName, check.Commentf(fmt.Sprintf("Should contain '%s' network", netName)))
|
||||
c.Assert(networks, checker.Not(checker.Contains), "bridge", check.Commentf("Should not contain 'bridge' network"))
|
||||
}
|
Loading…
Add table
Add a link
Reference in a new issue