kotovalexarian-likes-github/moby--moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
Code Releases Activity

devmapper: Move UUID setup and verification code in a function

Browse source 
Simplify setupBaseImage() even further. Move some more code in a separate
function. Pure code reorganization. No functionality change.

Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
This commit is contained in:
Vivek Goyal 2015-10-06 08:38:03 -04:00
parent 69051ec0a5
commit 0fcd485626
1 changed files with 32 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
daemon/graphdriver/devmapper/deviceset.go
View file

@ -825,31 +825,48 @@ func (devices *DeviceSet) checkThinPool() error {
return nil return nil
} }
func (devices *DeviceSet) setupBaseImage() error { // Base image is initialized properly. Either save UUID for first time (for
oldInfo, _ := devices.lookupDeviceWithLock("") // upgrade case or verify UUID.
if oldInfo != nil && oldInfo.Initialized { func (devices *DeviceSet) setupVerifyBaseImageUUID(baseInfo *devInfo) error {
// If BaseDeviceUUID is nil (upgrade case), save it and // If BaseDeviceUUID is nil (upgrade case), save it and return success.
// return success.
if devices.BaseDeviceUUID == "" { if devices.BaseDeviceUUID == "" {
if err := devices.saveBaseDeviceUUID(oldInfo); err != nil { if err := devices.saveBaseDeviceUUID(baseInfo); err != nil {
return fmt.Errorf("Could not query and save base device UUID:%v", err) return fmt.Errorf("Could not query and save base device UUID:%v", err)
} }
return nil return nil
} }
if err := devices.verifyBaseDeviceUUID(oldInfo); err != nil { if err := devices.verifyBaseDeviceUUID(baseInfo); err != nil {
return fmt.Errorf("Base Device UUID verification failed. Possibly using a different thin pool than last invocation:%v", err) return fmt.Errorf("Base Device UUID verification failed. Possibly using a different thin pool than last invocation:%v", err)
} }
return nil
}
func (devices *DeviceSet) setupBaseImage() error {
oldInfo, _ := devices.lookupDeviceWithLock("")
// base image already exists. If it is initialized properly, do UUID
// verification and return. Otherwise remove image and set it up
// fresh.
if oldInfo != nil {
if oldInfo.Initialized {
if err := devices.setupVerifyBaseImageUUID(oldInfo); err != nil {
return err
}
return nil return nil
} }
if oldInfo != nil && !oldInfo.Initialized {
logrus.Debugf("Removing uninitialized base image") logrus.Debugf("Removing uninitialized base image")
if err := devices.DeleteDevice(""); err != nil { if err := devices.DeleteDevice(""); err != nil {
return err return err
} }
} }
// If we are setting up base image for the first time, make sure
// thin pool is empty.
if devices.thinPoolDevice != "" && oldInfo == nil { if devices.thinPoolDevice != "" && oldInfo == nil {
if err := devices.checkThinPool(); err != nil { if err := devices.checkThinPool(); err != nil {
return err return err