Simplify id generation

Instead of using a SHA-256 of a random number, hex encode 32 bytes
of random data from crypto/rand (sourced from /dev/urandom).

image.go

@@ -1,13 +1,12 @@
 package docker
 
 import (
-	"bytes"
+	"crypto/rand"
-	"crypto/sha256"
+	"encoding/hex"
 	"encoding/json"
 	"fmt"
 	"io"
 	"io/ioutil"
-	"math/rand"
 	"os"
 	"path"
 	"strings"
@@ -162,20 +161,12 @@ func ValidateId(id string) error {
 }
 
 func GenerateId() string {
-	// FIXME: don't seed every time
+	id := make([]byte, 32)
-	rand.Seed(time.Now().UTC().UnixNano())
+	_, err := io.ReadFull(rand.Reader, id)
-	randomBytes := bytes.NewBuffer([]byte(fmt.Sprintf("%x", rand.Int())))
+	if err != nil {
-	id, _ := ComputeId(randomBytes) // can't fail
+		panic(err) // This shouldn't happen
-	return id
-}
-
-// ComputeId reads from `content` until EOF, then returns a SHA of what it read, as a string.
-func ComputeId(content io.Reader) (string, error) {
-	h := sha256.New()
-	if _, err := io.Copy(h, content); err != nil {
-		return "", err
 	}
-	return fmt.Sprintf("%x", h.Sum(nil)), nil
+	return hex.EncodeToString(id)
 }
 
 // Image includes convenience proxy functions to its graph