diff --git a/opts/opts.go b/opts/opts.go index 1b57b77536..e2596983cf 100644 --- a/opts/opts.go +++ b/opts/opts.go @@ -207,10 +207,10 @@ func ValidateExtraHost(val string) (string, error) { // allow for IPv6 addresses in extra hosts by only splitting on first ":" arr := strings.SplitN(val, ":", 2) if len(arr) != 2 || len(arr[0]) == 0 { - return "", fmt.Errorf("bad format for add-host: %s", val) + return "", fmt.Errorf("bad format for add-host: %q", val) } if _, err := ValidateIPAddress(arr[1]); err != nil { - return "", fmt.Errorf("bad format for add-host: %s", val) + return "", fmt.Errorf("invalid IP address in add-host: %q", arr[1]) } return val, nil } diff --git a/opts/opts_test.go b/opts/opts_test.go index 68a715567c..0f6bc4c28d 100644 --- a/opts/opts_test.go +++ b/opts/opts_test.go @@ -1,6 +1,7 @@ package opts import ( + "strings" "testing" ) @@ -113,11 +114,11 @@ func TestValidateExtraHosts(t *testing.T) { `ipv6local:::1`, } - invalid := []string{ - `myhost:192.notanipaddress.1`, - `thathost-nosemicolon10.0.0.1`, - `anipv6host:::::1`, - `ipv6local:::0::`, + invalid := map[string]string{ + `myhost:192.notanipaddress.1`: `invalid IP`, + `thathost-nosemicolon10.0.0.1`: `bad format`, + `anipv6host:::::1`: `invalid IP`, + `ipv6local:::0::`: `invalid IP`, } for _, extrahost := range valid { @@ -126,9 +127,13 @@ func TestValidateExtraHosts(t *testing.T) { } } - for _, extrahost := range invalid { - if _, err := ValidateExtraHost(extrahost); err == nil { - t.Fatalf("ValidateExtraHost(`" + extrahost + "`) should have failed validation") + for extraHost, expectedError := range invalid { + if _, err := ValidateExtraHost(extraHost); err == nil { + t.Fatalf("ValidateExtraHost(`%q`) should have failed validation", extraHost) + } else { + if !strings.Contains(err.Error(), expectedError) { + t.Fatalf("ValidateExtraHost(`%q`) error should contain %q", extraHost, expectedError) + } } } }