From 1e0e86360f8fefbeb3d70642aa0402bcb0c97a1a Mon Sep 17 00:00:00 2001 From: Alexandr Morozov Date: Tue, 17 Jun 2014 11:24:47 +0400 Subject: [PATCH] Move TestBuildOnBuildForbiddenChainedTrigger to integration-cli Docker-DCO-1.1-Signed-off-by: Alexandr Morozov (github: LK4D4) --- integration-cli/docker_cli_build_test.go | 17 +++++++++++++++++ integration/buildfile_test.go | 14 -------------- 2 files changed, 17 insertions(+), 14 deletions(-) diff --git a/integration-cli/docker_cli_build_test.go b/integration-cli/docker_cli_build_test.go index 48ac7e5861..6d4d2b096c 100644 --- a/integration-cli/docker_cli_build_test.go +++ b/integration-cli/docker_cli_build_test.go @@ -1307,3 +1307,20 @@ func TestBuildOnBuild(t *testing.T) { } logDone("build - onbuild") } + +func TestBuildOnBuildForbiddenChained(t *testing.T) { + name := "testbuildonbuildforbiddenchained" + defer deleteImages(name) + _, err := buildImage(name, + `FROM busybox + ONBUILD ONBUILD RUN touch foobar`, + true) + if err != nil { + if !strings.Contains(err.Error(), "Chaining ONBUILD via `ONBUILD ONBUILD` isn't allowed") { + t.Fatalf("Wrong error %v, must be about chaining ONBUILD", err) + } + } else { + t.Fatal("Error must not be nil") + } + logDone("build - onbuild forbidden chained") +} diff --git a/integration/buildfile_test.go b/integration/buildfile_test.go index 7b8fd7b178..dd240d4cb3 100644 --- a/integration/buildfile_test.go +++ b/integration/buildfile_test.go @@ -413,20 +413,6 @@ func buildImage(context testContextTemplate, t *testing.T, eng *engine.Engine, u return image, err } -func TestBuildOnBuildForbiddenChainedTrigger(t *testing.T) { - _, err := buildImage(testContextTemplate{` - from {IMAGE} - onbuild onbuild run echo test - `, - nil, nil, - }, - t, nil, true, - ) - if err == nil { - t.Fatal("Error should not be nil") - } -} - func TestBuildOnBuildForbiddenFromTrigger(t *testing.T) { _, err := buildImage(testContextTemplate{` from {IMAGE}